From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 4357 invoked by alias); 25 Nov 2015 09:20:25 -0000 Mailing-List: contact zsh-users-help@zsh.org; run by ezmlm Precedence: bulk X-No-Archive: yes List-Id: Zsh Users List List-Post: List-Help: X-Seq: 20986 Received: (qmail 13580 invoked from network); 25 Nov 2015 09:20:23 -0000 X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on f.primenet.com.au X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,FREEMAIL_FROM, HTML_MESSAGE,T_DKIM_INVALID autolearn=ham autolearn_force=no version=3.4.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=/ghaEphehYhNkcq8A+wN/wdq94FJH8nTSGL71XjPjsc=; b=OC0ikftFqXhXe8PGCt+a6ayNBzKiRGnEeZOQvJW3LiLfVZQvfe4w7IKOcvi3bg7gWo pSnryyrjnp5RjQTimXqQy/pvAMpyBXN/b2Ney6bYXZtNsZVSFHjG0PSfGPmHFaijKZek FgfKPC907axUCAPWEypPyXoZJU8Pdg94cEwI5vG+Vj3mfmrjk/qwloRalDqq8Cz0Msl/ 5Yubw9QK7Y9kRPwyGhTkaJVYamV5pCi7Hy9YWh7Xi6kG9YUtjYfVzOakqbHGOaBcqPZY 3YpSu4GqlgcEy9+NnFBDB+MUazGm+lsP1gBILMigy18xx0EezrcXQEKt4gfBJxycu2nV /0NA== MIME-Version: 1.0 X-Received: by 10.28.51.135 with SMTP id z129mr3184564wmz.19.1448443221599; Wed, 25 Nov 2015 01:20:21 -0800 (PST) In-Reply-To: References: Date: Wed, 25 Nov 2015 16:20:21 +0700 Message-ID: Subject: Re: [Zsh bug] function define bug From: Cuong Manh Le To: =?UTF-8?B?TmfDtCBIdXk=?= Cc: Matthew Martin , Zsh Users Content-Type: multipart/alternative; boundary=001a1144424eb36e2e052559f794 --001a1144424eb36e2e052559f794 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Hi Huy, It's a good point, but in the user perspective, turn off `multifuncdef` is not much useful: $ unsetopt multifuncdef $ echo 1 | grep foobar(){ echo 1; } zsh: parse error near `()' You still stuck and can not use `grep`. The right way to use it from the beginning is quote the grep string pattern if it contains any shell meta characters. Also in zsh documentation http://zsh.sourceforge.net/Doc/Release/Options.html#index-MULTIFUNCDEF , it said that: Multiple function definitions are not often used and can cause obscure > errors. Maybe we should add an example to that section. Best. On Wed, Nov 25, 2015 at 4:03 PM, Ng=C3=B4 Huy wrote= : > Dear Cuong, > > 2015-11-25 15:49 GMT+07:00 Cuong Manh Le : > >> Hi Severus, >> >> Can you give a demo? >> >> You can turn off `mult=C3=AC_func_def` but you can always do multiple fu= nction >> definition with reserved word `function` >> >> Best. >> >> >> On Wed, Nov 25, 2015 at 11:20 AM, Ng=C3=B4 Huy w= rote: >> >>> Dear Matthew >>> >>> 2015-11-25 11:06 GMT+07:00 Matthew Martin : >>> >>> > On Tue, Nov 24, 2015 at 9:46 PM, Ng=C3=B4 Huy >>> wrote: >>> > > Dear folks, >>> > > >>> > > I found the problem in zsh define function. Demo >>> > > >>> > > ls test() { echo "Bug !!!"} && ls && test >>> > > >>> > > it will print >>> > > >>> > > Bug !!! >>> > > Bug !!! >>> > >>> > >>> > That's expected behaviour. Since MULTI_FUNC_DEF is set by default in >>> zsh >>> > mode, both ls and test are being defined as functions with the body >>> > echo "Bug !!!". >>> > >>> > % func1 func2 () { echo This is "$0"; } >>> > % func1; func2 >>> > This is func1 >>> > This is func2 >>> > % which func{1,2} >>> > func1 () { >>> > echo This is "$0" >>> > } >>> > func2 () { >>> > echo This is "$0" >>> > } >>> > % unsetopt MULTI_FUNC_DEF >>> > % func1 func2 () { echo This is "$0"; } >>> > zsh: parse error near `()' >>> > >>> >>> I know this behavior likes advanced programming language but >>> mult=C3=AC_func_def >>> should be turned off by default, it leads to risky problem when someone >>> searchs as grep, ls malicious strings without quote >>> >>> >>> Kind regards, >>> Severus >>> >> >> this's just example: cat file | grep foobar(){ rm -rf *} > grep wil execute rest of body > > Kind regards, > Severus > --001a1144424eb36e2e052559f794--