From mboxrd@z Thu Jan 1 00:00:00 1970 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-3.4 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FROM,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.4 Received: (qmail 1311 invoked from network); 23 Nov 2020 18:31:56 -0000 Received: from zero.zsh.org (2a02:898:31:0:48:4558:7a:7368) by inbox.vuxu.org with ESMTPUTF8; 23 Nov 2020 18:31:56 -0000 ARC-Seal: i=1; cv=none; a=rsa-sha256; d=zsh.org; s=rsa-20200801; t=1606156316; b=mdiCYN4p1NxwmvXkXE49CWofKq0g+WlzBqnkMl/96ijTiOsgejt3Z7hpY8EppGfufN8EYiYdN/ 8+2fnK1c+eQCAqUcMo0egfqnjD2EfetSmScLIsYqSl+cxs3sXBANBGswYScS5FfKdRKyKRe3KK ud9EQg4UhtoHt6lzr34ObAJP8wA1vOU5Eq7kaE8dv3G+uvZ91HIcDm6UKZ2x1pxZbRPGh52Cjp 6UrZQ2m3Nol5HmJ60M169RrT09IDVTdMsnCr891BqydIymtFjl/qammQlaYUFrL5cfsJAbElxc NxNPSnXmvOnR/BDgPhdnAmxTYg2KFpuJgOFg/TS/N4W2Aw==; ARC-Authentication-Results: i=1; zsh.org; iprev=pass (mail-wm1-f52.google.com) smtp.remote-ip=209.85.128.52; dkim=pass header.d=gmail.com header.s=20161025 header.a=rsa-sha256; dmarc=pass header.from=gmail.com; arc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed; d=zsh.org; s=rsa-20200801; t=1606156316; bh=wx1By45V0aLQjgWCu3wDXpCSBRxG5G2XUG0+Yb/BQ9I=; h=List-Archive:List-Owner:List-Post:List-Unsubscribe:List-Subscribe:List-Help: List-Id:Sender:Content-Transfer-Encoding:Content-Type:Cc:To:Subject: Message-ID:Date:From:In-Reply-To:References:MIME-Version:DKIM-Signature: DKIM-Signature; b=RNDrjPZbmDEBUqDWhbdDs2ZyOC8PJt9JsEiLM7ix7hZ2sz75bTEAQvfNnvpBlvqRqCr8tZH5j8 0fTzrPIPWLHvcIz9UZKXMyRcIX5qcbASEPF3SdvIs7ITh3qFa5vLIJ99l3UEz/nVCAP5Kxl6D/ gZztVNfJF7PEebMkDuyXk5zJhmO25IyYW7fSdN/eSGFTlHmbS8ZPBs4AdVoYJpnrepGx0Dpcwr 9dtDoK1xD962F5R1TiY7apCOGX2Y6G6AWBSTmgLKJPOzPCm6xHsDsU5CQacbcUD7vCUXE+9DqL ahCbki6R1MhgdO01uuv3kRdWMmflWrJiFJ/8lVrM1P6l9A==; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=zsh.org; s=rsa-20200801; h=List-Archive:List-Owner:List-Post:List-Unsubscribe: List-Subscribe:List-Help:List-Id:Sender:Content-Transfer-Encoding: Content-Type:Cc:To:Subject:Message-ID:Date:From:In-Reply-To:References: MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID; bh=SR4Qld3wW7+ded9oB3XAv81pG3v88RAL3Wgx317xjCA=; b=tVGvh0awH5vMhPQ39gHR6POVG/ G2Oc1xxvG5ABxl4p2vFtHHQ7LNBhuyKumKrA/I0E2S1sU35Z/7fPvCnfofr2YnREmEKP8Xd17haGc kd7QldU2C69RjFyIfFjls2bOvHybxFW1azV3csvuIiEj/bLbc/GEp1tT0w4/LfPvhvMX6R/pgPQiV OTsnrdZjFUQND6sfw8p9DwkYbuMaae7LGjveDJo+kAA1AmzTDZpnOQmAr+KpUw5lHAEKC7Oy1EUrn LxU29rD0ideZBLvRISB4t6ka9DKxOenBLnvy+BKNZrBAqFWtzqKjt0I3ABcTjyKgnndbn2yxJFWiY X0vNr7Mw==; Received: from authenticated user by zero.zsh.org with local id 1khGd0-000M4X-PS; Mon, 23 Nov 2020 18:31:54 +0000 Authentication-Results: zsh.org; iprev=pass (mail-wm1-f52.google.com) smtp.remote-ip=209.85.128.52; dkim=pass header.d=gmail.com header.s=20161025 header.a=rsa-sha256; dmarc=pass header.from=gmail.com; arc=none Received: from mail-wm1-f52.google.com ([209.85.128.52]:54642) by zero.zsh.org with esmtps (TLS1.3:TLS_AES_128_GCM_SHA256:128) id 1khGcU-000Lgt-FE; Mon, 23 Nov 2020 18:31:24 +0000 Received: by mail-wm1-f52.google.com with SMTP id d142so133905wmd.4 for ; Mon, 23 Nov 2020 10:31:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=SR4Qld3wW7+ded9oB3XAv81pG3v88RAL3Wgx317xjCA=; b=c0ow7tIn+3muEBUNUh7QIXNseCdIe7baZFBtd3fkr2SVbgZyAZ1d3PU4d3TNezpbmM meE2OHkCOpMtvcPLLvoquZrxLzefukX6NaRFYddc+BnwHx/DctmwGhH0Zjk36rH/QXAA PNevZKgg+Bt7Kj8/qlTWGmsYwY9mS9q8emAaMFC30LW0zfdPOqM0IXoJSpTip5mIWTi7 GZ/qZ3gVjzWMDzuAt4KSE9h/u+FInGZbNUjEMoQqlL8lXinEdv8t6KW9E2jokTV6FcI4 ixJL14D+kPI2JrPQx6eGbaWzjWVVz3A3UCBKh/AWbR7KYT6ikl6kC1kJKJV3O3Yhd5Jt QNwQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=SR4Qld3wW7+ded9oB3XAv81pG3v88RAL3Wgx317xjCA=; b=of3B/dhFYHb8RU/r4ws3ovSg/jPHaa5nT0Pdox+/3cS9MPUmxzAOL3n/WRdZjnkIQx yutdo5ozs0jPU0HwieSTcW4vhyv0hHkiPCmYvm6CNFATEKPri9RyBkqb4fz6s0eMhEd5 4StMllzXYqaoYv63WZ8BXIO6tT2gVSOYgiojoluWofY2Wv5PmTZUsZ4Qoj4zvKRZdlgv UwqaL0ub8om6GkoJCr3UVcx4d03o4b0oBKAV7lf+uQnTP3rZva7O5lpN2adu+yHD+Lcp +6iNgeobZKnSWnAbt752fu8TtDbivksBugR2A1UsvP8oOBmIFwq612rPNlKdkU4DYZrd TA9w== X-Gm-Message-State: AOAM5300yRy22DzVoCOuvg71llympluzgSViOuvjixQIEkNgZD5Xs8/r ZZZ4vrUjXiArpZgsdBmeFn/x4JTx1jLZN87+SRISJIxbz+AN5A== X-Google-Smtp-Source: ABdhPJw55Dsesq6zfkqdD9U83t5gXp5Edl20+oTtjU5IhvvVH8kTfs2NH8lDJYZgN7IVzomVuOx6X8H0Tzww/CQ0zB8= X-Received: by 2002:a7b:c3d5:: with SMTP id t21mr201451wmj.37.1606156281899; Mon, 23 Nov 2020 10:31:21 -0800 (PST) MIME-Version: 1.0 References: <20e670fa-074d-40c8-8bfd-b148fd0e3e77@www.fastmail.com> <20201123043359.GC31253@tarpaulin.shahaf.local2> <20201123154446.GA15080@tarpaulin.shahaf.local2> In-Reply-To: <20201123154446.GA15080@tarpaulin.shahaf.local2> From: Felipe Contreras Date: Mon, 23 Nov 2020 12:31:10 -0600 Message-ID: Subject: Re: git-completion 1.2 released To: Daniel Shahaf Cc: Zsh Users Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Seq: 26199 Archived-At: X-Loop: zsh-users@zsh.org Errors-To: zsh-users-owner@zsh.org Precedence: list Precedence: bulk Sender: zsh-users-request@zsh.org X-no-archive: yes List-Id: List-Help: List-Subscribe: List-Unsubscribe: List-Post: List-Owner: List-Archive: Archived-At: On Mon, Nov 23, 2020 at 9:44 AM Daniel Shahaf wrot= e: > > Felipe Contreras wrote on Mon, Nov 23, 2020 at 01:49:16 -0600: > I suspect that TODO comment should simply be deleted for vagueness, > especially given its age. I suspect so too. It seems Nikolai Weibull added that comment for some reason in 2011 but he hasn't been active for a lot of time and nobody removed it. > > And there's a lot of others. > > If so, they haven't been reported. We can't fix bugs unless they are > reported to us. Well, I do fix bugs before they are reported, because I use git all the time, and I use git completion all the time, and I also developed a testing framework for the completion so users don't have to be bitten by bugs in order to find them. > > I did some hacks to run Zsh's official Git completion against Git's > > testing framework, and at least half of them fail. I could tell you > > how to do that if you are interested. > > Thanks for the offer. We would be interested, if the results could be us= ed > without licensing concerns. zsh's _git is BSD-licensed. It depends what part of the tests you want to use. Many of the tests were developed by me, so I own the copyright. I pushed the branch to my repository: https://github.com/felipec/git-completion/blob/zsh-system/test/completion-z= sh-system.t 32 tests fail, 38 pass. Just run that script with Bash. > > So in my view it's clear the priorities of the two completions are > > very different. > > It's nothing as deliberate as that. It's more likely just that nobody > ever reported the bug whilst someone able and inclined to fix it > happened to be listening. In many cases nobody reported the bugs to the Git mailing list either. Git developers themselves find the areas of opportunity. > Also, in the specific case of =C2=ABgit -C=C2=BB, the Git maintainers pro= bably use > that option far more often than the average zsh user does (to run their > HEAD builds against test repositories). Precisely. But I'm talking more about the speed. This is the thing is very clear Git developers care about, as they often perform tests on the Bash completion itself, and optimize it, shaving milliseconds here and there. I sent a patch to exemplify how this speed can be leveraged from Zsh's official completion, for example using __git_complete_revlist, which is extremely fast, compared to whatever the Zsh completion is doing. Yes, it probably doesn't autocomplete exactly the same list, but it's more than good enough. These are the priorities I'm talking about; mainly the compromise in completeness in order to get more usability (actually save the user's time while completing commands). Cheers. --=20 Felipe Contreras