From: Felipe Contreras <felipe.contreras@gmail.com>
To: Bart Schaefer <schaefer@brasslantern.com>
Cc: Zsh Users <zsh-users@zsh.org>
Subject: Re: completion within a function
Date: Sun, 3 Jan 2021 17:16:34 -0600 [thread overview]
Message-ID: <CAMP44s0yan_xueZgCbWaiGvB-XwfaihovcA43W0d-4Aurnx=dg@mail.gmail.com> (raw)
In-Reply-To: <CAH+w=7YY62Lr567B2+GfHu+hRW=+Q-baN0q5OFCSC7cMW4p+uQ@mail.gmail.com>
On Sat, Jan 2, 2021 at 9:31 PM Bart Schaefer <schaefer@brasslantern.com> wrote:
>
> On Sat, Jan 2, 2021 at 6:47 PM Felipe Contreras
> <felipe.contreras@gmail.com> wrote:
> >
> > OK. That works. Takes 8.7s to complete on the Linux repository with
> > 3350 entries on my system, but it does complete.
>
> That's likely because it's doing "compinit -D". It would go faster
> for subsequent tests if they all ran in the same shell with that
> pre-loaded.
At the moment I can't do that, it has to be a new shell every time,
and your version seems to take longer to load, slowing the tests.
> > You do see why I think 'git checkout ' is more friendly than 'git'
> > 'checkout' '', right?
>
> For your usage, I do, but that makes it a bit harder to separate the
> context from the completions.
OK. But it still doesn't work correctly: I can't pass empty arguments
in the middle of a command-line.
For example in the tests I added a fake "func" command that calls a
function, for example:
git func __gitcomp_opts "octopus ours recursive resolve subtree" ""
"re" --strategy=re
Why my method that works fine, with your method what effectively ends
up happening is the equivalent of:
git func __gitcomp_opts "octopus ours recursive resolve subtree"
"re" --strategy=re
The "" is there in the array, I don't know why varead seems to ignore it.
Also, I don't understand why is there an argv there:
vared -M __complete -i __init_complete ${${argv:+argv}:-reply}
(( ARGC )) || print -nrl -- "~~~${(@)reply}~~~"
Isn't "reply" always used? And ARGC is always 0?
Cheers.
--
Felipe Contreras
next prev parent reply other threads:[~2021-01-03 23:17 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-29 15:24 Ray Andrews
2020-12-29 18:52 ` Bart Schaefer
2020-12-29 19:36 ` Felipe Contreras
2020-12-29 19:41 ` Roman Perepelitsa
2020-12-29 21:04 ` Ray Andrews
2020-12-29 21:21 ` Ray Andrews
2020-12-29 22:03 ` Bart Schaefer
2020-12-29 21:48 ` Bart Schaefer
2020-12-30 0:31 ` Ray Andrews
2020-12-30 4:34 ` Roman Perepelitsa
2020-12-30 16:45 ` Ray Andrews
2020-12-30 17:21 ` Felipe Contreras
2020-12-30 20:43 ` Bart Schaefer
2020-12-30 20:46 ` Bart Schaefer
2020-12-30 20:50 ` Ray Andrews
2020-12-30 21:31 ` Roman Perepelitsa
2020-12-30 22:05 ` Bart Schaefer
2020-12-30 22:18 ` Felipe Contreras
2020-12-30 23:47 ` Bart Schaefer
2020-12-31 0:08 ` Bart Schaefer
2020-12-31 0:12 ` Felipe Contreras
2020-12-31 0:30 ` Bart Schaefer
2020-12-31 0:39 ` Bart Schaefer
2020-12-31 1:04 ` Felipe Contreras
2020-12-31 21:25 ` Bart Schaefer
2021-01-01 0:12 ` Ray Andrews
2021-01-02 0:27 ` Bart Schaefer
2021-01-02 22:24 ` Bart Schaefer
2021-01-03 0:28 ` Felipe Contreras
2021-01-03 0:53 ` Bart Schaefer
2021-01-03 1:20 ` Felipe Contreras
2021-01-03 2:21 ` Bart Schaefer
2021-01-03 2:47 ` Felipe Contreras
2021-01-03 3:30 ` Bart Schaefer
2021-01-03 23:16 ` Felipe Contreras [this message]
2021-01-05 19:57 ` Bart Schaefer
2021-01-03 17:50 ` Bart Schaefer
2021-01-03 0:07 ` Felipe Contreras
2020-12-31 1:03 ` Felipe Contreras
2020-12-30 6:45 ` Bart Schaefer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAMP44s0yan_xueZgCbWaiGvB-XwfaihovcA43W0d-4Aurnx=dg@mail.gmail.com' \
--to=felipe.contreras@gmail.com \
--cc=schaefer@brasslantern.com \
--cc=zsh-users@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).