From mboxrd@z Thu Jan 1 00:00:00 1970 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-3.4 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FROM,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.4 Received: (qmail 4311 invoked from network); 22 Nov 2020 00:54:42 -0000 Received: from zero.zsh.org (2a02:898:31:0:48:4558:7a:7368) by inbox.vuxu.org with ESMTPUTF8; 22 Nov 2020 00:54:42 -0000 ARC-Seal: i=1; cv=none; a=rsa-sha256; d=zsh.org; s=rsa-20200801; t=1606006482; b=WsPlPC1bOng9kO2szAMEx663LklUxPMdD0OTinD5mcNjUnsTNQpBX4b6NwxKusiqOmmxF6a+jA fI9boBTfWGSPjhNrI1YuoNftK8J+3ddla5YjjcWQaJGcr/kRmjhfzihvhgOL0jMonV5H98Q89w qlQHn8/4+45AWyaHSKSiZiUBwWU+mYMVy5uqlUnd8zNTCY9WHlnM/ulqprmMXedzjuSNsMatzC 3m8NbRYv10enPfYYGUnCO63MKy4adtnyrjQuIhOCnZeZw14qqxo99jxuJUqKnS983EaLMU2EmZ N4f2D9AG3wZWQfr377tuAYaBGksoHqfA2TB+fJpUi9fSjw==; ARC-Authentication-Results: i=1; zsh.org; iprev=pass (mail-wr1-f66.google.com) smtp.remote-ip=209.85.221.66; dkim=pass header.d=gmail.com header.s=20161025 header.a=rsa-sha256; dmarc=pass header.from=gmail.com; arc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed; d=zsh.org; s=rsa-20200801; t=1606006482; bh=4cCtt0KR/3hsq5LzrzGlvlXJyr24x8aG0aTaH2IAD0Y=; h=List-Archive:List-Owner:List-Post:List-Unsubscribe:List-Subscribe:List-Help: List-Id:Sender:Content-Type:Cc:To:Subject:Message-ID:Date:From:In-Reply-To: References:MIME-Version:DKIM-Signature:DKIM-Signature; b=vK2ZLOy1cFmbcb8xatAm/BNESyXfdPvtOwOuGL2mZFXI4KsWsqNKQ7+C7EWJoqzb6dNzgLK3Da d5WPTicDHvVIh6Jq8myVV7TLqKlGOpiSQkeD/KCGk8TjfL5hmk+swBj9cMVDo9OtaDE/Mo7GEp tg22YdasOVStqeNLevuocI7dwWJ7Z+hoAkw9T9LHoDAiOkVmnWDXeWZ1ePyxEYfYS+lBrb27EV VJWm2TVhZambcxv/HzhwgbgCjfm5CSGUHmgPn/2rLETdkZH/5YL5zFpDttjSoN/07t6OVYEDXM iSGrl7tvnxx2I1HAuGsQc0RmpI1DRdbrbTF1B1GEP13DZg==; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=zsh.org; s=rsa-20200801; h=List-Archive:List-Owner:List-Post:List-Unsubscribe: List-Subscribe:List-Help:List-Id:Sender:Content-Type:Cc:To:Subject:Message-ID :Date:From:In-Reply-To:References:MIME-Version:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID; bh=z9b7ST1o+yGZ8ae4bj9LJZLWmkm7fJ5bEp9bQEwiYZk=; b=j/jkId1GxTeEe1JdmOZO35FeIe qvBLvwCKQqqdXDEJLXgeO7TB80MukxElQk+Y3Lbc9fov+bIjq/8QFLX+Ndg/chBzvD/QVqVE0CJ+n bflvi8BvNk8A3aF3JUr1yHZYh2xfCYCZtrBYRLtYVXPlqgn/j6wn80J1HWUzN50NS6bmzM6YEPWna MWAhhTeyW9ZcgnDyXzKzV3HaUZHfo8GgcUek5qtBqVhcT9LTYAdW7dQeNQRd0N4XehWx+wLbUkyFk HRGNtc40sqxhesHHy58FmK6fzWGNENZj29nsC3o6oD4jZRrTC/uOLC5N/zOPwXGrCM4HFckylZmYF LSrJRLFg==; Received: from authenticated user by zero.zsh.org with local id 1kgdeG-0002V2-So; Sun, 22 Nov 2020 00:54:36 +0000 Authentication-Results: zsh.org; iprev=pass (mail-wr1-f66.google.com) smtp.remote-ip=209.85.221.66; dkim=pass header.d=gmail.com header.s=20161025 header.a=rsa-sha256; dmarc=pass header.from=gmail.com; arc=none Received: from mail-wr1-f66.google.com ([209.85.221.66]:41805) by zero.zsh.org with esmtps (TLS1.3:TLS_AES_128_GCM_SHA256:128) id 1kgddp-00028O-2z; Sun, 22 Nov 2020 00:54:10 +0000 Received: by mail-wr1-f66.google.com with SMTP id 23so14788780wrc.8 for ; Sat, 21 Nov 2020 16:54:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=z9b7ST1o+yGZ8ae4bj9LJZLWmkm7fJ5bEp9bQEwiYZk=; b=WgC9boI6MLwGimE9aG0jjW13WcPMpMniUi8dvXJBVS+kurOIZDnAupknNncnC02Enl c68+3263ZSbN4lRJsYXuBqX049Ivi8UJSRuDQCDARe6h81GIt1GltK5DfX5Kn16bJd5V OYMDmoojPIQjDDtOYV2BZFUgbg62Iu/A7MQSJeFqbpSAlCOTFr9IUUtWjIwmGDoG9no8 vk7OYkf8vC2JxrmSPfiTsKbGk79uTjAJMXVCZud0J13io4ID0Ozj8hIAl8TPUYY6Q1aL 0JzLCsjah+Mlzt7NI8sY6c4o/4t1HRBPcOU9aaVUCeQzwRABNuztel3XKNuu5cMsoC2g hUqQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=z9b7ST1o+yGZ8ae4bj9LJZLWmkm7fJ5bEp9bQEwiYZk=; b=mS4lzwxKDt+RR8shyRCEaFLK4Z1T+OnOA7a/MqP+XXC77KN7WJxL5mcZ8hAzROxT6J pjyR2OwKA4fxv1B6HqJVpPz50hhFoZKN2W0cHReMFFsJkdJb1lK6CFBVGEvPHC5icbgZ ebKvmyvKhHA89JOe1RK0+iOayBWI9iHwO7geAreBPYTAsTdGIpUAi+UtPDqRcZAqQhUU Cs/ae1UQsgg/D/9mwsHvKkE7JH4ep35BPhApCWXTzKOCMIHxjFivMc7ZjRfngTuGbnbc lK+2mTUqi7MtxZXS77q0NRL1BQ69MfJNpQKgVRTlvGOSj5j1KZpeECopw1UudPls4pMT T/Pw== X-Gm-Message-State: AOAM530Eo3tVKW8iw1Gpq6Z6oqe9WZUZe9BnjmifhnrFRsPalT6oMAUk Nxs8tWtjJDaoW2vtaWfZXcALtWlSEaTeIfW4spo= X-Google-Smtp-Source: ABdhPJyZxOSoFMgPc6vVCHGa+VyVqr7KpKotCLlsmDtV1BKnu1fAdjIVe0dpxgbfCchno54Lnvrvw3WveGraExSHv04= X-Received: by 2002:a5d:52c1:: with SMTP id r1mr24775395wrv.255.1606006448745; Sat, 21 Nov 2020 16:54:08 -0800 (PST) MIME-Version: 1.0 References: <20e670fa-074d-40c8-8bfd-b148fd0e3e77@www.fastmail.com> In-Reply-To: <20e670fa-074d-40c8-8bfd-b148fd0e3e77@www.fastmail.com> From: Felipe Contreras Date: Sat, 21 Nov 2020 18:53:56 -0600 Message-ID: Subject: Re: git-completion 1.2 released To: Daniel Shahaf Cc: zsh-users@zsh.org Content-Type: text/plain; charset="UTF-8" X-Seq: 26192 Archived-At: X-Loop: zsh-users@zsh.org Errors-To: zsh-users-owner@zsh.org Precedence: list Precedence: bulk Sender: zsh-users-request@zsh.org X-no-archive: yes List-Id: List-Help: List-Subscribe: List-Unsubscribe: List-Post: List-Owner: List-Archive: Archived-At: On Sat, Nov 21, 2020 at 10:05 AM Daniel Shahaf wrote: > > Felipe Contreras wrote on Thu, 19 Nov 2020 16:05 +00:00: > > Git-completion is a friendly fork of the official Git completion and > > prompt scripts for Zsh and Bash. > > > > The main goal is to provide a more up-to-date completion for Zsh (I'm > > the developer), which is basically just a wrapper around the Bash > > completion. > > I was going to invite you to send patches to zsh's own _git, but then I > noticed that in README.asciidoc you claim that you've sent patches to > zsh's completion and "many" of them have been "ignored": Git's zsh completion, not Zsh's Git completion. > > Compared to Git upstream, you get many benefits for Zsh, for example: > > no extra unnecessary spaces, correct auto suffix removal, colors > > without PROMPT_COMMAND, custom aliases, fixed --no-options, and many > > more. > > I suspect some of these have been fixed in zsh's _git since you last > looked and others are configurable. (E.g., git-send-email(1), which you > mention below, completes not only files but also recent commits, and has > done so for a while.) But the main use of "git send-email" is not to receive random files, it's to receive comittishes, and potentially some .patch files. If I do "git send-email master.." nothing completes with Zsh's official completion. It does with mine. > I also suspect that zsh's _git has features that yours lacks. Of course, but unlikely any that Git developers themselves consider essential, since they are fine with Git's Bash completion. > > If you use the official Zsh completion the main benefit is that it's > > blazingly fast. Simply doing "git log " on the Linux kernel (with > > 3k+ refs) takes several seconds on the official Zsh completion (about > > 3 seconds on my machine), with git-complete it's *instantaneous*. > > > > Are you comparing apples to apples or to oranges? I.e., does it take > more time to produce the _same set_ of result, or to produce a > different set? I don't personally care. Git's official completion returns a list of more than 3,000 items. I don't think Zsh's Git completion returning *more* helps anyone. If it takes more for the completion system to return a completion; it's defeating its purpose. I'd rather type it myself. Cheers. -- Felipe Contreras