From mboxrd@z Thu Jan 1 00:00:00 1970 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-3.4 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FROM,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.4 Received: (qmail 20199 invoked from network); 23 Nov 2020 07:50:02 -0000 Received: from zero.zsh.org (2a02:898:31:0:48:4558:7a:7368) by inbox.vuxu.org with ESMTPUTF8; 23 Nov 2020 07:50:02 -0000 ARC-Seal: i=1; cv=none; a=rsa-sha256; d=zsh.org; s=rsa-20200801; t=1606117802; b=wC+or6kxKEf4EO5/YHBIkUyQ9g3/1Ssx1+iJekwTh+oku3IbQ6lQi+fqpkcvFUphCVdnDEdrOA IO5fqP9HVAXycRgb6WPcxXxHn0jpHSQfQC7Y0ZzK7coL2MJ8app+3CgZOB31zhRYklMdurPNQ3 diAqUm70Pv05h2sFZ1IZnpWUEpJVys9VmCL4OxqZf712fukxGBqcoD81R/adWQ5Fwn3jK0easB OehFK3dsO1grahuQN31UtR+8SevyenXjlmhuyUwMKqIA6SROodgrab4DeLDAZeTGhDcZNp+5WH l5PBHBGaRAlW9olIPt/kjQF5l0nSfJqnyhjYzk6TRLKEgg==; ARC-Authentication-Results: i=1; zsh.org; iprev=pass (mail-wr1-f51.google.com) smtp.remote-ip=209.85.221.51; dkim=pass header.d=gmail.com header.s=20161025 header.a=rsa-sha256; dmarc=pass header.from=gmail.com; arc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed; d=zsh.org; s=rsa-20200801; t=1606117802; bh=viIXaYcJ1ogucXXMqqtvdpb3cKM4mNOTC93P4+Km4IU=; h=List-Archive:List-Owner:List-Post:List-Unsubscribe:List-Subscribe:List-Help: List-Id:Sender:Content-Type:Cc:To:Subject:Message-ID:Date:From:In-Reply-To: References:MIME-Version:DKIM-Signature:DKIM-Signature; b=WICK65Iqqlben/S6zegrdSt8t2F1K2htPAFAwo5tTOyrAUjG91pHN66p3SSHjAReiu/BwbNo6H iRnJUKc6g0Y8YM6YVOykLLdN2pGl2N8UDWTmD6ltUvSFtTCn16ksh69l9/N5FMl7k5Pxx6k/he jceI+UVMwRr9kzWAaR3gQx8hRF31NHu86+bGWZtneZMAmFW0fR3oFhlZyJ0YHGiRIweq0yHXpe nBMQPRMBw509nTsxPuqrkJNmE5mVET3GPuaIzhBWJKUvLJSBNxO9SUt8D+OfvkKDzTcXv6y+w7 MUmomNV+qt2GUs2DiEC1DPHYyU2RJcEWIF9Ish7UHg+WOg==; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=zsh.org; s=rsa-20200801; h=List-Archive:List-Owner:List-Post:List-Unsubscribe: List-Subscribe:List-Help:List-Id:Sender:Content-Type:Cc:To:Subject:Message-ID :Date:From:In-Reply-To:References:MIME-Version:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID; bh=h1rfJIBBFnprCdVCpR0INLDvNmJPx2aLLEvFKY8jTJE=; b=oPL0xXMf1R86FLHBy5/vbaFLE7 i+498KL8P9Cz3uRl1ueLKUI6jGlQkCcpq/k7gj2pVcndnRkQlb2FfnwNGj900/JAfPWJda+p0p5Ay 7LjMrKUSycoReQQw8mxN7Ivj4lmCV4+YLUgNQYEXomshFACwlFn/vq/TZcY6nV5TpXRH2cCW/FhG+ 1KnLBeY/0fxHS9HnbeB5qhIoRcNbKkveFYBNMm4rXX2ziDxqU8V+GXQKvlpfp8LzAHAVugbC6GOyp 9duIYl7otIeGNvDriZMmy4bIV4FX6EDkpE5/XBqDgC+lI4m7j9oJIIlGyPqZfd50QXD39ZQqSHF6R C+ySKJcA==; Received: from authenticated user by zero.zsh.org with local id 1kh6bl-0004kp-OJ; Mon, 23 Nov 2020 07:49:57 +0000 Authentication-Results: zsh.org; iprev=pass (mail-wr1-f51.google.com) smtp.remote-ip=209.85.221.51; dkim=pass header.d=gmail.com header.s=20161025 header.a=rsa-sha256; dmarc=pass header.from=gmail.com; arc=none Received: from mail-wr1-f51.google.com ([209.85.221.51]:35753) by zero.zsh.org with esmtps (TLS1.3:TLS_AES_128_GCM_SHA256:128) id 1kh6bI-0004O1-0D; Mon, 23 Nov 2020 07:49:28 +0000 Received: by mail-wr1-f51.google.com with SMTP id k2so17643604wrx.2 for ; Sun, 22 Nov 2020 23:49:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=h1rfJIBBFnprCdVCpR0INLDvNmJPx2aLLEvFKY8jTJE=; b=m/daAzBDgcDquIqlxG2jqeISITzUlmw7qLWl4iedjFNBLtiJ1boF/AxHStOPjbWUlp s/8CbX/F+/WTOp8LtQL7Wm3R6H2GfmT/lnpzsy46g6p9suARH3AjJWOWzNmqDxynlgPD H1M//pX5qKdPxuJFlsw+wTXOAhnkZK66+tqOZVjV81ZF92dWIUaQRbvSgBrSfOh2PAeo WIrP5cGXjEp9P2RiDKOubSrDfEKp+z5K37Ze4w8Mz/cn4WGdCsA2FABX2AhzVYMnu56e chfgjCIe+9mwijy3fIlRS3YXkCp2iI5yZvxY1iR5PKK5GNQE3hT7E1xkFHwHjPOH3eAg YjEw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=h1rfJIBBFnprCdVCpR0INLDvNmJPx2aLLEvFKY8jTJE=; b=VD3mX15wGfZxC13H6oYuL8+TF51bkaVlguAOzUgjTFsZhDAxwMLZRPHRRI1Dr8MOea xQy6aKCo4uibZA4Sxjv3uK4cqZ8EKg+c52/EhCEJh8xZRXrNfP1wuXQdLnpFNwtZYK+V i2Uncf9OVNlRCEvRHFkothw9+mB1/O3WRv9znzeCOSJv07clrhJdH6NoAKKVpT9xufc2 q1aJSGar8UKb/IRXz60s2TItb52gOEZiYIhPvsZvEgA6VKeNXN1tfYnljqHM9+rnSMqZ qtepllUUX8QqVQItzqGXDyGKnYaYavVfLx+iWJDSQVGy1FsJY+uzMyxIc2B0mstitV96 DWPA== X-Gm-Message-State: AOAM530Mhf4WuAbp4BYQxiorIkN00b2sty5EXNKx6nYi0AO81q54J4w+ WDp30NgjvvXaF6MAG8CTx1wlkdmNcgXbUo1eoTg6oVcsXD0= X-Google-Smtp-Source: ABdhPJywXmhMut5uihLG/PbeiAqPlHQrdYA2WQezCgyVMJV8epGqlufoIPjPgBL0sM3PmJ/AqinsoQPPygQUlwhb47w= X-Received: by 2002:a5d:474f:: with SMTP id o15mr29400047wrs.100.1606117767430; Sun, 22 Nov 2020 23:49:27 -0800 (PST) MIME-Version: 1.0 References: <20e670fa-074d-40c8-8bfd-b148fd0e3e77@www.fastmail.com> <20201123043359.GC31253@tarpaulin.shahaf.local2> In-Reply-To: <20201123043359.GC31253@tarpaulin.shahaf.local2> From: Felipe Contreras Date: Mon, 23 Nov 2020 01:49:16 -0600 Message-ID: Subject: Re: git-completion 1.2 released To: Daniel Shahaf Cc: Zsh Users Content-Type: text/plain; charset="UTF-8" X-Seq: 26197 Archived-At: X-Loop: zsh-users@zsh.org Errors-To: zsh-users-owner@zsh.org Precedence: list Precedence: bulk Sender: zsh-users-request@zsh.org X-no-archive: yes List-Id: List-Help: List-Subscribe: List-Unsubscribe: List-Post: List-Owner: List-Archive: Archived-At: On Sun, Nov 22, 2020 at 10:34 PM Daniel Shahaf wrote: > Felipe Contreras wrote on Sat, Nov 21, 2020 at 18:53:56 -0600: > > But the main use of "git send-email" is not to receive random files, > > it's to receive comittishes, and potentially some .patch files. > > So, just this? Will anyone want to complete files that _don't_ have > a .patch extension? Usually "git send-email" receives the patches generated by "git format-patch", so yeah, *.patch should be enough. But it probably wouldn't hurt to add *.diff files too, just in case. > > If I do "git send-email master.." nothing completes with Zsh's > > official completion. It does with mine. > > Thanks for the bug report. You're welcome. But that's just an example. Another example is that "git -C ~/dev/git show " doesn't work, and the _git function has a TODO about -c since 2011. And there's a lot of others. I did some hacks to run Zsh's official Git completion against Git's testing framework, and at least half of them fail. I could tell you how to do that if you are interested. So in my view it's clear the priorities of the two completions are very different. Cheers. -- Felipe Contreras