zsh-users
 help / color / mirror / code / Atom feed
From: dana <dana@dana.is>
To: Takeshi Banse <thb@laafc.net>
Cc: zsh-users@zsh.org
Subject: Re: change in zstyle file-patterns handling between 5.5.1 & 5.6(.2)?
Date: Mon, 17 Sep 2018 00:58:34 -0500	[thread overview]
Message-ID: <E1E7B0A5-508E-41DA-93F1-66B27DB44543@dana.is> (raw)
In-Reply-To: <20180917022715.GA17398@laafc.net>

On 16 Sep 2018, at 21:27, Takeshi Banse <thb@laafc.net> wrote:
>If I revert the commit 6b4e78dce6a505d8dab5554d9925e38e13bb40ea like
>a workaround diff hunk at the end of this mail, it works here for these
>2 particular issues.

I guess this one is mine, sorry. :/

Going back over it, i'm having trouble remembering exactly why i changed _files;
as far as i know, it's not necessary to fix the _object_files problem i found.
Maybe during troubleshooting i noticed that the one _path_files call was
different from the other two in that function, and i decided it was a mistake?
Sounds like the kind of dumb thing i'd do.

Unless someone else can figure out what past-me was going for, i'm in favour of
reverting that half of the change per your patch.

dana


  reply	other threads:[~2018-09-17  5:58 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-09-16 11:50 ml.zsh-workers.454
2018-09-17  2:27 ` Takeshi Banse
2018-09-17  5:58   ` dana [this message]
2018-09-17 13:01     ` Daniel Shahaf
2018-09-17 21:09       ` dana
2018-09-25  0:13   ` dana

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=E1E7B0A5-508E-41DA-93F1-66B27DB44543@dana.is \
    --to=dana@dana.is \
    --cc=thb@laafc.net \
    --cc=zsh-users@zsh.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).