From: Andrej Borsenkow <Andrej.Borsenkow@mow.siemens.ru>
To: Paul Ackersviller <paulda@alumni.uwo.ca>
Cc: <zsh-users@sunsite.dk>
Subject: PATCH: Re: inet_{a,p}ton prototypes in Src/Modules/zftp.pro
Date: Wed, 9 May 2001 23:55:15 +0400 (MSD) [thread overview]
Message-ID: <Pine.SV4.4.33.0105092346260.28289-100000@itsrm2.mow.siemens.ru> (raw)
In-Reply-To: <20010506104546.A13094@flora01.SLAC.Stanford.EDU>
On Sun, 6 May 2001, Paul Ackersviller wrote:
> I just tried building zsh on Solaris 7 from the latest source off of CVS.
> Sun's compiler doesn't like inet_aton and inet_pton being declared as static.
> Here are the errors:
>
> "./zftp.pro", line 4: identifier redeclared: inet_aton
> current : static function(pointer to const char, pointer to struct in_addr {union {..} S_un}) returning int
> previous: function(pointer to const char, pointer to struct in_addr {union {..} S_un}) returning int : "/usr/include/arpa/inet.h", line 52
> "./zftp.pro", line 6: identifier redeclared: inet_pton
> current : static function(int, pointer to const char, pointer to void) returning int
> previous: function(int, pointer to const char, pointer to void) returning int : "/usr/include/arpa/inet.h", line 54
>
O.K. here is patch for zftp.c. After reviewing old thread I decided to not
mess up with configure and took Zefram's advice - internally use zsh_*
functions that are either #defined or declared. It works on my system that
lacks everything except gethostbyname() and on Mandrake 8 with glibc-2.2
that has everything except getipnodebyname() (I believe, it even has IPv6
but not checked) so it should work on most systems.
Note, that blanks *are* significant here (there were spaces after /**/ in
some places).
The patch is against current CVS; I'll commit if nobody complaints that it
broke something again.
-andrej
next prev parent reply other threads:[~2001-05-09 19:55 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-05-06 17:45 Paul Ackersviller
2001-05-07 0:03 ` Bart Schaefer
2001-05-07 1:27 ` nce
2001-05-07 14:56 ` Bart Schaefer
2001-05-07 19:12 ` Kenneth Lareau
2001-05-08 4:12 ` nce
2001-05-08 12:53 ` Andrej Borsenkow
2001-05-09 1:42 ` nce
2001-05-08 14:37 ` Andrej Borsenkow
2001-05-09 19:55 ` Andrej Borsenkow [this message]
2001-05-09 20:01 ` PATCH: " Andrej Borsenkow
2001-05-10 3:21 ` nce
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.SV4.4.33.0105092346260.28289-100000@itsrm2.mow.siemens.ru \
--to=andrej.borsenkow@mow.siemens.ru \
--cc=paulda@alumni.uwo.ca \
--cc=zsh-users@sunsite.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).