From: Dominik Vogt <dominik.vogt@gmx.de>
To: Zsh Users <zsh-users@zsh.org>
Subject: Re: time command with shell builtins
Date: Thu, 2 Feb 2023 20:15:00 +0100 [thread overview]
Message-ID: <Y9wLtMHvkyg3HU7K@localhost> (raw)
In-Reply-To: <CAH+w=7avOPPgi-bJJBR-XjvUfapTcfDOhPJkMxFDHEOHPb63gw@mail.gmail.com>
On Thu, Feb 02, 2023 at 10:28:36AM -0800, Bart Schaefer wrote:
> On Thu, Feb 2, 2023 at 10:10 AM Dominik Vogt <dominik.vogt@gmx.de> wrote:
> >
> > Well, is there a way to detect inside preexec() wether a command
> > is handled by the shell or some external binary?
>
> If you actually have the command name, you can use
> if (( $+commands[$thename] ))
>
> That won't work (or will be complicated) if the buffer that's about to
> be executed is a complex structure (braces, subshell parens,
> while/for/repeat/if/case/select/etc.).
Okay, that sounds good enough. The new solution works without a
blacklist. It may still print statistics with REPORTTIME and on
the prompt in some cases (e.g. "{ /usr/bin/foobar" }" etc.). But
I can live with that. Note that it now uses two slots in the
psvar array. In some scenarios with ctrl-c using psvar[2] for the
raw time and the string to print resulted in error messages
because the variable's value was just ' s'.
-- snip --
autoload -Uz add-zsh-hook
zmodload zsh/datetime
function preexec_recordtime() {
local CL=( $3 )
psvar[3]=''
if (( $+commands[${CL[1]}] )); then
psvar[2]=''
elif [[ -n $REPORTTIME ]]; then
psvar[2]="$EPOCHSECONDS"
else
psvar[2]=''
fi
}
precmd_reporttime () {
if [[ -n "$REPORTTIME" && -n "$psvar[2]" ]]; then
psvar[2]=$(( $EPOCHSECONDS - $psvar[2] ))
if (( $psvar[2] <= $REPORTTIME )); then
psvar[3]=''
else
psvar[3]=" $psvar[2]s"
fi
fi
}
add-zsh-hook preexec preexec_recordtime
add-zsh-hook precmd precmd_reporttime
PS1="...%3v..."
-- snip --
Ciao
Dominik ^_^ ^_^
--
Dominik Vogt
next prev parent reply other threads:[~2023-02-02 19:15 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-23 13:40 Dominik Vogt
2023-01-23 13:42 ` Roman Perepelitsa
2023-01-23 14:17 ` zeurkous
2023-01-23 14:23 ` Roman Perepelitsa
2023-01-23 14:40 ` zeurkous
2023-01-23 14:28 ` Dominik Vogt
2023-01-23 14:46 ` zeurkous
2023-01-23 16:31 ` Bart Schaefer
2023-01-23 18:31 ` Mikael Magnusson
2023-01-23 18:49 ` Dominik Vogt
2023-01-24 9:32 ` Mikael Magnusson
2023-01-24 10:48 ` Dominik Vogt
2023-01-24 23:12 ` Dominik Vogt
2023-01-24 23:36 ` Bart Schaefer
[not found] ` <Y9B7A8dWLiZNXKfW@localhost>
2023-01-26 16:23 ` Dominik Vogt
2023-01-26 16:56 ` Bart Schaefer
2023-01-26 17:26 ` Dominik Vogt
2023-01-26 17:40 ` Bart Schaefer
2023-02-02 18:10 ` Dominik Vogt
2023-02-02 18:28 ` Bart Schaefer
2023-02-02 19:15 ` Dominik Vogt [this message]
2023-02-02 19:15 ` Dominik Vogt
2023-02-02 19:31 ` Bart Schaefer
2023-01-24 23:32 ` Bart Schaefer
2023-01-25 7:43 ` Mikael Magnusson
2023-01-25 12:58 ` Dominik Vogt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y9wLtMHvkyg3HU7K@localhost \
--to=dominik.vogt@gmx.de \
--cc=zsh-users@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).