From: "Benjamin R. Haskell" <zsh@benizi.com>
To: Piotr Kalinowski <pitkali@gmail.com>
Cc: zsh-users@zsh.org
Subject: Re: Git completion - trying to improve speed
Date: Tue, 29 Jun 2010 12:29:29 -0400 (EDT) [thread overview]
Message-ID: <alpine.LNX.2.01.1006291212440.5029@hp.internal> (raw)
In-Reply-To: <AANLkTikWWvlUxxBfS5z5Ko_HHN00yd-dB91bbwkUAzr7@mail.gmail.com>
On Tue, 29 Jun 2010, Piotr Kalinowski wrote:
> Hi,
>
> I'm working on quite a large repository, and found git checkout
> completion to be veeery slow. I've found patch on google that does
> improve situation dramatically when you supply some prefix, see:
> http://www.zsh.org/mla/workers/2008/msg01535.html. I've applied it to
> git-version of git completion. However, I've got weird side effect.
>
> Let user use 'git checkout test-<TAB>', wanting to complete something
> like local branch test-feature1 or test-feature2. However:
>
> - First completion is immediately inserted with menu displayed despite
> the shell being configured otherwise (inserted in full, not just
> common prefix).
>
> - The first completion is something like origin/test-feature1 instead
> of a local branch.
>
> I'm not much of a shell guru so I thought I'd ask if someone more into
> the subject had any ideas what's going on, before I start to
> reverse-engineer _git script ;)
>
Not entirely sure about your problem.
That message is spot-on about the source of the problem, though.
_multi_parts is really slow. Since I have a mapping for completing
filenames generally via ^X^F, I've actually been satisfied with adding
the following to my startup files:
__git_files(){}
That prevents most(?) filename completion via _git, but I much prefer
that to the alternative of pegging a CPU at 100% for more than a minute
whenever I accidentally hit <Tab> after 'git co' (w/ 'co' aliased to
'checkout') in my work repo (which is much smaller than the kernel repo,
but many untracked files).
I have a branch in my local zsh repo called completion/_git/why-so-slow,
but it's been sitting dormant for a while for lack of tuits (along with
completion/_virtualbox and completion/_imagemagick).
--
Best,
Ben
prev parent reply other threads:[~2010-06-29 16:30 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-29 9:50 Piotr Kalinowski
2010-06-29 16:29 ` Benjamin R. Haskell [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LNX.2.01.1006291212440.5029@hp.internal \
--to=zsh@benizi.com \
--cc=pitkali@gmail.com \
--cc=zsh-users@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).