From: Piotr Karbowski <piotr.karbowski@protonmail.ch>
To: Bart Schaefer <schaefer@brasslantern.com>
Cc: zsh-users@zsh.org
Subject: Re: The HIST_EXPIRE_DUPS_FIRST might corrupt and wipe partially history file if many shells exit at the same time
Date: Sun, 19 Mar 2023 18:38:02 +0000 [thread overview]
Message-ID: <b821265f-c8e4-90e2-4f78-4a6cc98ae8b1@protonmail.ch> (raw)
In-Reply-To: <CAH+w=7Y6BDXBf1mtOMaceTfs7ioL7z+-EycAF8ppWFv-6_arNg@mail.gmail.com>
Hi,
On 19/03/2023 17.53, Bart Schaefer wrote:
> On Sun, Mar 19, 2023 at 4:56 AM Piotr Karbowski
> <piotr.karbowski@protonmail.ch> wrote:
>>
>> They way I can reproduce it sometimes is if multiple zsh shells exit at
>> the very same time. It happens when I terminate tmux session that have
>> 10+ zsh instances,or when I just reboot my system while I have dozens of
>> urxvt instances open.
>>
>> +SAVEHIST='96000'
>> +setopt hist_expire_dups_first
>>
>> I have disabled this feature since due those corruptions. Would love to
>> get back to it though, perhaps adding some locking mechanism would help
>> here?
>
> There is a locking mechanism. A couple of things may be happening:
>
> 1) Your home directory (or ZDOTDIR) is on a remote filesystem with
> asynchronous mounting, so the locking mechanism doesn't always work.
> You haven't described your system configuration in any detail, but
> from what you have said this one seems unlikely.
> 2) The locking mechanism doesn't work for some other reason. Make
> sure the HIST_SAVE_BY_COPY option is set (it's the default but check
> anyway).
> 3) When exiting a session (or particularly when rebooting), there may
> be a limited amount of time for the processes to clean up and exit
> before they are killed. With the combination of options you have,
> each shell must re-read the history file to merge it with its local
> history before writing it back. With multiple shells and tens of
> thousands of lines of history, this might take longer than all the
> shells are allowed to stay alive.
>
> Try putting something in your .zlogout file that writes a timestamp to
> a file (different for each shell, e.g., use $$ in the filename).
> Since .zlogout runs after history is saved, if you find any of those
> files to be missing, that's a clue that #3 is happening. You could
> also look to see if a ".zsh_history.new" file is left behind.
Thanks for the response and applogies for missing details.
I am runnin XFS (on the top of lvm, on the top of dmcrypt).
The current setopt is (without the expire dups first)
autopushd
extendedglob
noflowcontrol
histignoredups
histignorespace
interactive
interactivecomments
promptsubst
pushdignoredups
pushdminus
shinstdin
The HIST_SAVE_BY_COPY does not seems to be enabled and I am unable to
enable it. Running
setopt HIST_SAVE_BY_COPY
Does not bring this option into list I can see with running setopt. This
is zsh-5.9. Running unsetopt without params does show nohistsavebycopy
there, however running
setopt histsavebycopy
Does nothing, it still remains as nohistsavebycopy in unsetopt output.
The question then is -- why this feature remains disabled and cannot be
toggled on? Even running zsh -dfi to get a shell without zshrc behave
the same way, this feature remains disabled and cannot be toggled on.
-- Piotr.
next prev parent reply other threads:[~2023-03-19 18:39 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-19 11:56 Piotr Karbowski
2023-03-19 16:53 ` Bart Schaefer
2023-03-19 18:38 ` Piotr Karbowski [this message]
2023-03-19 21:01 ` Bart Schaefer
2023-03-19 21:17 ` Piotr Karbowski
2023-03-19 21:34 ` Bart Schaefer
2023-03-19 21:53 ` Piotr Karbowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b821265f-c8e4-90e2-4f78-4a6cc98ae8b1@protonmail.ch \
--to=piotr.karbowski@protonmail.ch \
--cc=schaefer@brasslantern.com \
--cc=zsh-users@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).