From: "Daniel Shahaf" <d.s@daniel.shahaf.name>
To: zsh-users@zsh.org
Subject: Re: How to impose a numeric sort on negative numbers?
Date: Fri, 03 Jul 2020 22:23:35 +0000 [thread overview]
Message-ID: <d3a75b03-31e8-4640-9725-0b9e26d053e9@www.fastmail.com> (raw)
In-Reply-To: <3f4d22d506fc069965c1e37d0f06ee585a5073dc.camel@ntlworld.com>
Peter Stephenson wrote on Fri, 03 Jul 2020 20:08 +00:00:
> On Thu, 2020-07-02 at 08:46 -0700, Bart Schaefer wrote:
> > Peter Stephenson wrote on Wed, 01 Jul 2020 20:42 +0100:
> > > > +++ b/Doc/Zsh/expn.yo
> > > > @@ -1097,6 +1097,11 @@ are sorted before those with fewer or none. Hence the array `tt(foo1 foo02
> > > > foo2 foo3 foo20 foo23)' is sorted into the order shown.
> > > > May be combined with `tt(i)' or `tt(O)'.
> > > > )
> > > > +item(tt(DASH()))(
> > > > +As tt(n), but a leading minus sign indicates a negative decimal
> > > > +integer. A solo `tt(DASH())' not followed by an integer does
> > > > +not trigger numeric sorting.
> > > > +)
> >
> > It might be possible to change this. For numeric sort, the function
> > eltpcmp() in sort.c ignores everything other than digits that compares
> > the same in any pair of the strings. It could recognize a leading
> > hyphen as special.
>
> (I've committed it with DASH() turned into -.)
>
(Turns out there were five instances of tt(DASH()), not two as I implied
in my review, so I've gone ahead and changed those as well.)
> The doc was just to record the fact that I didn't treat a "-" as "-0",
> just as a character "-". That was a deliberate choice --- I'm
> assuming the usual case of a numeric sort will have at least one
> decimal digit in the part to be sorted and anything else is
> just a hyphen (and definitely not a dash).
FWIW, I thought at first reading that that second sentence referred to
the `tt(-)' in the parameter expansion flags, not to the one in the
input data. I'd never have expected "-" or "-foo" to be considered an
integer in the first place, just like "" and "foo" aren't considered integers.
Incidentally, should "+42" be sorted as an integer? Right now it isn't.
Cheers,
Daniel
next prev parent reply other threads:[~2020-07-03 22:24 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-01 17:45 Sebastian Gniazdowski
2020-07-01 18:02 ` Mikael Magnusson
2020-07-01 18:07 ` Sebastian Gniazdowski
2020-07-01 18:12 ` Roman Perepelitsa
2020-07-03 18:12 ` Lewis Butler
2020-07-03 18:35 ` Bart Schaefer
2020-07-01 19:42 ` Peter Stephenson
2020-07-02 11:36 ` Daniel Shahaf
2020-07-02 12:00 ` Peter Stephenson
2020-07-03 16:21 ` Hyphens, minuses, and dashes (was: Re: How to impose a numeric sort on negative numbers?) Daniel Shahaf
2020-07-02 15:46 ` How to impose a numeric sort on negative numbers? Bart Schaefer
2020-07-03 20:08 ` Peter Stephenson
2020-07-03 20:15 ` Bart Schaefer
2020-07-03 22:23 ` Daniel Shahaf [this message]
2020-07-07 16:14 ` Daniel Shahaf
2020-07-07 16:18 ` Daniel Shahaf
2020-07-01 18:48 ` Lawrence Velázquez
2020-07-06 7:15 ` Sebastian Gniazdowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d3a75b03-31e8-4640-9725-0b9e26d053e9@www.fastmail.com \
--to=d.s@daniel.shahaf.name \
--cc=zsh-users@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).