From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=5.0 tests=MAILING_LIST_MULTI, RCVD_IN_DNSWL_NONE autolearn=ham autolearn_force=no version=3.4.2 Received: from primenet.com.au (ns1.primenet.com.au [203.24.36.2]) by inbox.vuxu.org (OpenSMTPD) with ESMTP id c0e9ae35 for ; Tue, 31 Dec 2019 18:36:46 +0000 (UTC) Received: (qmail 21933 invoked by alias); 31 Dec 2019 18:36:38 -0000 Mailing-List: contact zsh-users-help@zsh.org; run by ezmlm Precedence: bulk X-No-Archive: yes List-Id: Zsh Users List List-Post: List-Help: List-Unsubscribe: X-Seq: 24587 Received: (qmail 1867 invoked by uid 1010); 31 Dec 2019 18:36:38 -0000 X-Qmail-Scanner-Diagnostics: from know-smtprelay-omc-8.server.virginmedia.net by f.primenet.com.au (envelope-from , uid 7791) with qmail-scanner-2.11 (clamdscan: 0.102.1/25677. spamassassin: 3.4.2. Clear:RC:0(80.0.253.72):SA:0(-2.0/5.0):. Processed in 1.847128 secs); 31 Dec 2019 18:36:38 -0000 X-Envelope-From: p.w.stephenson@ntlworld.com X-Qmail-Scanner-Mime-Attachments: | X-Qmail-Scanner-Zip-Files: | Received-SPF: pass (ns1.primenet.com.au: SPF record at _smtprelay.virginmedia.com designates 80.0.253.72 as permitted sender) X-Originating-IP: [86.16.88.158] X-Authenticated-User: p.w.stephenson@ntlworld.com X-Spam: 0 X-Authority: v=2.3 cv=X6h81lbe c=1 sm=1 tr=0 a=MiHCjVqLJ44lE3bxSlffFQ==:117 a=MiHCjVqLJ44lE3bxSlffFQ==:17 a=jpOVt7BSZ2e4Z31A5e1TngXxSK0=:19 a=IkcTkHD0fZMA:10 a=XhHNbgcs5tUnYk8FzM4A:9 a=QEXdDO2ut3YA:10 Message-ID: Subject: Re: ${(z)} parsing of multiple array assignments From: Peter Stephenson To: zsh-users@zsh.org Date: Tue, 31 Dec 2019 18:35:57 +0000 In-Reply-To: <3cde5f41-f9a4-487e-a5ea-4400947a5517@www.fastmail.com> References: <20191223173115.bvhwbpfmqgqhngle@tarpaulin.shahaf.local2> <7b7a941ddc3c20bea6a6b69b1e7ac35d827f320d.camel@ntlworld.com> <373ee4b006198f68c835c902c0bc35242796b33d.camel@ntlworld.com> <20191230181339.hg7ryxivv75ae73r@tarpaulin.shahaf.local2> <20191230182135.abx2lfvbtgsraalh@tarpaulin.shahaf.local2> <8b619ac6e86c3f997781a98d3550304c91f93acc.camel@ntlworld.com> <3cde5f41-f9a4-487e-a5ea-4400947a5517@www.fastmail.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.28.5-0ubuntu0.18.04.1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-CMAE-Envelope: MS4wfGavRM0CsidSUwfMrVF3WkfOWSgoMFUEEHaTOdTneOhgv48aDCGcFjsTuh0fqYxhbHJ+6mtPI7BJ5V5l5O4VueHnHgkWTa4yTFZmVpBfGz4reG/e2jAZ cbp/bwwqXX/eijhySEHS1haKvo0pbgpwMvcz2dk8L/2Q9LSKHHE+mFDa On Mon, 2019-12-30 at 23:46 +0000, Daniel Shahaf wrote: > Peter Stephenson wrote on Mon, 30 Dec 2019 22:37 +00:00: > > On Mon, 2019-12-30 at 18:21 +0000, Daniel Shahaf wrote: > > > Daniel Shahaf wrote on Mon, Dec 30, 2019 at 18:13:39 +0000: > > > > Here's a test. > > > > > > One more: > > > > Thanks; shall I commit my change? It looks like it ought to be local > > enough we can be reasonably confident it's well tested. > > The changes do seem fairly local, and not likely to break anything that > _doesn't_ use array assignments interactively (get_comp_string()) or in > ${(z)} (bufferwords()), so small risk. I don't have a gut feeling for how likely > they are to break anything, but if you feel they're not going to necessitate > a 5.8.1, then sure, go ahead and commit to master. > > If you aren't sure, then go ahead and commit to the 5.9 branch. :) I don't see any problem myself, but it was best to check. I've committed it. pws