From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, FREEMAIL_FROM,MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE autolearn=ham autolearn_force=no version=3.4.2 Received: from primenet.com.au (ns1.primenet.com.au [203.24.36.2]) by inbox.vuxu.org (OpenSMTPD) with ESMTP id 42e3f8ce for ; Mon, 29 Jul 2019 18:45:19 +0000 (UTC) Received: (qmail 21281 invoked by alias); 29 Jul 2019 18:45:08 -0000 Mailing-List: contact zsh-users-help@zsh.org; run by ezmlm Precedence: bulk X-No-Archive: yes List-Id: Zsh Users List List-Post: List-Help: List-Unsubscribe: X-Seq: 24102 Received: (qmail 517 invoked by uid 1010); 29 Jul 2019 18:45:08 -0000 X-Qmail-Scanner-Diagnostics: from mout.gmx.net by f.primenet.com.au (envelope-from , uid 7791) with qmail-scanner-2.11 (clamdscan: 0.101.2/25524. spamassassin: 3.4.2. Clear:RC:0(212.227.17.21):SA:0(-2.6/5.0):. Processed in 3.154968 secs); 29 Jul 2019 18:45:08 -0000 X-Envelope-From: llua@gmx.com X-Qmail-Scanner-Mime-Attachments: | X-Qmail-Scanner-Zip-Files: | Received-SPF: pass (ns1.primenet.com.au: SPF record at gmx.com designates 212.227.17.21 as permitted sender) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1564425867; bh=TYHwbk6CLaSsQ1lAG1/GgmkACFLVf0nKIhpTqW+a1Zg=; h=X-UI-Sender-Class:Subject:To:References:From:Date:In-Reply-To; b=HUJNxS9mDFwZ/4jrU/hy9qMwT4xcfKAhrzItxl7eQNJKVKyAVSytIfwALwpGf8ydd O0Uri+MgcCpivPTxccZDYiiceof5zf+jmurq7qPVEuawIu6ZPN9STXtiU8IygXRXWQ YjehjUFTj+d6oyGE+VeSEdDqGkXA9xaWOEXmkjI8= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Subject: Re: issue with usermod command completion To: zsh-users@zsh.org References: From: Eric Cook Message-ID: Date: Mon, 29 Jul 2019 14:44:24 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:dWfobXOqGuXzPWHiiYUbX6vyt6IqRoyEZH3DyPU6ODEINF5/Lex 21phN4Er8iIoXxF6un5kUdJxOdfNjkjo7H8y9OCZ1OyAOvP7IOZrZyzU2olLHkD9dj9Ub/d haIOwToTl8Pno+S/86EN/iUtRIPaYp6mwEizHgrtEHwXxr9gn3EsbMmmAYXgolN7uHZ+KVk dE/v7TlUs0hLzr9ria1SA== X-UI-Out-Filterresults: notjunk:1;V03:K0:GgdzKPnf/O0=:P4xMWJJF1ZgB4L5YAdykNS ZfjoqcG7ZYK7cRo0GgaQcdhZ2XIFei/DGZAk9Y3flmZa4Tx2T2ZezBq83wmvsbK2iVTC9stUj bUIGzqzd1pPB2rqLb/ItmOMnPHCYxk28clt/g0IFUvx1qlPVaISv98qqGNVDHMCmlZrMaXzqo iXHLfRcPGkOSpG/g3s9D0VfyHaycYS6zo2Rgz9LjIRhz4C2pJF1PWAuHWOPFYJtfCXvia7JQi Z5/ghrOjZHwatzLZ8mxrJlXUzjzNiggtaebrntR0/3TI+sOlEsHU5+7n76qBMuOY4KtyFGpAF 3V5yBEBIxyV2Ioc1Y3jiTRtnrS8ljKlsdaNbXhlSq8ZdXzJGaARsfVyxsTwN8btdLimavNnoW NUZZEiyyimm8ywC/B4BylqT6w6/QXCa32Bt9wruACjmB4PnXGmSlAXJ4n0/Wpk/RbHQ99OBue ndgmacsOxMJRYu3FhxL4T3cVqGZ76C2dFRQT0ulfzCS8hy11zlkk9o1onssgX8i6vtJUR2Pyb yQs6USneGjS2ss8VwCpVl/JGTJgVGObuwWQ+THFwbMCb1//Jotdc5M7ahZfwqoWv5C07nfPcQ DKWHBnCP60MIiBmSp4vlEgRkw83AmQzgbrHL9qy/hf1J9aDCSl0nh3j0Q2zXE7P7+1YL/cWAQ f0W5m9FGNSqiGhQTXIy2TCi/Q3KiZcHjYyq8mQWr66GLlMnwsJmzo+U2LLhZOn+ZLO+MSmY9v f+yNQpG9G/ISMVJdAU+NFW/U4aUPVWllWWc6dMCYVdjLnrRsPBPpk4T6PrAIZuHU/2iUtrCrl 2/nHIc8oTb3ZmSRcKq6wO13b439SkLyKOEPg22wU7Mwde/RthlTUVGiA4/O4qiGbgI4F3OMVY uctGpJFOOpPfKpIbjGcZcn/EFVgLpbpxul0gW7ikhxVV92TiO1q0XPJarjRN1FdT/AHBVxuS3 Ztu7hcvChtVEuz/SR0xTqT/g5RgwQ/FJ/bRjWs0bPgAfHXkE91k+1lj7mcG6BExbmUVRuPSeT uE2JCYO8HUKz08ZY1TOQ0wnRw7HEhf0oh+DqPOwVoZlg74hagxuVUOSyuEMTiEvnvA/hfSnfi fkzq4pD1vhhmwY= On 7/23/19 11:04 PM, hottea wrote: > Hi, > usermode [TAB] gives me: > usermod --add-sub- > --add-sub-gids -- add a range of subordinate gids > --add-sub-uids -- add a range of subordinate uids > > However, there's no --add-sub-gids or --add-sub-uids options. I think > they're typo of --add-subgids and --add-subuids. > > After checking the source, a modification might be needed in these > lines: https://github.com/zsh-users/zsh/blob/master/Completion/Unix/Comm= and/_user_admin#L106-L109 > seemed to have been based off of a man page at the time: http://manpages.u= buntu.com/manpages/xenial/man8/usermod.8.html curious though, looking at the source code of the package for the same rel= ease, the option seemed to have always been --{add,del}-sub{g,u}ids. so a typo in the documentation causing us to incorrectly add it that way. = regardless diff --git a/Completion/Unix/Command/_user_admin b/Completion/Unix/Command= /_user_admin index fe28c13f5..c7e1efc80 100644 =2D-- a/Completion/Unix/Command/_user_admin +++ b/Completion/Unix/Command/_user_admin @@ -103,10 +103,10 @@ case ${service%???}:${(M)service%???}:$OSTYPE in user:mod:linux*) args+=3D( '(-a --append)'{-a,--append}'[add user to supplementary groups with= out removing from other groups]' - \*{-v,--add-sub-uids}'[add a range of subordinate uids]:uids (first= -last)' - \*{-V,--del-sub-uids}'[remove a range of subordinate uids]:uids (fi= rst-last)' - \*{-w,--add-sub-gids}'[add a range of subordinate gids]:gids (first= -last)' - \*{-W,--del-sub-gids}'[remove a range of subordinate gids]:gids (fi= rst-last)' + \*{-v,--add-subuids}'[add a range of subordinate uids]:uids (first-= last)' + \*{-V,--del-subuids}'[remove a range of subordinate uids]:uids (fir= st-last)' + \*{-w,--add-subgids}'[add a range of subordinate gids]:gids (first-= last)' + \*{-W,--del-subgids}'[remove a range of subordinate gids]:gids (fir= st-last)' ) ;| user:mod:*)