zsh-users
 help / color / mirror / code / Atom feed
From: Yuri D'Elia <wavexx@users.sourceforge.net>
To: zsh-users@zsh.org
Subject: Re: precmd: write error: interrupted
Date: Thu, 25 Apr 2013 22:05:41 +0200	[thread overview]
Message-ID: <klc2ah$jiv$1@ger.gmane.org> (raw)
In-Reply-To: <130425111646.ZM17258@torch.brasslantern.com>

On 04/25/2013 08:16 PM, Bart Schaefer wrote:
> } 1) SIGWINCH should either be masked or allow write to restart.
>
> This requires some thought about the appropriate layer to handle this.
> bin_print does already do some signal queuing when writing to internal
> data structures (print -z, print -s), but that's deliberately isolated
> to bin_print, whereas all sorts of other things might write to the
> terminal -- including other error messages! -- so patching bin_print is
> not covering all the bases.

I actually tried to set SA_RESTART only when installing the handler for 
SIGWINCH when debugging [1]. It works in this case, but I'm not entirely 
sure it is side-effect free (is doing an ioctl on the tty safe while 
mid-write?).

What other syscalls would be interrupted by SIGWINCH that shouldn't be 
restarted? Right now I cannot think of anything that SIGWINCH should 
interrupt.

You can actually reproduce the bug easily by doing:

while print 'x'; do; done

and resizing the terminal, or by sending SIGWINCH to zsh directly.

[1] interestingly enough, why "interact" is tested for the Sunos4 case?


  parent reply	other threads:[~2013-04-25 20:05 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-04-25 16:47 Yuri D'Elia
2013-04-25 17:44 ` Yuri D'Elia
2013-04-25 18:27   ` Bart Schaefer
2013-04-25 18:16 ` Bart Schaefer
2013-04-25 18:38   ` Peter Stephenson
2013-04-25 22:18     ` Bart Schaefer
2013-04-26  0:52       ` Bart Schaefer
2013-04-25 19:38   ` Yuri D'Elia
2013-04-26  0:53     ` Bart Schaefer
2013-04-25 20:05   ` Yuri D'Elia [this message]
2013-04-25 20:58     ` Yuri D'Elia
2013-04-26 15:08     ` Bart Schaefer
     [not found]     ` <130426080805.ZM18619__18102.73175729$1366989065$gmane$org@torch.brasslantern.com>
2013-04-26 17:59       ` Yuri D'Elia

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='klc2ah$jiv$1@ger.gmane.org' \
    --to=wavexx@users.sourceforge.net \
    --cc=zsh-users@zsh.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).