zsh-users
 help / color / mirror / code / Atom feed
From: Langbart <Langbart@protonmail.com>
To: "zsh-users@zsh.org" <zsh-users@zsh.org>
Subject: Foreign Commands Not Appearing in 'history' Array When 'sharehistory' Option is Enabled Until a Command is Entered
Date: Mon, 28 Oct 2024 15:06:03 +0000	[thread overview]
Message-ID: <mwXIqemfp6p2u5-5ApP-6mjA8aw0SthwcBYnYnkHh13e_46s4ThESPJANCAKlEr2n9VBhClb1JwW_5IiYgljeAv9hJzfculpb9J6QF_lqQY=@protonmail.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 1659 bytes --]

Guten Tag,

is it a bug that when the 'sharehistory' option is enabled, commands from other shells ('foreign') aren't included in the 'history' array until the user enters a command?

Consider the following widget and settings in my '.zshrc':

```sh
test-history() {
BUFFER=""

print
print -- "=== HISTORY TEST ==="
print -- "history array:"
zmodload -F zsh/parameter p:history || return 1
printf "%s\t%s\n" "${(kv)history[@]}" | head -5

print -- "--------------------"

print -- "fc command:"
print -r -- "$(fc -rl -5)"

zle accept-line
}

zle -N test-history
bindkey '^R' test-history

setopt SHARE_HISTORY
```

I open two terminals, type 'echo Test 1' in Terminal 1, switch to Terminal 2, and press 'Enter' without entering a command. Pressing 'Ctrl-R' shows that the 'history' array doesn't include the 'echo Test 1' entry.

```txt
=== HISTORY TEST ===
history array:

--------------------
fc command:
1* echo Test 1
```

After entering 'echo Test 2' in Terminal 2 and pressing 'Ctrl-R' again in Terminal 2, the output is:

```txt
=== HISTORY TEST ===
history array:
2 echo Test 2
1 echo Test 1
--------------------
fc command:
2 echo Test 2
1* echo Test 1
```

Prepending 'fc -RI' before accessing the 'history' array seems to resolve the issue. Is this the recommended workaround to ensure that the 'history' array lists its resuls like 'fc -rl ...' does ?

```sh
...
[[ "${options[sharehistory]}" == "on" ]] && fc -RI

zmodload -F zsh/parameter p:history || return 1
printf "%s\t%s\n" "${(kv)history[@]}" | head -5

...
```

Related:

- [https://github.com/junegunn/fzf/issues/4061](https://github.com/junegunn/fzf/issues/4061#issuecomment-2436756709)

[-- Attachment #2: Type: text/html, Size: 4986 bytes --]

             reply	other threads:[~2024-10-28 15:07 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-28 15:06 Langbart [this message]
2024-10-28 16:42 ` Bart Schaefer
2024-10-28 17:35   ` Roman Perepelitsa
2024-10-28 18:14     ` Bart Schaefer
2024-10-28 18:22       ` Roman Perepelitsa

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='mwXIqemfp6p2u5-5ApP-6mjA8aw0SthwcBYnYnkHh13e_46s4ThESPJANCAKlEr2n9VBhClb1JwW_5IiYgljeAv9hJzfculpb9J6QF_lqQY=@protonmail.com' \
    --to=langbart@protonmail.com \
    --cc=zsh-users@zsh.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).