Re: Oliver Kiddle: compctl -l broken and function installation

Re: Oliver Kiddle: compctl -l broken and function installation

[Sven Wischnowsky]

Oliver Kiddle wrote:

> The -l option to compctl seems to be broken. I first noticed this a
> while ago (about pws-18), it exists in pws-21 but wasn't there in a
> pws-16 I had lying about.
> 
> For example:
> zsh -f
> compctl -l '' t
> t <tab>
> 
> Gives a beep.

ccont was set to zero which caused the test after trying the
(non-existent) pattern compctl's to succeed -- and hence the
completion code stopped trying to generate matches.

The patch also makes `compctl -h' use ccont.

Bye
 Sven

diff -u os/Zle/zle_tricky.c Src/Zle/zle_tricky.c
--- os/Zle/zle_tricky.c	Tue Jun  8 15:23:27 1999
+++ Src/Zle/zle_tricky.c	Wed Jun  9 11:22:28 1999
@@ -5026,7 +5026,8 @@
 	char **ow = clwords, *os = cmdstr, *oqp = qipre, *oqs = qisuf;
 	int olws = clwsize, olwn = clwnum, olwp = clwpos;
 	int obr = brange, oer = erange, oof = offs;
-	
+	unsigned long occ = ccont;
+
 	clwsize = clwnum = countlinknodes(foo);
 	clwords = (char **) zalloc((clwnum + 1) * sizeof(char *));
 	for (n = firstnode(foo), i = 0; n; incnode(n), i++) {
@@ -5041,7 +5042,9 @@
 	qipre = qp;
 	qisuf = qs;
 	offs = soffs;
+	ccont = CC_CCCONT;
 	makecomplistcmd(ns, !clwpos, CFN_FIRST);
+	ccont = occ;
 	offs = oof;
 	zsfree(cmdstr);
 	cmdstr = os;
@@ -6500,7 +6503,7 @@
 	int oldn = clwnum, oldp = clwpos;
 	unsigned long occ = ccont;
 	
-	ccont = 0;
+	ccont = CC_CCCONT;
 	
 	/* So we restrict the words-array. */
 	if (brange >= clwnum)

--
Sven Wischnowsky                         wischnow@informatik.hu-berlin.de

RE: Oliver Kiddle: compctl -l broken and function installation

[Andrej Borsenkow]

> 
> ccont was set to zero which caused the test after trying the
> (non-existent) pattern compctl's to succeed -- and hence the
> completion code stopped trying to generate matches.
> 
> The patch also makes `compctl -h' use ccont.
>

(warnings omitted)
 
zle_tricky.c  4933: [error]:   CFE1165 too few arguments in function call
      strinbeg();
               ^
  
zle_tricky.c  6347: [error]:   CFE1165 too few arguments in function call
        strinbeg();
                 ^
 
zle_tricky.c  8105: [error]:   CFE1165 too few arguments in function call
        strinbeg();
                 ^
 
zle_tricky.c  8184: [error]:   CFE1165 too few arguments in function call
        strinbeg();
                 ^
  
gmake[3]: *** [zle_tricky..o] Error 1
gmake[3]: Leaving directory `/tools/src/zsh-3.1.5-pws-21/Src/Zle'
gmake[2]: *** [modules] Error 1
gmake[2]: Leaving directory `/tools/src/zsh-3.1.5-pws-21/Src'
gmake[1]: *** [modules] Error 2
gmake[1]: Leaving directory `/tools/src/zsh-3.1.5-pws-21/Src'
gmake: *** [all] Error 1
bor@itsrm2:/tools/src/zsh-3.1.5-pws-21%> 

Oliver Kiddle: compctl -l broken and function installation

[Peter Stephenson]

(So far I only have this via private mail, so I've forwarded it, see end.
Oliver, the 'yes' bug has now been fixed.)

------- Forwarded Message

Message-Id: <375E28CA.33ED59B5@thoth.u-net.com>
Date: Wed, 09 Jun 1999 09:41:46 +0100
From: Oliver Kiddle <opk@thoth.u-net.com>
Mime-Version: 1.0
To: zsh-workers@sunsite.auc.dk
Cc: Peter Stephenson <pws@ibmth.df.unipi.it>
Subject: compctl -l broken and function installation
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit

I installed pws-21 at home (where I use the new style completions) and
tried out the new stuff for installing the completion functions. I
didn't specify the directory, leaving it to use the default. Anyway, it
decided to install them in a directory named 'yes'. This was with IRIX
5.3 if that's relevant. I'll hopefully have time to look into it in more
detail on the weekend if it isn't fixed first.

Personally, I would prefer if the directory structure from the
distribution for the completion functions was preserved by the
installation (Base, Builtins, Commands etc). It would keep the directory
more manageable. Also, it might allow different users to have a
different selection of the functions on the same system.
Another suggestion would be to separate some of the functions in User
which are system dependant into separate directories which can be
selected from. For example, there could be directories for Gnu, BSD,
SYSV, AIX, IRIX, Linux etc.

When compiling on IRIX, I got a load of warnings relating to typedef
unsigned long; being duplicate in /usr/include/sys/types.h. I don't
think I've seen them before. I assume that the warnings resulted from
something the pre-processor was doing. Is this possibly a result of the
long file changes. Again, I should have more time on the weekend to take
a closer look at this.

I sent the following e-mail to the list yesterday and it didn't seem to
get through. Sorry if you end up with it twice.

The -l option to compctl seems to be broken. I first noticed this a
while ago (about pws-18), it exists in pws-21 but wasn't there in a
pws-16 I had lying about.

For example:
zsh -f
compctl -l '' t
t <tab>

Gives a beep.
I get the same problems when using the find -exec example from the
documentation. The problem exists on both AIX and IRIX.

Thanks

Oliver Kiddle

PS. Peter: I've cc'd this to you because I suspect that it will fail to
be delivered as I've had a few problems recently with my ISP not being
able to deliver to zsh-workers. If you don't get it from the mailing
list, please forward it.


------- End of Forwarded Message