rlimits.c recompiled on every make

rlimits.c recompiled on every make

[Andrej Borsenkow]

at least on Cygwin with static zsh. Even if everything is up to date.

-andrej

Have a nice DOS!
B >> 

Re: rlimits.c recompiled on every make

[Bart Schaefer]

On Jul 4,  9:44pm, Andrej Borsenkow wrote:
} Subject: rlimits.c recompiled on every make
}
} at least on Cygwin with static zsh. Even if everything is up to date.

Is the problem with Aliases/rlimits.c or Builtins/rlimits.c ?

-- 
Bart Schaefer                                 Brass Lantern Enterprises
http://www.well.com/user/barts              http://www.brasslantern.com

Zsh: http://www.zsh.org | PHPerl Project: http://phperl.sourceforge.net   

RE: rlimits.c recompiled on every make

[Andrej Borsenkow]

>
> On Jul 4,  9:44pm, Andrej Borsenkow wrote:
> } Subject: rlimits.c recompiled on every make
> }
> } at least on Cygwin with static zsh. Even if everything is
> up to date.
>
> Is the problem with Aliases/rlimits.c or Builtins/rlimits.c ?
>


To my understanding of GNU make, Builtins/rlimit.c

bash-2.04$ make
make[1]: Entering directory `/usr/build/zsh/Src'
make[2]: Entering directory `/usr/build/zsh/Src'
make[3]: Entering directory `/usr/build/zsh/Src/Aliases'
make[3]: Leaving directory `/usr/build/zsh/Src/Aliases'
make[3]: Entering directory `/usr/build/zsh/Src/Builtins'
make[3]: Leaving directory `/usr/build/zsh/Src/Builtins'
make[3]: Entering directory `/usr/build/zsh/Src/Modules'
make[4]: Entering directory `/usr/build/zsh/Src/Zle'
make[4]: Leaving directory `/usr/build/zsh/Src/Zle'
make[3]: Leaving directory `/usr/build/zsh/Src/Modules'
make[3]: Entering directory `/usr/build/zsh/Src/Zle'
make[3]: Leaving directory `/usr/build/zsh/Src/Zle'
make[2]: Leaving directory `/usr/build/zsh/Src'
rm -f stamp-modobjs.tmp
make[2]: Entering directory `/usr/build/zsh/Src'
`zshpaths.h' is up to date.
echo '' builtin.o compat.o cond.o exec.o glob.o hashtable.o hist.o
init.o input.
o jobs.o lex.o linklist.o loop.o math.o mem.o module.o options.o
params.o parse.
o pattern.o prompt.o signals.o signames.o subst.o text.o utils.o watch.o
>> ../S
rc/stamp-modobjs.tmp
make[3]: Entering directory `/usr/build/zsh/Src/Aliases'
make[3]: Leaving directory `/usr/build/zsh/Src/Aliases'
make[3]: Entering directory `/usr/build/zsh/Src/Builtins'
gawk -f /usr/src/zsh/Src/Builtins/rlimits.awk /dev/null > rlimits.h
gcc -c -I.  -DHAVE_CONFIG_H -Wall -Wno-implicit -Wmissing-prototypes -gg
db  -o r
limits.o /usr/src/zsh/Src/Builtins/rlimits.c
rlimits.pro:2: warning: `showlimits' declared `static' but never defined
rlimits.pro:3: warning: `printulimit' declared `static' but never
defined
rlimits.pro:4: warning: `bin_limit' declared `static' but never defined
rlimits.pro:5: warning: `bin_unlimit' declared `static' but never
defined
rlimits.pro:6: warning: `bin_ulimit' declared `static' but never defined
echo '' rlimits.o | sed 's" " Builtins/"g' >>
../../Src/stamp-modobjs.tmp
echo '' sched.o | sed 's" " Builtins/"g' >> ../../Src/stamp-modobjs.tmp
make[3]: Leaving directory `/usr/build/zsh/Src/Builtins'
.....

-andrej

Re: rlimits.c recompiled on every make

[Bart Schaefer]

On Jul 6, 10:35am, Andrej Borsenkow wrote:
} Subject: RE: rlimits.c recompiled on every make
}
} make[3]: Entering directory `/usr/build/zsh/Src/Builtins'
} gawk -f /usr/src/zsh/Src/Builtins/rlimits.awk /dev/null > rlimits.h
                                                ^^^^^^^^^

Here's the problem.  @RLIMITS_INC_H@ is being replaced by /dev/null; I
suspect the mod time of /dev/null changes whenever it's written-to, so
it's almost always newer than rlimits.h -- hence rlimits.h is remade,
and so rlimits.o is also remade.

Please re-run configure and let me know whether you see the message

    RLIMIT MACROS NOT FOUND:  please report to developers

There's a comment in configure.in:

dnl rlimits.h only appears in dependencies if we are actually using it.

I suspect that comment may date from before rlimits.o was a module, and
is now incorrect -- or else it refers to the system <rlimits.h> rather
than to the generated file "Builtins/rlimits.h".

-- 
Bart Schaefer                                 Brass Lantern Enterprises
http://www.well.com/user/barts              http://www.brasslantern.com

Zsh: http://www.zsh.org | PHPerl Project: http://phperl.sourceforge.net   

RE: rlimits.c recompiled on every make

[Andrej Borsenkow]

>
> Here's the problem.  @RLIMITS_INC_H@ is being replaced by /dev/null; I
> suspect the mod time of /dev/null changes whenever it's written-to, so
> it's almost always newer than rlimits.h -- hence rlimits.h is remade,
> and so rlimits.o is also remade.
>
> Please re-run configure and let me know whether you see the message
>
>     RLIMIT MACROS NOT FOUND:  please report to developers
>

No, I do no get this message. It is output only if getrlimit() is found
but RLIMIT_* macros are missing. On Cygwin there is no getrlimit() at
all and no message.

In this case it is pretty useless to build rlimit module?

-andrej

PATCH: Re: rlimits.c recompiled on every make

[Bart Schaefer]

On Jul 7, 12:22pm, Andrej Borsenkow wrote:
} Subject: RE: rlimits.c recompiled on every make
}
} > Here's the problem.  @RLIMITS_INC_H@ is being replaced by /dev/null; I
} > suspect the mod time of /dev/null changes whenever it's written-to, so
} > it's almost always newer than rlimits.h -- hence rlimits.h is remade,
} > and so rlimits.o is also remade.
} >
} > Please re-run configure and let me know whether you see the message
} >
} >     RLIMIT MACROS NOT FOUND:  please report to developers
} 
} No, I do no get this message. It is output only if getrlimit() is found
} but RLIMIT_* macros are missing. On Cygwin there is no getrlimit() at
} all and no message.

That is as I suspected.  OK, then, the patch below should handle it.
 
} In this case it is pretty useless to build rlimit module?

All of the rlimit commands get replaced with the `bin_notavail' stub, so
that you get a more informative error message than "command not found."

Index: configure.in
===================================================================
@@ -963,6 +963,9 @@
   AC_MSG_WARN(RLIMIT MACROS NOT FOUND:  please report to developers)
 fi])
 RLIMITS_INC_H=$zsh_cv_path_rlimit_h
+if test "$RLIMITS_INC_H" = "/dev/null"; then
+  RLIMITS_INC_H=''
+fi
 dnl rlimits.h only appears in dependencies if we are actually using it.
 dnl We are using it any time we have getrlimit, though if the macros were
 dnl not found we simply awk through /dev/null and fail to find them.
Index: Src/Builtins/rlimits.mdd
===================================================================
@@ -9,7 +9,7 @@
 
 # this file will not be made if limits are unavailable
 rlimits.h: rlimits.awk @RLIMITS_INC_H@
-	$(AWK) -f $(sdir)/rlimits.awk @RLIMITS_INC_H@ > rlimits.h
+	$(AWK) -f $(sdir)/rlimits.awk @RLIMITS_INC_H@ /dev/null > rlimits.h
 	@if grep ZLIMTYPE_UNKNOWN rlimits.h >/dev/null; then \
 	    echo >&2 WARNING: unknown limits: mail rlimits.h to developers; \
 	else :; fi

-- 
Bart Schaefer                                 Brass Lantern Enterprises
http://www.well.com/user/barts              http://www.brasslantern.com

Zsh: http://www.zsh.org | PHPerl Project: http://phperl.sourceforge.net