zsh-3.1.6-pws-10: sudo completion does not work again

zsh-3.1.6-pws-10: sudo completion does not work again

[Andrej Borsenkow]

Hi!

This completion does not work again.

bor@itsrm2:~%> cat ~/.zsh.d/completion/_sudo
#compdef sudo

_arguments \
        '-V[show version]' \
        '-l[list commands]' \
        '-h[show help]' \
        '-v[validate timestamp file]' \
        '-k[remove timestamp file]' \
        '-b[run command in background]' \
        '-r:Kerberos realm:' \
        '-p:prompt:' \
        '-u:user name:_users' \
        '-s[run SHELL]' \
        '-H[set HOME environment variable]' \
        '::complete command and/or arguments:_normal' 

and if I try to call it:

bor@itsrm2:~%> sudo um<TAB>   (implying umount)   
_tags:9: job table full or recursion limit exceeded

/andrej

Re: zsh-3.1.6-pws-10: sudo completion does not work again

[Clint Adams]

>      _arguments \
>        ...
>        '*::command and arguments: _normal'

Err.. can we include this upstream?

Re: zsh-3.1.6-pws-10: sudo completion does not work again

[Sven Wischnowsky]

I wrote:

> [ Like Adam I had trouble getting this through to sunsite, hope it
>   works now. ]

Uh. Unlike Adam, then (didn't try to send to -announce).

But still... sunsite.auc.dk is down pretty often.

Bye
 Sven


--
Sven Wischnowsky                         wischnow@informatik.hu-berlin.de

Re: zsh-3.1.6-pws-10: sudo completion does not work again

[Sven Wischnowsky]

[ Like Adam I had trouble getting this through to sunsite, hope it
  works now. ]

Andrej Borsenkow wrote:

> ...
>
> > > bor@itsrm2:~%> sudo um<TAB>   (implying umount)
> > > _tags:9: job table full or recursion limit exceeded
>
> ...
> 
> Still, I believe, such condition(s) should be handled more gracefully. The above
> error message is really meaningless to end user.

1) As long as the completion functions are correct, they won't see
   such messages.
2) Yes, maybe, but: how? The only thing I could think about here is to 
   make _normal check if it got called with the same words/CURRENT/etc 
   as on the last call and then do some error handling if it was.
   Looks a bit weird. Somehow. Dunno.


Bye
 Sven


--
Sven Wischnowsky                         wischnow@informatik.hu-berlin.de

RE: zsh-3.1.6-pws-10: sudo completion does not work again

[Andrej Borsenkow]

>
> > This completion does not work again.
>
> Did it once work?
>

Mmm ... I believe, yes :-)

> > ...
> >         '::complete command and/or arguments:_normal'
> >
> > and if I try to call it:
> >
> > bor@itsrm2:~%> sudo um<TAB>   (implying umount)
> > _tags:9: job table full or recursion limit exceeded
>
> The line above describes an optional argument. It does not say that
> the completion system should continue with only some of the words from
> the line.
>

Thank you. I suspected something like this. Sorry for stupid question, but for
the last couple of months I was almost the whole time off and simply could not
keep up with rapid changes.

Still, I believe, such condition(s) should be handled more gracefully. The above
error message is really meaningless to end user.


/andrej

Re: zsh-3.1.6-pws-10: sudo completion does not work again

[Sven Wischnowsky]

I wrote:

> You want:
> 
>      _arguments \
>        ...
>        '*::command and arguments: _normal'
> 
> And that works.

I forgot to say: what you really want is, I think, this:

  ':command: _command_names -e' \
  '*::arguments:_normal' 

So that you don't get the builtins.

Bye
 Sven


--
Sven Wischnowsky                         wischnow@informatik.hu-berlin.de

Re: zsh-3.1.6-pws-10: sudo completion does not work again

[Sven Wischnowsky]

Andrej Borsenkow wrote:

> This completion does not work again.

Did it once work?

> ...
>         '::complete command and/or arguments:_normal' 
> 
> and if I try to call it:
> 
> bor@itsrm2:~%> sudo um<TAB>   (implying umount)   
> _tags:9: job table full or recursion limit exceeded

The line above describes an optional argument. It does not say that
the completion system should continue with only some of the words from 
the line.

You want:

     _arguments \
       ...
       '*::command and arguments: _normal'

And that works.

Bye
 Sven


--
Sven Wischnowsky                         wischnow@informatik.hu-berlin.de