dev-19 + latest patches: all Makefiles are rebuilt every time make is run

dev-19 + latest patches: all Makefiles are rebuilt every time make is run

[Andrej Borsenkow]

That is, it rebuilds modules.index and reruns Makemod and recreates every
Makefile in Src/** and recomples init.c (rebuilding zsh 'course) every time
make is run.

Is it supposed to be this way?

/andrej

PATCH: Re: dev-19 + latest patches: all Makefiles are rebuilt every time make is run

[Bart Schaefer]

On Mar 3,  3:25pm, Andrej Borsenkow wrote:
} Subject: dev-19 + latest patches: all Makefiles are rebuilt every time mak
}
} That is, it rebuilds modules.index and reruns Makemod and recreates every
} Makefile in Src/** and recomples init.c (rebuilding zsh 'course) every time
} make is run.

My fault, sorry.

Index: Src/Makefile.in
===================================================================
RCS file: /extra/cvsroot/zsh/zsh-3.1/Src/Makefile.in,v
retrieving revision 1.20
diff -u -r1.20 Makefile.in
--- Makefile.in	2000/03/01 18:22:44	1.20
+++ Makefile.in	2000/03/03 16:20:08
@@ -131,7 +131,13 @@
 mymods.conf:
 	@echo Linking with the standard modules.
 
-modules-bltin: Makefile $(sdir)/xmods.conf mymods.conf
+modules-bltin:: mymods.conf
+	@if test -f mymods.conf; then \
+	    echo cat mymods.conf \> $@; \
+	    cat mymods.conf > $@; \
+	fi
+
+modules-bltin:: Makefile $(sdir)/xmods.conf
 	if test -f mymods.conf; then \
 	    cat mymods.conf > $@; \
 	elif test @D@ = N; then \

-- 
Bart Schaefer                                 Brass Lantern Enterprises
http://www.well.com/user/barts              http://www.brasslantern.com

Re: PATCH: Re: dev-19 + latest patches: all Makefiles are rebuilt every time make is run

[Zefram]

Bart Schaefer wrote:
>+modules-bltin:: mymods.conf

What's this double colon?  It's very much not portable.

-zefram

Re: PATCH: Re: dev-19 + latest patches: all Makefiles are rebuilt every time make is run

[Bart Schaefer]

On Mar 3,  6:11pm, Zefram wrote:
} Subject: Re: PATCH: Re: dev-19 + latest patches: all Makefiles are rebuilt
}
} Bart Schaefer wrote:
} >+modules-bltin:: mymods.conf
} 
} What's this double colon?  It's very much not portable.

Eh?  That's been legal in every "make" I've used since 1985.  Where do
you know it to fail?

It tells "make" that there are different commands for the same target
when there are different dependencies.  That is, normally if you write

target: dependency1
	command1

target: dependency2
	command2

You'll get either an error or something like

    warning: overriding commands for target `target'
    warning: ignoring old commands for target `target'

If you use a double colon, it means that "make" should execute command1
when dependency1 is out of date, and should execute command2 when
dependency2 is out of date, i.e. they're no longer mutually exclusive.

-- 
Bart Schaefer                                 Brass Lantern Enterprises
http://www.well.com/user/barts              http://www.brasslantern.com