vared messes up tty state

vared messes up tty state

[Bart Schaefer]

If you have `stty -echo` as e.g. in an emacs buffer and you run vared,
then after vared exits, echo mode has been forced back on.

`ttyctl -f` has no effect on this.

Arguably, vared shouldn't even work in this condition (it behaves as
if SINGLE_LINE_ZLE, when in fact ZLE is entirely disabled).

Re: vared messes up tty state

[Sven Wischnowsky]

Bart Schaefer wrote:

> On May 25, 10:02am, Sven Wischnowsky wrote:
> } Subject: Re: vared messes up tty state
> }
> } Bart Schaefer wrote:
> } 
> } > Arguably, vared shouldn't even work in this condition (it behaves as
> } > if SINGLE_LINE_ZLE, when in fact ZLE is entirely disabled).
> } 
> } I agree with this last one, so should we?
> 
> I think so.

Good, I've now committed it (11566).

Bye
 Sven


--
Sven Wischnowsky                         wischnow@informatik.hu-berlin.de

Re: vared messes up tty state

[Bart Schaefer]

On May 25, 10:02am, Sven Wischnowsky wrote:
} Subject: Re: vared messes up tty state
}
} Bart Schaefer wrote:
} 
} > Arguably, vared shouldn't even work in this condition (it behaves as
} > if SINGLE_LINE_ZLE, when in fact ZLE is entirely disabled).
} 
} I agree with this last one, so should we?

I think so.

-- 
Bart Schaefer                                 Brass Lantern Enterprises
http://www.well.com/user/barts              http://www.brasslantern.com

Re: vared messes up tty state

[Sven Wischnowsky]

Bart Schaefer wrote:

> If you have `stty -echo` as e.g. in an emacs buffer and you run vared,
> then after vared exits, echo mode has been forced back on.
> 
> `ttyctl -f` has no effect on this.
> 
> Arguably, vared shouldn't even work in this condition (it behaves as
> if SINGLE_LINE_ZLE, when in fact ZLE is entirely disabled).

I agree with this last one, so should we?

Bye
 Sven

diff -u -r ../oz/Src/Zle/zle_main.c ./Src/Zle/zle_main.c
--- ../oz/Src/Zle/zle_main.c	Wed May 24 19:51:03 2000
+++ ./Src/Zle/zle_main.c	Wed May 24 20:47:57 2000
@@ -740,6 +740,10 @@
     char *p1 = NULL, *p2 = NULL;
     FILE *oshout = NULL;
 
+    if (unset(USEZLE)) {
+	zwarnnam(name, "ZLE not enabled", NULL, 0);
+	return 1;
+    }
     if (zleactive) {
 	zwarnnam(name, "ZLE cannot be used recursively (yet)", NULL, 0);
 	return 1;

--
Sven Wischnowsky                         wischnow@informatik.hu-berlin.de