Compilation on IRIX 5.3

Compilation on IRIX 5.3

[Oliver Kiddle]

When compiling on IRIX 5.3, I get this:

Can't open -e
Can't open /^!MOD!)$/q;p

repeated several times. Wasn't this from one of the Solaris sed
fixes recently? If not, the last time I compiled Zsh on my Indigo
was 3.1.6-dev-21 so it is since then. I've stuck some more of
the output leading up to this on then end of this message.

Another thing which I've been meaning to look at for ages is that
I get the following repeatedly on an IRIX 5.3 build:

cfe: Warning 753: /usr/include/sys/types.h, line 111: declaration
must at least declare an identifier, tag, or the member of an
enumeration
 typedef        unsigned long   unsigned long ;          
 ^
cfe: Warning 645: /usr/include/sys/types.h, line 111: Duplicate 'unsigned'
 typedef        unsigned long   unsigned long ;          
 -------        -------------   ^

This has been around since about 3.1.5-dev-25 and was caused by
the long file support. I've also put the section of types.h on
the end of this message.

Despite these, Zsh does build successfully. I ran the tests an everything
passed until 53completion.ztst. It seems that zpty doesn't work but I
haven't got time to look at that at the moment. I've added a patch
though which just fixes the English in a few print statements in
comptest.

Oliver Kiddle

partial make output:
            set '' Zsh/mod_cap.yo Zsh/mod_clone.yo  Zsh/mod_compctl.yo Zsh/mod_complete.yo Zsh/mod_complist.yo  Zsh/mod_computil.yo  Zsh/mod_deltochar.yo Zsh/mod_example.yo Zsh/mod_files.yo  Zsh/mod_mapfile.yo Zsh/mod_mathfunc.yo Zsh/mod_parameter.yo Zsh/mod_sched.yo  Zsh/mod_stat.yo Zsh/mod_zftp.yo Zsh/mod_zle.yo Zsh/mod_zleparameter.yo  Zsh/mod_zutil.yo Zsh/mod_zprof.yo Zsh/mod_zpty.yo; \
            mod1= mod2= mod3=; \
            test ".$2" = . || \
                mod2=`sed -n '1{s|^COMMENT(!MOD!||;p;q;}' < ./$2`; \
            while test ".$2" != .; do \
                mod3=; \
                test ".$3" = . || \
                    mod3=`sed -n '1{s|^COMMENT(!MOD!||;p;q;}' < ./$3`; \
                echo "texinode(The $mod2 Module)(${mod3:+The $mod3 Module})(${mod1:+The $mod1 Module})(Zsh Modules)"; \
                echo "sect(The $mod2 Module)"; \
                echo "includefile(${2})`"; \
                shift; \
                mod1=$mod2; \
                mod2=$mod3; \
            done \
        ) > ./Zsh/modlist.yo
Can't open -e
Can't open /^!MOD!)$/q;p
Can't open -e
Can't open /^!MOD!)$/q;p

types.h (with line numbers added):

   104  #if (_MIPS_SZLONG == 32)
   105  typedef unsigned long   mode_t;         /* file attrs */
   106  typedef unsigned long   dev_t;          /* device type */
   107  typedef long            uid_t;
   108  typedef long            gid_t;
   109  typedef unsigned long   nlink_t;        /* used for link counts */
   110  typedef long            pid_t;          /* proc & grp IDs  */
   111  typedef unsigned long   ino_t;          /* <inode> type */
   112  #endif
   113  #if (_MIPS_SZLONG == 64)
   114  typedef __uint32_t      mode_t;         /* file attrs */
   115  typedef __uint32_t      dev_t;          /* device type */
   116  typedef __int32_t       uid_t;
   117  typedef __int32_t       gid_t;
   118  typedef __uint32_t      nlink_t;        /* used for link counts */
   119  typedef __int32_t       pid_t;          /* proc & grp IDs  */
   120  typedef __uint32_t      ino_t;          /* <inode> type */
   121  #endif

--- Test/comptest    Sun May 21 19:01:00 2000
+++ Test/comptest Mon Jun  5 22:56:01 2000
@@ -19,7 +19,7 @@
   zpty zsh "$comptest_zsh" -f
 
   zpty -r zsh log1 "*<PROMPT>*" || { 
-    print "first prompt doesn't appered."
+    print "first prompt hasn't appeared."
     return 1
   }
 
@@ -75,7 +75,7 @@
   print -lr - "$@" > $tmp
   zpty -w zsh ". $tmp"
   zpty -r zsh log_eval "*<PROMPT>*" || {
-    print "prompt doesn't appered."
+    print "prompt hasn't appeared."
     return 1
   }
   rm $tmp
@@ -85,7 +85,7 @@
   input="$*"
   zpty -n -w zsh "$input"$'\C-Z'
   zpty -r zsh log "*<WIDGET><finish>*<PROMPT>*" || {
-    print "finish widget doesn't invoked."
+    print "failed to invoke finish widget."
     return 1
   }

Re: Compilation on IRIX 5.3

[Bart Schaefer]

On Jun 5,  9:58pm, Oliver Kiddle wrote:
> Subject: Compilation on IRIX 5.3
> When compiling on IRIX 5.3, I get this:
> 
> Can't open -e
> Can't open /^!MOD!)$/q;p
> 
> repeated several times. Wasn't this from one of the Solaris sed
> fixes recently?

Yes.  It's in Doc/Makefile.in, so it's not critical to building the shell
itself.  Thank goodness.

My only guess is that IRIX sed does not understand '-ne' and requires that
there be two options '-n -e' instead.  Could you try that?

> cfe: Warning 753: /usr/include/sys/types.h, line 111: declaration
> must at least declare an identifier, tag, or the member of an
> enumeration
>  typedef        unsigned long   unsigned long ;          
>  ^
> cfe: Warning 645: /usr/include/sys/types.h, line 111: Duplicate 'unsigned'
>  typedef        unsigned long   unsigned long ;          
>  -------        -------------   ^

What does line 111 of sys/types.h look like?

Configure has `#define'd as `unsigned long' something that IRIX wanted to
`typedef' instead.  We need to improve the configure test for that symbol,
whatever it is.

PATCH: Re: Compilation on IRIX 5.3

[Oliver Kiddle]

Bart Schaefer wrote:
> >
> > Can't open -e
> > Can't open /^!MOD!)$/q;p
> My only guess is that IRIX sed does not understand '-ne' and requires that
> there be two options '-n -e' instead.  Could you try that?

That was the problem. The IRIX sed does actually allow '-ne' as long as
there isn't another -e later on the line. The patch fixes our Makefile.

With the other problem with sys/types.h, I've been wasting your time
again so sorry about that. After removing certain entries from my
autoconf cache which were wrong, they were correctly determined when
rerunning configure so another program or older version of Zsh must have
got it wrong. I'll have to remember to try a clear cache before
reporting these build problems.

An unrelated point which I though I should mention is that if you run
the tests as root (which I did accidentally because I'd been root for
make install), you will get a failure for -r in the 07cond tests because
a file can be read as root even if the permissions are 000. I can't
think what the best way to deal with this is, maybe a check at the start
of the tests which displays a warning message.

I've also included a small change to _urls to use Sven's new -K option
to zparseopts. Is there a good reason why the -f options to _urls
completes files _first_ as opposed to together with URLs? I'd prefer to
be reminded by completion that urls would be valid in the current
context and anyone who likes the URLs first can always use a tag-order
style.

Oliver

Index: Completion/User/_urls
===================================================================
RCS file: /cvsroot/zsh/zsh/Completion/User/_urls,v
retrieving revision 1.12
diff -u -r1.12 _urls
--- Completion/User/_urls       2000/06/06 19:43:30     1.12
+++ Completion/User/_urls       2000/06/08 13:52:39
@@ -52,8 +52,8 @@
   _wanted -C -f files expl file _files "$@" && return 0
 fi

-zparseopts -D -E g:=glob
-: ${(A)=glob:=-g '*(^/)'}
+glob=(-g '*(^/)')
+zparseopts -D -K -E g:=glob

 ipre="$IPREFIX"

Index: Doc/Makefile.in
===================================================================
RCS file: /cvsroot/zsh/zsh/Doc/Makefile.in,v
retrieving revision 1.3
diff -u -r1.3 Makefile.in
--- Doc/Makefile.in     2000/06/02 17:22:50     1.3
+++ Doc/Makefile.in     2000/06/08 13:52:39
@@ -193,7 +193,7 @@
        ( \
            echo "startitem()"; \
            for modfile in $(MODDOCSRC); do \
-               sed -ne '1{s|^COMMENT(!MOD!\(.*\)$$|item(tt(\1))(|;p;d;}' \
+               sed -n -e '1{s|^COMMENT(!MOD!\(.*\)$$|item(tt(\1))(|;p;d;}' \
                    -e '/^!MOD!)$$/q;p' \
                    < $(sdir)/$$modfile; \
                echo ")"; \