Re: Somebody with gcc knowledge here? (Was: termcap moodule problem on Cygwin )

Re: Somebody with gcc knowledge here? (Was: termcap moodule problem on Cygwin )

[Sven Wischnowsky]

Andrej Borsenkow wrote:

> > > - move termcap (and terminfo) back into main zsh.
> >
> > You could force it to be statically linked by changing the `link' line to
> > test for cygwin in termcap.mdd.  See existing `link=' in terminfo.mdd for
> > how this works.  You can make this depend on a configure test for whether
> > termcap is static.
> >
> 
> Of course, I am idiot. Even more so as I cannot build zsh with static termcap:

So I'm not the only idiot. Good.

This happened to me, too. Somehow the Makefile calls the recursive
`make's twice when collection the module object files to be put into
stamp-modobjs. Since I don't really understand that part of the
Makefile anymore, I just added a `sort -u' in the rule that checks if
the new stamp-modobjs.tmp differs from existing stamp-modobjs. But I'm 
pretty sure this isn't the right way to solve it.

Then I forgot to mention it on the list. Sorry.

So... Zefram? Anyone?

Bye
 Sven


--
Sven Wischnowsky                         wischnow@informatik.hu-berlin.de

Re: Somebody with gcc knowledge here? (Was: termcap moodule problem on Cygwin )

[Bart Schaefer]

On Jan 31, 10:00am, Sven Wischnowsky wrote:
} Subject: Re: Somebody with gcc knowledge here? (Was:  termcap moodule prob
}
} Somehow the Makefile calls the recursive `make's twice when collection
} the module object files to be put into stamp-modobjs.

I've seen this as well (on linux, where it doesn't actually cause the
build to fail), and spent a little while trying to figure out why it was
happening, but I got lost in the twisty little maze of shell scripts
that create .in files that create makefiles that run shell scripts, and
gave up.

-- 
Bart Schaefer                                 Brass Lantern Enterprises
http://www.well.com/user/barts              http://www.brasslantern.com

Zsh: http://www.zsh.org | PHPerl Project: http://phperl.sourceforge.net   

RE: Somebody with gcc knowledge here? (Was: termcap moodule problem on Cygwin )

[Andrej Borsenkow]

> This happened to me, too. Somehow the Makefile calls the recursive
> `make's twice when collection the module object files to be put into
> stamp-modobjs.

Argh ...

Index: Src/mkmakemod.sh
===================================================================
RCS file: /cvsroot/zsh/zsh/Src/mkmakemod.sh,v
retrieving revision 1.5
diff -u -r1.5 mkmakemod.sh
--- Src/mkmakemod.sh    2000/11/26 20:01:03     1.5
+++ Src/mkmakemod.sh    2001/01/31 09:55:19
@@ -132,7 +132,13 @@
            $the_subdir/$lastsub/*) ;;
            $the_subdir/*/*)
                lastsub=`echo $modfile | sed
's,^'$the_subdir'/,,;s,/[^/]*$,,'`
-               all_subdirs="$all_subdirs $lastsub"
+               case "$all_subdirs" in
+                   *" $lastsub"* ) ;;
+                   *" $lastsub "* ) ;;
+                   * )
+                       all_subdirs="$all_subdirs $lastsub"
+                   ;;
+               esac
                ;;
            $the_subdir/*)
                mddname=`echo $modfile | sed 's,^.*/,,;s,\.mdd$,,'`

Re: Somebody with gcc knowledge here? (Was: termcap moodule problem on Cygwin )

[Zefram]

Andrej Borsenkow wrote:
>+               case "$all_subdirs" in
>+                   *" $lastsub"* ) ;;
>+                   *" $lastsub "* ) ;;

What you actually want here is

		case "$all_subdirs " in
		    *" $lastsub "* ) ;;

-zefram

RE: Somebody with gcc knowledge here? (Was: termcap moodule problem on Cygwin )

[Andrej Borsenkow]

> 
> 
> Andrej Borsenkow wrote:
> >+               case "$all_subdirs" in
> >+                   *" $lastsub"* ) ;;
> >+                   *" $lastsub "* ) ;;
> 
> What you actually want here is
> 
> 		case "$all_subdirs " in
> 		    *" $lastsub "* ) ;;
> 

I actually wanted is

               case "$all_subdirs" in
                   *" $lastsub" ) ;;
                   *" $lastsub "* ) ;;

to catch the case of just added subdir. It was copy'n'paste problem.

Or do I miss something?

-andrej

Re: Somebody with gcc knowledge here? (Was: termcap moodule problem on Cygwin )

[Bart Schaefer]

On Feb 1,  8:55am, Andrej Borsenkow wrote:
} Subject: RE: Somebody with gcc knowledge here? (Was:  termcap moodule prob
}
} > What you actually want here is
} > 
} > 		case "$all_subdirs " in
} > 		    *" $lastsub "* ) ;;
} 
} Or do I miss something?

You miss the significance of whitespace.  Look closely at the `case'
line.  Adding a trailing space there means you can always match a
trailing space in the pattern line, so you only need one pattern.

-- 
Bart Schaefer                                 Brass Lantern Enterprises
http://www.well.com/user/barts              http://www.brasslantern.com

Zsh: http://www.zsh.org | PHPerl Project: http://phperl.sourceforge.net   

RE: Somebody with gcc knowledge here? (Was: termcap moodule problem on Cygwin )

[Andrej Borsenkow]

> On Feb 1,  8:55am, Andrej Borsenkow wrote:
> } Subject: RE: Somebody with gcc knowledge here? (Was:  termcap moodule prob
> }
> } > What you actually want here is
> } >
> } > 		case "$all_subdirs " in
> } > 		    *" $lastsub "* ) ;;
> }
> } Or do I miss something?
>
> You miss the significance of whitespace.  Look closely at the `case'
> line.  Adding a trailing space there means you can always match a
> trailing space in the pattern line, so you only need one pattern.
>
> --

Erm. This won't match "bla-bla-bla $lastsub" case (when $lastsub is the last
one). You are right, trailing space is significant. For this reason two
patterns - *" $lastsub" and *" $lastsub "*.

Or I must go home today :-)

-andrej

Re: Somebody with gcc knowledge here? (Was: termcap moodule problem on Cygwin )

[Zefram]

Andrej Borsenkow wrote:
>I actually wanted is
...
>Or do I miss something?

Your new version does the same as mine, but mine is shorter.  That's all.

-zefram

RE: Somebody with gcc knowledge here? (Was: termcap moodule problem on Cygwin )

[Andrej Borsenkow]

> Cc: zsh-workers@sunsite.auc.dk
                                        ^^^^^^
Should not we change this?

>
> Your new version does the same as mine, but mine is shorter.  That's all.
>

Sorry, simply did not spot the correct blank. Not in the right mood yesterday.

-andrej

Somebody with gcc knowledge here? (Was: termcap moodule problem on Cygwin )

[Andrej Borsenkow]

> > - move termcap (and terminfo) back into main zsh.
>
> You could force it to be statically linked by changing the `link' line to
> test for cygwin in termcap.mdd.  See existing `link=' in terminfo.mdd for
> how this works.  You can make this depend on a configure test for whether
> termcap is static.
>

Of course, I am idiot. Even more so as I cannot build zsh with static termcap:

dllwrap -g  --export-all-symbols -o libzsh-3.1.9-dev-8.dll  `cat
stamp-modobjs`
-ltermcap -lm -lc
dllwrap: no export definition file provided
dllwrap: creating one, but that may not be what you want
Modules/termcap.o(.text+0x318): multiple definition of `setup_zshQstermcap'
Modules/termcap.o(.text+0x318): first defined here
Modules/termcap.o(.text+0x324): multiple definition of `boot_zshQstermcap'
Modules/termcap.o(.text+0x324): first defined here
Modules/termcap.o(.text+0x354): multiple definition of `cleanup_zshQstermcap'
Modules/termcap.o(.text+0x354): first defined here
Modules/termcap.o(.text+0x37c): multiple definition of `finish_zshQstermcap'
Modules/termcap.o(.text+0x37c): first defined here
collect2: ld returned 1 exit status

This happens with both dllwrap and gcc; I do not understand the error message
at all.

It does not happen when building static zsh.

Anybody have some insight on what these errors mean?

-andrej