* RE: Patch posted to SourceForge for zsh on cygwin
[not found] <1001213160119.ZM11908@candle.brasslantern.com>
@ 2000-12-14 12:41 ` Andrej Borsenkow
2000-12-14 12:49 ` Cosmo
0 siblings, 1 reply; 2+ messages in thread
From: Andrej Borsenkow @ 2000-12-14 12:41 UTC (permalink / raw)
To: ZSH workers mailing list
I think it should be discussed here.
The patch checks for $HOME being single slash when processing startup files to
avoid creating `//.zshrc' name that is interpreted as UNC name.
I have no objection to this in principle (but see below), but Bart already
mentioned the basic problem - you cannot catch all places where string is used
as file name. Just consider possible $HOME usage in any script/startup file; I
have may lines like
if [[ -f $HOME/foo/bar ]]; then ...
all of them have the same problem. `~' expansion has the same problem as well.
Patch checks for _WIN32, so I assume it was for 3.0.x native build. For 3.1.x
we have only Cygwin version - and people on Cygwin list explicitly warn
against setting HOME to `/'. ssh e.g. has the same problem that is frequent
cause of errors.
So, I ask - should we commit this patch that does not actually solve the
problems or just warn users against setting HOME to `/'?
-andrej
> -----Original Message-----
> From: Bart Schaefer [mailto:schaefer@candle.brasslantern.com]
> Sent: Wednesday, December 13, 2000 7:01 PM
> To: Andrej Borsenkow
> Subject: Patch posted to SourceForge for zsh on cygwin
>
>
> Would you please take a look at
>
> http://sourceforge.net/patch/?func=detailpatch&patch_id=102258&group_id=4068
>
> and commit it if it seems appropriate?
>
> --
> Bart Schaefer Brass Lantern Enterprises
> http://www.well.com/user/barts http://www.brasslantern.com
>
> Zsh: http://www.zsh.org | PHPerl Project: http://phperl.sourceforge.net
>
>
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: Patch posted to SourceForge for zsh on cygwin
2000-12-14 12:41 ` Patch posted to SourceForge for zsh on cygwin Andrej Borsenkow
@ 2000-12-14 12:49 ` Cosmo
0 siblings, 0 replies; 2+ messages in thread
From: Cosmo @ 2000-12-14 12:49 UTC (permalink / raw)
To: Andrej Borsenkow; +Cc: ZSH workers mailing list
Andrej Borsenkow wrote:
>
> I think it should be discussed here.
>
> The patch checks for $HOME being single slash when processing startup files to
> avoid creating `//.zshrc' name that is interpreted as UNC name.
> So, I ask - should we commit this patch that does not actually solve the
> problems or just warn users against setting HOME to `/'?
Just a thought.
Would setting HOME to `/..' be any kind of workaround? It should point to the same place
as `/' but I don't know enough about any internal processing that would possibly optimise
a path of `/../' to `//'?
Cosmo
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2000-12-14 12:51 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <1001213160119.ZM11908@candle.brasslantern.com>
2000-12-14 12:41 ` Patch posted to SourceForge for zsh on cygwin Andrej Borsenkow
2000-12-14 12:49 ` Cosmo
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).