zsh-workers
 help / color / mirror / code / Atom feed
From: "Andrej Borsenkow" <Andrej.Borsenkow@mow.siemens.ru>
To: "ZSH workers mailing list" <zsh-workers@sunsite.auc.dk>
Subject: PATCH: zpty.c - slave used before set warning
Date: Tue, 27 Jun 2000 18:18:21 +0400	[thread overview]
Message-ID: <000c01bfe042$8c1b3580$21c9ca95@mow.siemens.ru> (raw)

[-- Attachment #1: Type: text/plain, Size: 134 bytes --]

If fork() fails, newptycmd() could close random descriptor. Pretty rare,
I admit, but not improbable.

-andrej

Have a nice DOS!
B >>

[-- Attachment #2: zpty.diff --]
[-- Type: application/octet-stream, Size: 301 bytes --]

--- Src/Modules/zpty.c.org	Tue Jun 27 18:10:47 2000
+++ Src/Modules/zpty.c	Tue Jun 27 18:14:11 2000
@@ -279,7 +279,6 @@
     }
     if ((pid = fork()) == -1) {
 	close(master);
-	close(slave);
 	zwarnnam(nam, "couldn't create pty command: %s", pname, 0);
 	return 1;
     } else if (!pid) {

                 reply	other threads:[~2000-06-27 14:19 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='000c01bfe042$8c1b3580$21c9ca95@mow.siemens.ru' \
    --to=andrej.borsenkow@mow.siemens.ru \
    --cc=zsh-workers@sunsite.auc.dk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).