From: "Andrej Borsenkow" <Andrej.Borsenkow@mow.siemens.ru>
To: "Zsh hackers list" <zsh-workers@sunsite.auc.dk>
Subject: RE: PATCH: ptyread eating CPU on Cygwin
Date: Wed, 18 Oct 2000 20:44:44 +0400 [thread overview]
Message-ID: <001101c03922$b8381b90$21c9ca95@mow.siemens.ru> (raw)
In-Reply-To: <1001018155547.ZM4463@candle.brasslantern.com>
>
> I'm not Sven, but HAVE_SELECT does not imply having FD_ZERO or an fd_set
> typedef.
>
> On the other hand, I've just noticed that other code assumes in several
> places that it does imply those things, so it's probably OK.
>
Yes, it was just copy'n'paste.
> However, using a NULL timeout structure in the select() call has turned a
> non-blocking read into a fully blocking one. If you're going to do that,
> you might as well throw out the select() call and just set the descriptor
> back to blocking state before calling read(). I suspect there's a good
> reason it was a non-blocking read in the first place, though.
>
Erm. You are right, of course.
Non-blocking read made sense in initial implemetation, because it was the
condition to exit read loop (without pattern matching) - 9390:
+ do {
+ while ((ret = read(cmd->fd, buf + used, 1)) == 1) {
+ if (++used == blen) {
+ buf = hrealloc(buf, blen, blen << 1);
+ blen <<= 1;
+ }
+ }
+ buf[used] = '\0';
+ } while (prog && !pattry(prog, buf));
Currently zsh tries to always read the whole input (until EOF) Actually, in
pattern-matching mode it even completely ignores EOF. That makes absolutely no
functional difference between blocking and non-blocking mode but makes
performance in non-blocking mode terrible.
As it stands now, we really can just use blocking read.
-andrej
next prev parent reply other threads:[~2000-10-18 16:44 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2000-10-17 16:56 Andrej Borsenkow
2000-10-18 9:04 ` Peter Stephenson
2000-10-18 11:30 ` PATCH: " Andrej Borsenkow
2000-10-18 15:55 ` Bart Schaefer
2000-10-18 16:44 ` Andrej Borsenkow [this message]
2000-10-19 8:45 Sven Wischnowsky
2000-10-19 9:49 ` Andrej Borsenkow
2000-10-19 14:24 ` Bart Schaefer
2000-10-20 7:01 Sven Wischnowsky
2000-10-20 7:55 ` Andrej Borsenkow
2000-10-23 7:59 Sven Wischnowsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='001101c03922$b8381b90$21c9ca95@mow.siemens.ru' \
--to=andrej.borsenkow@mow.siemens.ru \
--cc=zsh-workers@sunsite.auc.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).