zsh-workers
 help / color / mirror / code / Atom feed
From: "Andrej Borsenkow" <Andrej.Borsenkow@mow.siemens.ru>
To: "ZSH workers mailing list" <zsh-workers@sunsite.auc.dk>
Subject: cd completion does not work in CVS version (unsafe word splitting in _alternative).
Date: Thu, 23 Dec 1999 17:58:21 +0300	[thread overview]
Message-ID: <001b01bf4d56$278c3710$21c9ca95@mow.siemens.ru> (raw)

With fresh CVS ... (actually, it was the reason I fetched CVS - it did not work
in patched pws-12 as well) cd into $cdpath does not work. I tracked it down to:

+_alternative:62> action=( _path_files -W \(/home/bor /home/bor/src /tools/src
/archive/sni/dbase\) -/ )
+_alternative:63> _path_files -J -default- -W (/home/bor /home/bor/src
/tools/src/archive/sni/dbase) -/
+

The relevant lines in _alternative are:

        action=( $=action )
        ${(e)action[1]} "$subopts[@]" "$expl[@]" "${(@e)~action[2,-1]}"

In other words, _every_ action with SP in argument is doomed because it is
splitted in multiple arguments. This is a general problem.

In case of _cd this results from:

    _alternative \
        'local-directories:local directories:_path_files -/' \
        "path-directories: directories in cdpath:_path_files -W
\\(${${(@)cdpath:#.}}\\) -/"

I don't see, why should we exclude `.'. If it is in cdpath and user requested
path-directories - why not?

/andrej


             reply	other threads:[~1999-12-23 15:28 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
1999-12-23 14:58 Andrej Borsenkow [this message]
1999-12-23 15:57 ` Andrej Borsenkow

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='001b01bf4d56$278c3710$21c9ca95@mow.siemens.ru' \
    --to=andrej.borsenkow@mow.siemens.ru \
    --cc=zsh-workers@sunsite.auc.dk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).