From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 11861 invoked from network); 23 Oct 2000 08:15:33 -0000 Received: from sunsite.auc.dk (130.225.51.30) by ns1.primenet.com.au with SMTP; 23 Oct 2000 08:15:33 -0000 Received: (qmail 29807 invoked by alias); 23 Oct 2000 08:15:28 -0000 Mailing-List: contact zsh-workers-help@sunsite.auc.dk; run by ezmlm Precedence: bulk X-No-Archive: yes X-Seq: 13063 Received: (qmail 29799 invoked from network); 23 Oct 2000 08:15:28 -0000 X-Envelope-Sender-Is: Andrej.Borsenkow@mow.siemens.ru (at relayer david.siemens.de) From: "Andrej Borsenkow" To: "Sven Wischnowsky" , Subject: OT: assignment to errno RE: PATCH: ptyread eating CPU on Cygwin Date: Mon, 23 Oct 2000 12:15:22 +0400 Message-ID: <001b01c03cc9$63b6eec0$21c9ca95@mow.siemens.ru> MIME-Version: 1.0 Content-Type: text/plain; charset="koi8-r" Content-Transfer-Encoding: 7bit X-Priority: 3 (Normal) X-MSMail-Priority: Normal X-Mailer: Microsoft Outlook IMO, Build 9.0.2416 (9.0.2911.0) X-MimeOLE: Produced By Microsoft MimeOLE V5.50.4133.2400 In-reply-to: <200010230759.JAA21293@beta.informatik.hu-berlin.de> Importance: Normal > + errno == EWOULDBLOCK Not exactly relevant, but assignment to errno is a bad style. It may well be a function (or some non-lvalue entity), espicially in case of threads support. Also, I was really surprised recently to hear, that C9X and ISO C++ _require_ errno to be a macro. There are probably many other places where errno is assigned to, of course. But if we can avoid it - let's do it. -andrej