zsh-3.1.2-pws-12: append slash in cd completion weirdness with globcomplete

zsh-3.1.2-pws-12: append slash in cd completion weirdness with globcomplete

[Andrej Borsenkow]

Slash is autoappended if directory in in current directory but not if it is
in cdpath. E.g.:

bor@itsrm2:~%> cd samba-2.0.3    (/tools/src/...)

but

bor@itsrm2:~%> cd save/          (where save is subdir of current)

this all with new completion stuff 'course. Unmodified from pws-12 if
globcomplete is unset - it's O.K.

/andrej

P.S. Looking at _cd I'd say, it is the subdir case that is wrong. Why does
_path_files decide for me, if I want to use any magical suffix? If anybody
likes it this way - let him set user preferences.

Again, any function from Core must do _only_ what it is told explicitly. It
should _not_ assume anything about user's intention. So, the correct way in
above example is to use

_path_files -/ -W cdpath -S/ -q

in _cd.

cheers

/andrej

RE: zsh-3.1.2-pws-12: append slash in cd completion weirdness with globcomplete

[Andrej Borsenkow]

> 
> I was just about to say that I still can't reproduce it when I
> remembered: have you applied the patch from 5796?
> 

It fixes this. Thanks.

/andrej

RE: zsh-3.1.2-pws-12: append slash in cd completion weirdness with globcomplete

[Sven Wischnowsky]

Andrej Borsenkow wrote:

> bor@itsrm2:/tools/src/zsh-3.1.5-pws-12/Completion%> zsh -f
> itsrm2% fpath=(*(/))
> itsrm2% source Core/compinit
> itsrm2% cdpath=(/tools/src)
> itsrm2% cd samba-2.0.3/  (after the SECOND TAB)
> samba-2.0.3/     socks5-v1.0r9/   sudo.v1.5.8p2/   
> sendmail-8.9.3/  ssh-1.2.26/      
> 
> itsrm2% setopt globcomplete
> itsrm2% cd samba-2.0.3   (after the FIRST TAB)
> samba-2.0.3/     socks5-v1.0r9/   sudo.v1.5.8p2/   
> sendmail-8.9.3/  ssh-1.2.26/      

I was just about to say that I still can't reproduce it when I
remembered: have you applied the patch from 5796?

Bye
 Sven


--
Sven Wischnowsky                         wischnow@informatik.hu-berlin.de

RE: zsh-3.1.2-pws-12: append slash in cd completion weirdness with globcomplete

[Andrej Borsenkow]

> 
> Are you sure there is no other dir starting with `samba-2.0.3'
> reachable through `cdpath'? At least, it works for me.
> 

bor@itsrm2:/tools/src/zsh-3.1.5-pws-12/Completion%> zsh -f
itsrm2% fpath=(*(/))
itsrm2% source Core/compinit
itsrm2% cdpath=(/tools/src)
itsrm2% cd samba-2.0.3/  (after the SECOND TAB)
samba-2.0.3/     socks5-v1.0r9/   sudo.v1.5.8p2/   
sendmail-8.9.3/  ssh-1.2.26/      

itsrm2% setopt globcomplete
itsrm2% cd samba-2.0.3   (after the FIRST TAB)
samba-2.0.3/     socks5-v1.0r9/   sudo.v1.5.8p2/   
sendmail-8.9.3/  ssh-1.2.26/      


> 
> I don't thnik so, at least when we speak about `_path_files' since
> that completes only file names and there the slash is not only useful
> to have, but it's also the way builtin completion behaves.
> 

Yep. You are right (about the way builtin behaves).

> Otherwise, I'd liek to mention my suggestion about `style'-entries in
> `compconfig' again. Could you sent a list of all the things the
> example functions do that you don't like? That way we could probably
> come up with a list of things we'd like to make user-configurable.
> 

Well, in a couple of weeks may be :-)

cheers

/andrej

Re: zsh-3.1.2-pws-12: append slash in cd completion weirdness with globcomplete

[Sven Wischnowsky]

Andrej Borsenkow wrote:

> Slash is autoappended if directory in in current directory but not if it is
> in cdpath. E.g.:
> 
> bor@itsrm2:~%> cd samba-2.0.3    (/tools/src/...)
> 
> but
> 
> bor@itsrm2:~%> cd save/          (where save is subdir of current)
> 
> this all with new completion stuff 'course. Unmodified from pws-12 if
> globcomplete is unset - it's O.K.

Are you sure there is no other dir starting with `samba-2.0.3'
reachable through `cdpath'? At least, it works for me.

> P.S. Looking at _cd I'd say, it is the subdir case that is wrong. Why does
> _path_files decide for me, if I want to use any magical suffix? If anybody
> likes it this way - let him set user preferences.
> 
> Again, any function from Core must do _only_ what it is told explicitly. It
> should _not_ assume anything about user's intention. So, the correct way in
> above example is to use
> 
> _path_files -/ -W cdpath -S/ -q
> 
> in _cd.

I don't thnik so, at least when we speak about `_path_files' since
that completes only file names and there the slash is not only useful
to have, but it's also the way builtin completion behaves.

Otherwise, I'd liek to mention my suggestion about `style'-entries in
`compconfig' again. Could you sent a list of all the things the
example functions do that you don't like? That way we could probably
come up with a list of things we'd like to make user-configurable.

Bye
 Sven


--
Sven Wischnowsky                         wischnow@informatik.hu-berlin.de