From: Borsenkow Andrej <Andrej.Borsenkow@mow.siemens.ru>
To: Zsh hackers list <zsh-workers@sunsite.dk>
Subject: RE: Nasty bug in array-element typeset assignments
Date: Thu, 26 Jul 2001 15:08:38 +0400 [thread overview]
Message-ID: <002001c115c3$524f76b0$21c9ca95@mow.siemens.ru> (raw)
In-Reply-To: <3B5FEB29.884D31BF@u.genie.co.uk>
> > > Yes, recent changes has enabled it.
>
Commit log does not have article number, but diffs are here:
<http://cvs.sourceforge.net/cgi-bin/viewcvs.cgi/zsh/zsh/Src/builtin.c.diff?r
1=1.44&r2=1.45>
> Really? So what would it do? Make the whole foo array local or just the
> first element? Clearly neither works.
>
Probably, intent was to create new local array.
> > Yuk. Whoever decided on this has got a job on their hands.
>
> > Typeset is going to get *very* confused. Each change like this
> multiplies,
>
The problem is here:
/* Take arguments literally. Don't glob */
while ((asg = getasg(*argv++))) {
if (!typeset_single(name, asg->name,
(Param) (paramtab == realparamtab ?
gethashnode2(paramtab, asg->name) :
paramtab->getnode(paramtab,
asg->name)),
func, on, off, roff, asg->value, NULL))
returnval = 1;
}
We get foo[1]=bar and try to fetch parameter `foo[1]' that does not exist of
course, so later on in typeset_single we believe there is no such parameter.
It means, that we just set element of existing one in
} else if (PM_TYPE(on) == PM_SCALAR) {
/*
* This will either complain about bad identifiers, or will set
* a hash element or array slice. This once worked by accident,
* creating a stray parameter along the way via createparam(),
* now called below in the isident() branch.
*/
if (!(pm = setsparam(pname, ztrdup(value ? value : ""))))
return NULL;
value = NULL;
Later on we obviously change locality of this array in
if (keeplocal)
pm->level = keeplocal;
So, this may work assuming that we change getasg() to properly recognize
subscription.
Note, that this bug affects 4.0.2 as well so we better fix it and issue
4.0.3.
-andrej
next prev parent reply other threads:[~2001-07-26 11:09 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-07-26 5:13 Bart Schaefer
2001-07-26 9:23 ` Peter Stephenson
2001-07-26 9:28 ` Borsenkow Andrej
2001-07-26 9:44 ` Peter Stephenson
2001-07-26 9:57 ` Borsenkow Andrej
2001-07-26 10:04 ` Oliver Kiddle
2001-07-26 11:07 ` Oliver Kiddle
2001-07-26 11:08 ` Borsenkow Andrej [this message]
2001-07-26 11:18 ` Borsenkow Andrej
2001-07-26 11:38 ` Oliver Kiddle
2001-07-26 11:45 ` Peter Stephenson
2001-07-26 12:21 ` PATCH: posixbuiltins test (was Re: Nasty bug in array-element typeset assignments) Oliver Kiddle
2001-07-26 13:24 ` Nasty bug in array-element typeset assignments Borsenkow Andrej
2001-07-26 17:49 ` Bart Schaefer
2001-08-12 18:55 ` PATCH (?): " Bart Schaefer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='002001c115c3$524f76b0$21c9ca95@mow.siemens.ru' \
--to=andrej.borsenkow@mow.siemens.ru \
--cc=zsh-workers@sunsite.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).