zsh-workers
 help / color / mirror / code / Atom feed
* Re: collist loading RE: Patch available for 3.0.6-pre-5
@ 1999-06-21 10:48 Sven Wischnowsky
  1999-06-21 13:03 ` Andrej Borsenkow
  1999-06-22 16:37 ` Andrej Borsenkow
  0 siblings, 2 replies; 6+ messages in thread
From: Sven Wischnowsky @ 1999-06-21 10:48 UTC (permalink / raw)
  To: zsh-workers


I wrote:

> Andrej Borsenkow wrote:
> 
> > zmodload -i collist
> > 
> > results in
> > 
> > /home/bor/.zshrc: failed to load module: collist [6]
> > bor@itsrm2:~%>
> > 
> > I suspect, it need zle ot comp1, that are not yet loaded at this point.
> 
> They should be loaded automatically. Is your module path set up
> correctly at the time?

I forgot to diff xmods.conf. Sorry.

This also fixes a buglet in collist when saying `no' to `do you wish...'.

Bye
 Sven

diff -u -r oos/Zle/collist.c Src/Zle/collist.c
--- oos/Zle/collist.c	Mon Jun 21 12:46:02 1999
+++ Src/Zle/collist.c	Mon Jun 21 12:46:08 1999
@@ -390,6 +390,7 @@
 		tcmultout(TCUP, TCMULTUP, nlnct);
 	    } else
 		putc('\n', shout);
+	    return 0;
 	}
 	if (clearflag) {
 	    putc('\r', shout);
diff -u -r oos/xmods.conf Src/xmods.conf
--- oos/xmods.conf	Mon Jun 21 12:46:39 1999
+++ Src/xmods.conf	Mon Jun 21 12:42:29 1999
@@ -3,3 +3,4 @@
 zle
 compctl
 sched
+collist

--
Sven Wischnowsky                         wischnow@informatik.hu-berlin.de


^ permalink raw reply	[flat|nested] 6+ messages in thread

* RE: collist loading RE: Patch available for 3.0.6-pre-5
  1999-06-21 10:48 collist loading RE: Patch available for 3.0.6-pre-5 Sven Wischnowsky
@ 1999-06-21 13:03 ` Andrej Borsenkow
  1999-06-22 16:37 ` Andrej Borsenkow
  1 sibling, 0 replies; 6+ messages in thread
From: Andrej Borsenkow @ 1999-06-21 13:03 UTC (permalink / raw)
  To: Sven Wischnowsky, zsh-workers

> 
> This also fixes a buglet in collist when saying `no' to `do you wish...'.
> 
> Bye
>  Sven
> 
> diff -u -r oos/Zle/collist.c Src/Zle/collist.c
> --- oos/Zle/collist.c	Mon Jun 21 12:46:02 1999
> +++ Src/Zle/collist.c	Mon Jun 21 12:46:08 1999
> @@ -390,6 +390,7 @@
>  		tcmultout(TCUP, TCMULTUP, nlnct);
>  	    } else
>  		putc('\n', shout);
> +	    return 0;
>  	}
>  	if (clearflag) {
>  	    putc('\r', shout);


collist.c   393: [error]:   CFE1118 a void function may not return a value
            return 0;

/andrej


^ permalink raw reply	[flat|nested] 6+ messages in thread

* RE: collist loading RE: Patch available for 3.0.6-pre-5
  1999-06-21 10:48 collist loading RE: Patch available for 3.0.6-pre-5 Sven Wischnowsky
  1999-06-21 13:03 ` Andrej Borsenkow
@ 1999-06-22 16:37 ` Andrej Borsenkow
  1 sibling, 0 replies; 6+ messages in thread
From: Andrej Borsenkow @ 1999-06-22 16:37 UTC (permalink / raw)
  To: Sven Wischnowsky, zsh-workers

>
> I forgot to diff xmods.conf. Sorry.
>

Collist still is not autoloaded. As I understand, xmods.conf adds to the list of
autoloaded modules ... but collist does not have anything that can trigger it's
load. May be, ZLS_* should be added to autoparams for collist? This would
trigger loading as soon as anything from ZLS_* is defined.

/andrej


^ permalink raw reply	[flat|nested] 6+ messages in thread

* RE: collist loading RE: Patch available for 3.0.6-pre-5
  1999-06-21  9:49 Sven Wischnowsky
@ 1999-06-21  9:54 ` Andrej Borsenkow
  0 siblings, 0 replies; 6+ messages in thread
From: Andrej Borsenkow @ 1999-06-21  9:54 UTC (permalink / raw)
  To: Sven Wischnowsky, zsh-workers

> >
> > /home/bor/.zshrc: failed to load module: collist [6]
> > bor@itsrm2:~%>
> >
> > I suspect, it need zle ot comp1, that are not yet loaded at this point.
>
> They should be loaded automatically. Is your module path set up
> correctly at the time?
>

I don't set it up - it is default. It succeeds if I move zmodload to the end.
So, I think, zle/com1 are loaded on first reference to any builtin (bindkey in
my case).

Yes, just tried to put zmodload -L at the beginning and the end:

bor@itsrm2:~%> zsh
start of .zshrc
End of .zshrc
zmodload zle
zmodload compctl
zmodload comp1

/andrej


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: collist loading RE: Patch available for 3.0.6-pre-5
@ 1999-06-21  9:49 Sven Wischnowsky
  1999-06-21  9:54 ` Andrej Borsenkow
  0 siblings, 1 reply; 6+ messages in thread
From: Sven Wischnowsky @ 1999-06-21  9:49 UTC (permalink / raw)
  To: zsh-workers


Andrej Borsenkow wrote:

> collist is not (pre)loaded by default. Should it be? Or, better, can it be
> loaded on first use?
> 
> It fails to load from inside of .zshrc:
> 
> pg ~/.zshrc
> 
> #!/tools/bin/zsh
> ##
> ## Modules
> ##
> 
> zmodload -i collist
> 
> results in
> 
> /home/bor/.zshrc: failed to load module: collist [6]
> bor@itsrm2:~%>
> 
> I suspect, it need zle ot comp1, that are not yet loaded at this point.

They should be loaded automatically. Is your module path set up
correctly at the time?

Bye
 Sven


--
Sven Wischnowsky                         wischnow@informatik.hu-berlin.de


^ permalink raw reply	[flat|nested] 6+ messages in thread

* collist loading RE: Patch available for 3.0.6-pre-5
  1999-06-21  9:05 Sven Wischnowsky
@ 1999-06-21  9:44 ` Andrej Borsenkow
  0 siblings, 0 replies; 6+ messages in thread
From: Andrej Borsenkow @ 1999-06-21  9:44 UTC (permalink / raw)
  To: Sven Wischnowsky, zsh-workers

collist is not (pre)loaded by default. Should it be? Or, better, can it be
loaded on first use?

It fails to load from inside of .zshrc:

pg ~/.zshrc

#!/tools/bin/zsh
##
## Modules
##

zmodload -i collist

results in

/home/bor/.zshrc: failed to load module: collist [6]
bor@itsrm2:~%>

I suspect, it need zle ot comp1, that are not yet loaded at this point.

/andrej


^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~1999-06-22 16:38 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
1999-06-21 10:48 collist loading RE: Patch available for 3.0.6-pre-5 Sven Wischnowsky
1999-06-21 13:03 ` Andrej Borsenkow
1999-06-22 16:37 ` Andrej Borsenkow
  -- strict thread matches above, loose matches on Subject: below --
1999-06-21  9:49 Sven Wischnowsky
1999-06-21  9:54 ` Andrej Borsenkow
1999-06-21  9:05 Sven Wischnowsky
1999-06-21  9:44 ` collist loading " Andrej Borsenkow

Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).