From: "Bart Schaefer" <schaefer@candle.brasslantern.com>
To: "\"áÎÄÒÅÊ âÏÒÚÅÎËÏ×\"" <arvidjaar@mail.ru>
Cc: zsh-workers@sunsite.dk
Subject: Re: Fix for zpty under Cygwin
Date: Mon, 7 May 2001 12:47:39 -0700 [thread overview]
Message-ID: <010507124740.ZM27941@candle.brasslantern.com> (raw)
In-Reply-To: =?iso-8859-1?Q?=3CE14wpXB-0008aM-00=40f9=2Email=2Eru=3E?= =?iso-8859-1?Q?Comments=3A_In_reply_to_=22=E1=CE=C4=D2=C5=CA_=E2=CF=D2=DA?= =?iso-8859-1?Q?=C5=CE=CB=CF=D7=22_=3Carvidjaar=40mail=2Eru=3E?= =?iso-8859-1?Q?________=22Fix_for_zpty_under_Cygwin=22_=28May__7=2C_10=3A?= =?iso-8859-1?Q?15pm=29?=
On May 7, 10:15pm, áÎÄÒÅÊ âÏÒÚÅÎËÏ× wrote:
> Subject: Fix for zpty under Cygwin
>
> It was O_NOCTTY. Looks like O_NOCTTY is "sticky" under Cygwin and
> prevents this tty from becoming ctty when dup()'ing it later. I do not
> remeber when it was put in, so there are two possibilities:
>
> - we added this and that broke things
That's probably it; I copied that part from clone.c along with several
other changes (rev 1.15).
> So the fix under Cygwin is quite simple - just remove O_NOCTTY.
> Actually, I wonder what it does here at all - it is exactly the
> descriptor that *will* be ctty later.
It will be ctty in the forked-off child that runs on the pty, but we have
to open the descriptor originally in the parent before forking. O_NOCTTY
is to prevent the pty from becoming the parent's controlling terminal.
> Related problem is testing. Completion tests consistently failed; the
> reason was this line in comptest:
>
> zpty -b zsh "$comptest_zsh -f +Z"
The -b was added in 13035 when non-blocking mode was the default and -b
selected blocking mode, then never removed when the default switched again
in 13120. This was my error; the -b should not be there.
next prev parent reply other threads:[~2001-05-07 19:54 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-05-07 18:15 áÎÄÒÅÊ âÏÒÚÅÎËÏ×
2001-05-07 19:47 ` Bart Schaefer [this message]
2001-05-08 4:08 ` Re[2]: " áÎÄÒÅÊ âÏÒÚÅÎËÏ×
2001-05-08 10:23 ` Peter Stephenson
2001-05-08 12:45 ` Andrej Borsenkow
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=010507124740.ZM27941@candle.brasslantern.com \
--to=schaefer@candle.brasslantern.com \
--cc=arvidjaar@mail.ru \
--cc=zsh-workers@sunsite.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).