From: Bart Schaefer <schaefer@brasslantern.com>
To: Wayne Davison <wayned@users.sourceforge.net>
Cc: zsh-workers@sunsite.dk
Subject: Re: .zsh_history bugreport
Date: Fri, 26 Oct 2001 15:51:03 -0700 [thread overview]
Message-ID: <011026155103.ZM10856@candle.brasslantern.com> (raw)
In-Reply-To: <Pine.LNX.4.21.0110261110100.7802-100000@life.blorf.net>
On Oct 26, 11:26am, Wayne Davison wrote:
> Subject: Re: .zsh_history bugreport
> On Fri, 26 Oct 2001, Bart Schaefer wrote:
> > This was fixed by the patch in users/4269 and should be working in the
> > zsh-4.0.4 release from earlier today.
>
> Hmm. The start >= l (ell) check can only error-out if the null byte
> is at the start of the line (since once a section gets measured, it
> can't ever get any shorter).
No, that's not true. Look at the recursive call. The value passed in
for start is the value of the previous l. So if fgets() returns nonzero
but buf didn't get any longer, start == l and (start >= l) is true and so
we return -1. The greater-than check is just in there for completeness;
only the equivalence should happen in practice.
It doesn't matter where the null byte is.
next prev parent reply other threads:[~2001-10-26 22:51 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-10-26 14:26 Stepan Koltsov
2001-10-26 14:54 ` Bart Schaefer
2001-10-26 16:31 ` Stepan Koltsov
2001-10-26 18:26 ` Wayne Davison
2001-10-26 22:51 ` Bart Schaefer [this message]
2001-10-26 23:29 ` Wayne Davison
2001-10-30 17:36 ` Bart Schaefer
2001-10-30 18:25 ` Wayne Davison
2001-10-31 16:38 ` Bart Schaefer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=011026155103.ZM10856@candle.brasslantern.com \
--to=schaefer@brasslantern.com \
--cc=wayned@users.sourceforge.net \
--cc=zsh-workers@sunsite.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).