From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE autolearn=ham autolearn_force=no version=3.4.2 Received: from primenet.com.au (ns1.primenet.com.au [203.24.36.2]) by inbox.vuxu.org (OpenSMTPD) with ESMTP id 2a1288a8 for ; Thu, 23 May 2019 21:37:29 +0000 (UTC) Received: (qmail 6159 invoked by alias); 23 May 2019 21:37:13 -0000 Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm Precedence: bulk X-No-Archive: yes List-Id: Zsh Workers List List-Post: List-Help: List-Unsubscribe: X-Seq: 44358 Received: (qmail 9265 invoked by uid 1010); 23 May 2019 21:37:13 -0000 X-Qmail-Scanner-Diagnostics: from wout2-smtp.messagingengine.com by f.primenet.com.au (envelope-from , uid 7791) with qmail-scanner-2.11 (clamdscan: 0.101.2/25454. spamassassin: 3.4.2. Clear:RC:0(64.147.123.25):SA:0(-2.6/5.0):. Processed in 5.259343 secs); 23 May 2019 21:37:13 -0000 X-Envelope-From: d.s@daniel.shahaf.name X-Qmail-Scanner-Mime-Attachments: | X-Qmail-Scanner-Zip-Files: | Received-SPF: none (ns1.primenet.com.au: domain at daniel.shahaf.name does not designate permitted sender hosts) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= daniel.shahaf.name; h=mime-version:message-id:in-reply-to :references:date:from:to:subject:content-type; s=fm3; bh=QmQ6Zut txJhlOANn3VxL4Q2OMjCD7Jv4BfubdNOmMwE=; b=a/kNBvR+rxoDc6xbdqITAhc NvJbJroWBopii5tsA/ushyrlHXbzwcoGLy+EBcEANcNGjd/UDqmLR2OPDqqIz22n 1Vj+58x1LV5+U5W5vyT6542siCtj3JQqR3aJ0OMv0ckSIAFRT1H9Tl6U+uwntPee UtzYJm7OE9CLklbjGXHXqLyeuHD47+4n9s0a0QCsB3OZBFpCEEIBPTZkcGXn0ASU hmFOt9wJJF0DkdGlW2ueI3GWry870JdGAczdkRocMUq88prnAd06bT/RIHphKWcx si2aKjZ64gQQTDgL7zP5hVxiTJcRssYbiRlWWnor70YqN9nsiTCFHSkHAnDJRCA= = DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=QmQ6Zu ttxJhlOANn3VxL4Q2OMjCD7Jv4BfubdNOmMwE=; b=W6aHVaqE3Fr3eFoee0Ny3d t9TqCgdHC77L+VEq39wyko3TTZx8ED4igJnKVQBBrkZKxWoW1xWvAvWWuOY0zTkg bDJKH8JOkBU54OOL4OLYJnLLNWYW2y5yOQp3qehuFE84SfUgyQt6yb8MZaYmF5j3 6pDwZYE1sCo32jkHtupb4jyLcIf/tNxUMUpmkB64FxF6foDyMyB59CSxilFaJQFO bqCMuVA4OUSGWKrLEBpSYgUzJUCAAuoX/A1Y1OxZUbAK2COezpgJ39bzOZ7C38KS DEYfDbviVyGJrYuurjX6hAeFvXIQ0BrrbE6YeSwyyiSgT+VI32SKGyLOXjdNJRJA == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduuddrudduhecutefuodetggdotefrodftvfcurf hrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecuuegr ihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenucfjug hrpefofgggkfgjfhffhffvufgtsehttdertderredtnecuhfhrohhmpedfffgrnhhivghl ucfuhhgrhhgrfhdfuceougdrshesuggrnhhivghlrdhshhgrhhgrfhdrnhgrmhgvqeenuc ffohhmrghinhepghhithhhuhgsrdgtohhmnecurfgrrhgrmhepmhgrihhlfhhrohhmpegu rdhssegurghnihgvlhdrshhhrghhrghfrdhnrghmvgenucevlhhushhtvghrufhiiigvpe dt X-ME-Proxy: X-Mailer: MessagingEngine.com Webmail Interface User-Agent: Cyrus-JMAP/3.1.6-550-g29afa21-fmstable-20190520v1 Mime-Version: 1.0 Message-Id: <0333227b-69c3-4cd9-96df-8096d5dda0c7@www.fastmail.com> In-Reply-To: References: <68081d8c-1aa6-203b-eb6c-e2d048de1340@ibr.cs.tu-bs.de> Date: Thu, 23 May 2019 21:36:13 +0000 From: "Daniel Shahaf" To: "Roman Perepelitsa" , zsh-workers@zsh.org Subject: Re: Incorrect cursor position when ZLE_RPROMPT_INDENT=0 (with a fix) Content-Type: text/plain Roman Perepelitsa wrote on Thu, 23 May 2019 05:50 +00:00: > Is there anything else I need to do to move this forward? The patch > works on all terminals I and others have tried (11 in total; some with > multiple versions and/or configurations). The code no longer > special-cases ZLE_RPROMPT_INDENT=0, which is nice. There is branch for > ZLE_RPROMPT_INDENT=0 but it's just an optimization to avoid an > unnecessary zputc(&zr_cr) call when it's known to have no effect. So I > think the logic is simpler now. >From the peanut gallery, this sounds ready to merge. Even if it does cause a regression in some setup, hopefully that will come up in prerelease testing. Are there any other terminal emulators you'd like the patch to be tested on? (By the list, not necessarily by you) > I've attached the patch to the email. You can also find it at > https://github.com/zsh-users/zsh/compare/master...romkatv:rprompt-indent. In general, please always include patches with the email (inline or text/* attachment) so they'll be archived. Feel free to add github links too, of course. Cheers, Daniel