[PATCH] sysctl: support completion with the dot delimiter on linux

[PATCH] sysctl: support completion with the dot delimiter on linux

[Eric Cook]

This was a request from irc. historically zsh did completion using / as the
delimiter (via _files) which while supported, kinda foreign to users of other
OSes and how sysctl examples are commonly shown online.

As is the patch changes the delimiter used to `.' but will still perform
completion should `/' be used, along with a style to get the old behavior
by default. that style will be ignored should the user attempt completion
with the other delimiter.

If changing the delimiter to `.' is undesired, i can swap them around.

(the globbing of /proc/sys/ was deemed faster than using `sysctl -aN' FWIW)

---
diff --git a/Completion/Unix/Command/_sysctl b/Completion/Unix/Command/_sysctl
index 442953c4d..09995c98e 100644
--- a/Completion/Unix/Command/_sysctl
+++ b/Completion/Unix/Command/_sysctl
@@ -23,10 +23,18 @@ case $OSTYPE in
      else
        args=( ${args:#((#s)|*\))(\*|)--*} )     # remove long options
      fi
+    local delimiter=.
+    sysctlvars=( /proc/sys/**/*(.e*'REPLY=${REPLY#/proc/sys/}'*) )
+    if zstyle -t ":completion:${curcontext}:argument-rest" delimiter / || (( ${words[CURRENT][(Ie)/]} )); then
+      delimiter=/
+    else
+      sysctlvars=(${sysctlvars//\//.})
+    fi
+
      _arguments -S -A "-*" : $args \
        '(- :)'{-h,--help}'[display help text and exit]' \
        '(- :)'{-V,--version}'[display version info and exit]' \
-      '*:sysctl variable:_files -W /proc/sys'
+      "*:sysctl variable:_multi_parts -i -S = -q $delimiter sysctlvars"
    ;;
    freebsd<14->.*)
      args+=(