From: "Jun. T" <takimoto-j@kba.biglobe.ne.jp>
To: zsh-workers@zsh.org
Subject: Re: [PATCHv1] [long] improvements to limit/ulimit API and doc
Date: Fri, 27 Nov 2020 00:22:05 +0900 [thread overview]
Message-ID: <05C414E9-A152-40CD-90C3-C74D7FD773A8@kba.biglobe.ne.jp> (raw)
In-Reply-To: <20201126135523.7daayb7l543yrmcj@chazelas.org>
> 2020/11/26 22:55, Stephane Chazelas <stephane@chazelas.org> wrote:
>
> But:
>
> $ bash --posix -c 'ulimit 18446744073709551617; ulimit'
> 1
I think this is a bug of bash.
It seems bash checks the wrap around only for the calculation of
bytes = 512*blocks, and does not check if the number of blocks
is already wrapped around.
> There's also the question of the actual value of RLIM_INFINITY,
> RLIM_SAVED_MAX, RLIM_SAVED_CUR and whether we can assume
> RLIM_INFINITY is the maximum possible value.
I guess zsh need not care about these things.
# I must say I don't know what it means if RLIM_SAVED_XXX is not
# equal to RLIMI_INFINITY.
Zsh only need to check whether the new limit user wants to set is
within the range of rlim_t.
If it is not, then zsh should warn about it instead of passing the
wrap-around value to setrlimit(2).
If it is, then just pass it to setrlimit(2) (need not check whether
it is smaller than RLIM_INFINITY or not).
If setrlimit() returns error, then report it to the user.
Jun
next prev parent reply other threads:[~2020-11-26 15:22 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-23 21:49 Stephane Chazelas
2020-11-25 0:35 ` Daniel Shahaf
2020-11-25 6:44 ` Stephane Chazelas
2020-11-27 17:16 ` Daniel Shahaf
2020-11-26 6:57 ` [PATCHv2 1/2] [long] improvements to limit/ulimit API and doc ((un)limit in csh emulation) Stephane Chazelas
2020-11-25 23:43 ` [PATCHv1] [long] improvements to limit/ulimit API and doc Oliver Kiddle
2020-11-26 20:14 ` [PATCH] ulimit option completions using ulimit -a output Stephane Chazelas
2020-11-27 7:13 ` Stephane Chazelas
2020-11-27 8:15 ` Felipe Contreras
2020-11-27 12:19 ` Oliver Kiddle
2021-03-27 21:25 ` Lawrence Velázquez
2021-04-03 14:57 ` Lawrence Velázquez
2021-04-10 20:11 ` Lawrence Velázquez
2021-04-13 14:35 ` Daniel Shahaf
2021-05-09 20:37 ` Lawrence Velázquez
2021-05-11 19:05 ` Stephane Chazelas
2020-11-26 20:58 ` [PATCHv2 2/2] [long] improvements to limit/ulimit API and doc (the rest) Stephane Chazelas
2020-11-27 16:39 ` Daniel Shahaf
2020-11-27 20:13 ` Stephane Chazelas
2020-11-27 20:36 ` Daniel Shahaf
2020-11-28 6:52 ` zsh coding style (was about a limit patch review) Stephane Chazelas
2020-12-01 16:47 ` Daniel Shahaf
2020-11-28 8:16 ` [PATCHv3 2/2] [long] improvements to limit/ulimit API and doc (the rest) Stephane Chazelas
2021-03-27 21:21 ` Lawrence Velázquez
2021-03-31 18:06 ` Stephane Chazelas
2020-11-26 11:19 ` [PATCHv1] [long] improvements to limit/ulimit API and doc Jun T
2020-11-26 13:55 ` Stephane Chazelas
2020-11-26 15:22 ` Jun. T [this message]
2020-11-26 17:23 ` Stephane Chazelas
2020-11-27 18:24 ` Jun. T
2020-11-27 18:34 ` Daniel Shahaf
2020-11-27 20:46 ` Stephane Chazelas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=05C414E9-A152-40CD-90C3-C74D7FD773A8@kba.biglobe.ne.jp \
--to=takimoto-j@kba.biglobe.ne.jp \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).