From: Bart Schaefer <schaefer@brasslantern.com>
To: zsh-workers@sunsite.dk (Zsh hackers list)
Subject: Re: [PATCH][RFC] check for heap memory in zfree()
Date: Mon, 06 Mar 2006 08:25:53 -0800 [thread overview]
Message-ID: <060306082555.ZM4127@torch.brasslantern.com> (raw)
In-Reply-To: <EXCHANGE035nMVAPQNm00013268@exchange03.csr.com>
On Mar 6, 10:32am, Peter Stephenson wrote:
}
} Bart Schaefer wrote:
} > IMO a unique array is a distinct type from an ordinary array.
}
} I'm not convinced about that. I think it's just a tidying up operation
} performed on the value.
If it only happened on output, like -LRZ, I'd agree with you. But then
it would be worse than useless for dirstack.
} > For example, although you can (without getting warnings) set the -LRZ
} > options on any array, they don't have any effect except to make the
} > array show up in "typeset -LRZ" output.
}
} That's a bug, probably, although it might need care fixing (does the
} flag apply if the array is about to be joined?)
I'd be tempted to say they apply when joining with $arr[@] but not with
$arr[*], but -Z gives me pause. I guess I think -LR should work like
${(l:N:)...} and ${(r:N:)...}, which is where the [@] [*] distinction
comes from. I wish (l) were for lower-case and (r) for match-rest so
we could have (L:N:) (R:N:) and add (Z:N:), but it's years too late now.
} It doesn't make sense to have dirstack an integer, but it does makes
} sense to have it contain unique elements.
That could be made to "work" for dirstack by adopting something like
Andrey's 22320, where the set-fn is not called until after the new
flags are in place. dirssetfn() could then check for PM_UNIQUE and
frob PUSHD_IGNORE_DUPS to match.
I think that would be even more broken, though. The number of possible
bad interactions doubles -- people would be confused about why their
change to setopt reverts whenever they assign to dirstack, etc.
--
next prev parent reply other threads:[~2006-03-06 16:24 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20060302175252.GA31734@let.rug.nl>
[not found] ` <200603041104.48265.arvidjaar@mail.ru>
2006-03-04 8:57 ` Andrey Borzenkov
2006-03-05 9:13 ` Bart Schaefer
2006-03-05 17:23 ` Peter Stephenson
2006-03-05 20:43 ` Bart Schaefer
2006-03-06 10:32 ` Peter Stephenson
2006-03-06 16:25 ` Bart Schaefer [this message]
2006-03-04 9:28 ` [PATCH] Re: dirstack history: loving zsh, crashing zsh Andrey Borzenkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=060306082555.ZM4127@torch.brasslantern.com \
--to=schaefer@brasslantern.com \
--cc=zsh-workers@sunsite.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).