zsh-workers
 help / color / mirror / code / Atom feed
From: Bart Schaefer <schaefer@brasslantern.com>
To: Peter Stephenson <pws@csr.com>, Zsh Hackers <zsh-workers@sunsite.dk>
Subject: Re: Bug: Wrong completion of $(( $(!cmd
Date: Tue, 23 Jan 2007 07:23:44 -0800	[thread overview]
Message-ID: <070123072344.ZM12121@torch.brasslantern.com> (raw)
In-Reply-To: <200701231304.l0ND4b3t011195@news01.csr.com>

On Jan 23,  1:04pm, Peter Stephenson wrote:
}
} The problem is somewhere here (in lex.c). If dquote_parse() returns
} non-zero it's an error indication, not a character, so the hungetc(c)
} is definitely wrong in that case.

I don't think that's true.  If you look at the tail end of dquote_parse()
you'll see that if lexstop is false the return value of dquote_parse() is
overloaded -- it's both an error indication AND the most recently read
character from the input stream.  That's what hungetc() is trying to put
back in that spot in cmd_or_math().

That doesn't make it correct, but that's what's going on.  There must be
(or have been at some past time) some other reason higher up the parse
tree why that final character needed to be retained.


  parent reply	other threads:[~2007-01-23 15:24 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-01-06  2:35 Jörg Sommer
2007-01-22 23:43 ` Geoff Wing
2007-01-23 13:04   ` Peter Stephenson
2007-01-23 13:10     ` Peter Stephenson
2007-01-23 15:23     ` Bart Schaefer [this message]
2007-01-23 15:35       ` Peter Stephenson
2007-01-23 15:47         ` Bart Schaefer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=070123072344.ZM12121@torch.brasslantern.com \
    --to=schaefer@brasslantern.com \
    --cc=pws@csr.com \
    --cc=zsh-workers@sunsite.dk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).