zsh-workers
 help / color / mirror / code / Atom feed
From: Bart Schaefer <schaefer@brasslantern.com>
To: Clint Adams <schizo@debian.org>, zsh-workers@sunsite.dk
Cc: Erik Johansson <debian@ejohansson.se>, 416441@bugs.debian.org
Subject: Re: Bug#416441: Patch
Date: Sat, 31 Mar 2007 11:30:51 -0700	[thread overview]
Message-ID: <070331113051.ZM6989@torch.brasslantern.com> (raw)
In-Reply-To: <20070331170150.GA7626@scowler.net>

On Mar 31,  1:01pm, Clint Adams wrote:
} Subject: Re: Bug#416441: Patch
}
} On Sat, Mar 31, 2007 at 06:41:27PM +0200, Erik Johansson wrote:
} > The attached patch fixes the problem for me.
} 
} Thanks.
} 
} > --- _module.ORG	2007-03-31 17:47:42.000000000 +0200
} > +++ _module	2007-03-31 17:55:08.000000000 +0200
} > @@ -83,7 +83,7 @@
} >  # Fills the available modules cache
} >  _module_available_modules()
} >  {
} > -  if (( [[ -n "$MODULEPATH" ]] && [[ ${+_available_modules} -eq 0 ]] ));
} > +  if (( [[ -n $MODULEPATH ]] && [[ ${+_available_modules} -eq 0 ]] ));
} >    then
} >      _available_modules=($(find ${(e)=MODULEPATH//:/ } -xtype f -print 2>/dev/null | grep -v \.version | sed -e 's,\('${${(e)=MODULEPATH//:/\/\\\|}%\\\|}'\),,g' -e 's,^/*,,g'))
} >    fi
} 
} Why would this break zcompile?

What's up with the double parens?

    if (( ... this is parsed as a math expression ... ))

I don't know why zcompile chokes on that when the regular interpreter
does not, but it almost certainly ought to be a syntax error long before
the unmatched double-quote error that zcompile coughs up.

    if [[ -n $MODULEPATH ]] && [[ ${+_available_modules} -eq 0 ]]

without the excess parens and trailing semicolon, ought to be sufficient.


  reply	other threads:[~2007-03-31 23:58 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <200703311841.27521.debian@ejohansson.se>
2007-03-31 17:01 ` Clint Adams
2007-03-31 18:30   ` Bart Schaefer [this message]
2007-03-31 19:01     ` Clint Adams

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=070331113051.ZM6989@torch.brasslantern.com \
    --to=schaefer@brasslantern.com \
    --cc=416441@bugs.debian.org \
    --cc=debian@ejohansson.se \
    --cc=schizo@debian.org \
    --cc=zsh-workers@sunsite.dk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).