From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 10220 invoked from network); 16 Mar 2008 17:59:43 -0000 X-Spam-Checker-Version: SpamAssassin 3.2.4 (2008-01-01) on f.primenet.com.au X-Spam-Level: X-Spam-Status: No, score=-2.6 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.2.4 Received: from news.dotsrc.org (HELO a.mx.sunsite.dk) (130.225.247.88) by ns1.primenet.com.au with SMTP; 16 Mar 2008 17:59:43 -0000 Received-SPF: none (ns1.primenet.com.au: domain at sunsite.dk does not designate permitted sender hosts) Received: (qmail 84083 invoked from network); 16 Mar 2008 17:59:36 -0000 Received: from sunsite.dk (130.225.247.90) by a.mx.sunsite.dk with SMTP; 16 Mar 2008 17:59:36 -0000 Received: (qmail 5797 invoked by alias); 16 Mar 2008 17:59:32 -0000 Mailing-List: contact zsh-workers-help@sunsite.dk; run by ezmlm Precedence: bulk X-No-Archive: yes X-Seq: 24718 Received: (qmail 5784 invoked from network); 16 Mar 2008 17:59:31 -0000 Received: from bifrost.dotsrc.org (130.225.254.106) by sunsite.dk with SMTP; 16 Mar 2008 17:59:31 -0000 Received: from vms044pub.verizon.net (vms044pub.verizon.net [206.46.252.44]) by bifrost.dotsrc.org (Postfix) with ESMTP id 2AC7980307F7 for ; Sun, 16 Mar 2008 18:59:27 +0100 (CET) Received: from torch.brasslantern.com ([71.116.105.150]) by vms044.mailsrvcs.net (Sun Java System Messaging Server 6.2-6.01 (built Apr 3 2006)) with ESMTPA id <0JXU00IS94N2HLXC@vms044.mailsrvcs.net> for zsh-workers@sunsite.dk; Sun, 16 Mar 2008 12:59:27 -0500 (CDT) Received: from torch.brasslantern.com (localhost.localdomain [127.0.0.1]) by torch.brasslantern.com (8.13.1/8.13.1) with ESMTP id m2GHxPMX000845 for ; Sun, 16 Mar 2008 10:59:25 -0700 Received: (from schaefer@localhost) by torch.brasslantern.com (8.13.1/8.13.1/Submit) id m2GHxOtC000844 for zsh-workers@sunsite.dk; Sun, 16 Mar 2008 10:59:24 -0700 Date: Sun, 16 Mar 2008 10:59:24 -0700 From: Bart Schaefer Subject: Re: ${a[(i)pattern]} if a=() In-reply-to: <080316102021.ZM28339@torch.brasslantern.com> To: Zsh hackers list Message-id: <080316105924.ZM843@torch.brasslantern.com> MIME-version: 1.0 X-Mailer: OpenZMail Classic (0.9.2 24April2005) Content-type: text/plain; charset=us-ascii References: <20080316144038.GA4910@sc.homeunix.net> <080316102021.ZM28339@torch.brasslantern.com> Comments: In reply to Bart Schaefer "Re: ${a[(i)pattern]} if a=()" (Mar 16, 10:20am) X-Virus-Scanned: ClamAV 0.91.2/6263/Sun Mar 16 17:55:53 2008 on bifrost X-Virus-Status: Clean On Mar 16, 10:20am, Bart Schaefer wrote: } } } $ zsh -f -c 'a=(); echo ${a[(i)a]}' } } 0 } } Hmm ... it seems it has always returned zero when the array is empty. } It would seem to make more sense for it to return 1, but I'm worried } there are other unforseen consequences. The patch is trivial and all tests still pass. Thoughts? Index: Src/params.c =================================================================== RCS file: /extra/cvsroot/zsh/zsh-4.0/Src/params.c,v retrieving revision 1.40 diff -c -r1.40 params.c --- ../zsh-forge/current/Src/params.c 11 Jan 2008 01:18:07 -0000 +++ Src/params.c 16 Mar 2008 17:52:10 -0000 @@ -1317,7 +1317,7 @@ } else ta = getarrvalue(v); if (!ta || !*ta) - return 0; + return !down; len = arrlen(ta); if (beg < 0) beg += len;