From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 28639 invoked from network); 27 Apr 2008 16:48:26 -0000 X-Spam-Checker-Version: SpamAssassin 3.2.4 (2008-01-01) on f.primenet.com.au X-Spam-Level: X-Spam-Status: No, score=-2.6 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.2.4 Received: from news.dotsrc.org (HELO a.mx.sunsite.dk) (130.225.247.88) by ns1.primenet.com.au with SMTP; 27 Apr 2008 16:48:26 -0000 Received-SPF: none (ns1.primenet.com.au: domain at sunsite.dk does not designate permitted sender hosts) Received: (qmail 55763 invoked from network); 27 Apr 2008 16:48:19 -0000 Received: from sunsite.dk (130.225.247.90) by a.mx.sunsite.dk with SMTP; 27 Apr 2008 16:48:19 -0000 Received: (qmail 13893 invoked by alias); 27 Apr 2008 16:48:15 -0000 Mailing-List: contact zsh-workers-help@sunsite.dk; run by ezmlm Precedence: bulk X-No-Archive: yes X-Seq: 24885 Received: (qmail 13879 invoked from network); 27 Apr 2008 16:48:15 -0000 Received: from bifrost.dotsrc.org (130.225.254.106) by sunsite.dk with SMTP; 27 Apr 2008 16:48:15 -0000 Received: from vms046pub.verizon.net (vms046pub.verizon.net [206.46.252.46]) by bifrost.dotsrc.org (Postfix) with ESMTP id 7865B808A38B for ; Sun, 27 Apr 2008 18:48:11 +0200 (CEST) Received: from torch.brasslantern.com ([71.116.74.146]) by vms046.mailsrvcs.net (Sun Java System Messaging Server 6.2-6.01 (built Apr 3 2006)) with ESMTPA id <0JZZ00J35TC6HDQ3@vms046.mailsrvcs.net> for zsh-workers@sunsite.dk; Sun, 27 Apr 2008 11:48:07 -0500 (CDT) Received: from torch.brasslantern.com (localhost.localdomain [127.0.0.1]) by torch.brasslantern.com (8.13.1/8.13.1) with ESMTP id m3RGm4qE029500 for ; Sun, 27 Apr 2008 09:48:05 -0700 Received: (from schaefer@localhost) by torch.brasslantern.com (8.13.1/8.13.1/Submit) id m3RGm4Yw029499 for zsh-workers@sunsite.dk; Sun, 27 Apr 2008 09:48:04 -0700 Date: Sun, 27 Apr 2008 09:48:04 -0700 From: Bart Schaefer Subject: Re: PATCH: isearch match highlighting In-reply-to: <17393e3e0804261727s560acff7sb6125d8f8b46b4b4@mail.gmail.com> To: zsh-workers@sunsite.dk Message-id: <080427094804.ZM29498@torch.brasslantern.com> MIME-version: 1.0 X-Mailer: OpenZMail Classic (0.9.2 24April2005) Content-type: text/plain; charset=us-ascii References: <4827.1209250119@pws-pc> <17393e3e0804261727s560acff7sb6125d8f8b46b4b4@mail.gmail.com> Comments: In reply to "Matt Wozniski" "Re: PATCH: isearch match highlighting" (Apr 26, 8:27pm) X-Virus-Scanned: ClamAV 0.91.2/6967/Sun Apr 27 17:01:39 2008 on bifrost X-Virus-Status: Clean On Apr 26, 8:27pm, Matt Wozniski wrote: } Subject: Re: PATCH: isearch match highlighting } } On Sat, Apr 26, 2008 at 6:48 PM, Peter Stephenson wrote: } > I can't help feeling I must have screwed up this one somehow. } } zsh -f } bindkey -e } ^Rb } and the shell goes into a tight loop, using 100% of one of my cores, } and won't die to anything less than a kill -9. Anybody else see this? I can reproduce this. It's looping in #0 0x0020fbed in memset () from /lib/tls/libc.so.6 #1 0xbfee0bb0 in ?? () #2 0x080c03d0 in mb_metacharlenconv_r (s=0x9783eda "", wcp=0xbfee07d0, mbsp=0xbfee07b8) at ../../zsh-4.0/Src/utils.c:4008 #3 0x08116720 in doisearch (args=0x8169a1c, dir=-1, pattern=0) at ../../../zsh-4.0/Src/Zle/zle_hist.c:1408 mb_metacharlenconv_r() is returning 0 on the empty string (which a comment in utils.c says "probably shouldn't happen") so charpos is never incremented at line 1412 and the loop at line 1407 never stops. I think this means end_pos is wrong but I don't have time to try to chase that back through set_isearch_spot() right now, so we'll have to wait for PWS. Note that what's broken is the old history-incremental-search-backward. Everything works fine with history-incremental-pattern-search-backward.