From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 22540 invoked from network); 20 Jul 2008 08:05:48 -0000 X-Spam-Checker-Version: SpamAssassin 3.2.5 (2008-06-10) on f.primenet.com.au X-Spam-Level: X-Spam-Status: No, score=-2.6 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.2.5 Received: from news.dotsrc.org (HELO a.mx.sunsite.dk) (130.225.247.88) by ns1.primenet.com.au with SMTP; 20 Jul 2008 08:05:48 -0000 Received-SPF: none (ns1.primenet.com.au: domain at sunsite.dk does not designate permitted sender hosts) Received: (qmail 73717 invoked from network); 20 Jul 2008 08:05:42 -0000 Received: from sunsite.dk (130.225.247.90) by a.mx.sunsite.dk with SMTP; 20 Jul 2008 08:05:42 -0000 Received: (qmail 17550 invoked by alias); 20 Jul 2008 08:05:38 -0000 Mailing-List: contact zsh-workers-help@sunsite.dk; run by ezmlm Precedence: bulk X-No-Archive: yes X-Seq: 25311 Received: (qmail 17537 invoked from network); 20 Jul 2008 08:05:38 -0000 Received: from bifrost.dotsrc.org (130.225.254.106) by sunsite.dk with SMTP; 20 Jul 2008 08:05:38 -0000 Received: from vms173005pub.verizon.net (vms173005pub.verizon.net [206.46.173.5]) by bifrost.dotsrc.org (Postfix) with ESMTP id 4408380561C2 for ; Sun, 20 Jul 2008 10:05:23 +0200 (CEST) Received: from torch.brasslantern.com ([71.116.81.160]) by vms173005.mailsrvcs.net (Sun Java System Messaging Server 6.2-6.01 (built Apr 3 2006)) with ESMTPA id <0K4A00DVYP4YM566@vms173005.mailsrvcs.net> for zsh-workers@sunsite.dk; Sun, 20 Jul 2008 03:05:23 -0500 (CDT) Received: from torch.brasslantern.com (localhost.localdomain [127.0.0.1]) by torch.brasslantern.com (8.13.1/8.13.1) with ESMTP id m6K85Lns016497 for ; Sun, 20 Jul 2008 01:05:22 -0700 Received: (from schaefer@localhost) by torch.brasslantern.com (8.13.1/8.13.1/Submit) id m6K85LFA016496 for zsh-workers@sunsite.dk; Sun, 20 Jul 2008 01:05:21 -0700 Date: Sun, 20 Jul 2008 01:05:20 -0700 From: Bart Schaefer Subject: Re: Is there any interest in indentation patches? In-reply-to: <2d460de70807191721x683551cdifa946bf1b70e4cf7@mail.gmail.com> To: "Zsh hackers list" Message-id: <080720010521.ZM16495@torch.brasslantern.com> MIME-version: 1.0 X-Mailer: OpenZMail Classic (0.9.2 24April2005) Content-type: text/plain; charset=us-ascii References: <2d460de70807191721x683551cdifa946bf1b70e4cf7@mail.gmail.com> Comments: In reply to "Richard Hartmann" "Is there any interest in indentation patches?" (Jul 20, 2:21am) X-Virus-Scanned: ClamAV 0.92.1/7760/Sun Jul 20 04:11:36 2008 on bifrost X-Virus-Status: Clean On Jul 20, 2:21am, Richard Hartmann wrote: } } I have been going through a few functions You mean shell functions as opposed to C functions? } and there is no clear style when it comes to indentation. Some files } use whitespaces, some use tabs, many use a combination of the two. } Some use 2 chars, some use 4. No idea if the commit noise is wanted, } but I could prepare a batch of patches to fix this. My personal preference would be that this NOT be done. It makes it difficult to see from one file revision to the next what's a semantic change and what was merely whitespace being fixed up. It's one thing if the indentation is actually so bad that it impairs readability -- in that case I'd be more inclined to fix it. Changing strictly for the sake of consistency does not seem to me worthwhile. To maintain it going forward, we'd have to implement a policy of reformatting every function that is contributed to the sources.