zsh-workers
 help / color / mirror / code / Atom feed
From: Bart Schaefer <schaefer@brasslantern.com>
To: zsh-workers@sunsite.dk
Subject: Re: "pws non-canonical hack" problems
Date: Sat, 23 Aug 2008 07:55:49 -0700	[thread overview]
Message-ID: <080823075551.ZM5496@torch.brasslantern.com> (raw)
In-Reply-To: <20080823072446.GM8612@altlinux.org>

On Aug 23, 11:24am, Alexey I. Froloff wrote:
}
} _path_files:
} 377       # pws non-canonical hack which seems to work so far...
} 378       # if we didn't match by globbing, check that there is
} 379       # something to match by explicit name.  This is for
} 380       # `clever' filing systems where names pop into existence
} 381       # when referenced.
} 382       if (( ! $#tmp1 )); then
} 383           for tmp3 in "$tmp2[@]"; do
} 384               if [[ -n $tmp3 && $tmp3 != */ ]]; then
} 385                   tmp3+=/
} 386               fi
} 387               if [[ -e "$tmp3${(Q)PREFIX}${(Q)SUFFIX}" ]] then
} 388                   tmp1+=("$tmp3${(Q)PREFIX}${(Q)SUFFIX}")
} 389               fi
} 390           done
} 391       fi
} 
} When I completing directory, sometimes file is being completed.

The problem is that this code should not unconditionally append something
to tmp1.  It has to test again (probably by using some variant of the call
to compfiles that appears 20 or so lines above) that some new file really
was created that matches the qualifiers in the generated glob pattern.

Really this whole idea of attempting to complete things that don't exist
yet puts a huge amount of overhead on the cases where nothing ever will.

-- 


  reply	other threads:[~2008-08-23 14:56 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-08-23  7:24 Alexey I. Froloff
2008-08-23 14:55 ` Bart Schaefer [this message]
2008-08-25 16:47   ` Peter Stephenson
2008-08-26  1:19     ` Bart Schaefer
2008-09-01 17:14       ` Peter Stephenson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=080823075551.ZM5496@torch.brasslantern.com \
    --to=schaefer@brasslantern.com \
    --cc=zsh-workers@sunsite.dk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).