Re: Bug#497663: Tab completion for vim is broken

Re: Bug#497663: Tab completion for vim is broken

[Clint Adams]

On Thu, Sep 04, 2008 at 12:05:05PM +0300, Arto Jantunen wrote:
> >> Typing vim and pressing tab produces the following output:
> >> 
> >> _vim:31: unmatched '
> >> 
> >> Commenting out lines 31-40 in
> >> /usr/share/zsh/functions/Completion/Unix/_vim fixes the problem. Should
> >> be trivial to fix properly for someone who understands zsh's compeltion
> >> syntax (I don't).
> >
> > I can't reproduce this and I don't see what the problem might be.
> > Is this consistent for you?
> 
> Hmm. Apparently it depends on "emulate csh" being used. I can't
> reproduce with a .zshrc of only
> 
> autoload -U compinit
> compinit
> 
> But can after adding emulate csh above those lines.

Anyone know which option might be the culprit here?

Re: Bug#497663: Tab completion for vim is broken

[Frank Terbeck]

Clint Adams <schizo@debian.org>:
> On Thu, Sep 04, 2008 at 12:05:05PM +0300, Arto Jantunen wrote:
> > >> Typing vim and pressing tab produces the following output:
> > >> 
> > >> _vim:31: unmatched '
> > >> 
> > >> Commenting out lines 31-40 in
> > >> /usr/share/zsh/functions/Completion/Unix/_vim fixes the problem. Should
> > >> be trivial to fix properly for someone who understands zsh's compeltion
> > >> syntax (I don't).
> > >
> > > I can't reproduce this and I don't see what the problem might be.
> > > Is this consistent for you?
> > 
> > Hmm. Apparently it depends on "emulate csh" being used. I can't
> > reproduce with a .zshrc of only
> > 
> > autoload -U compinit
> > compinit
> > 
> > But can after adding emulate csh above those lines.
> 
> Anyone know which option might be the culprit here?

Yes, 'csh_junkie_quotes'.

The problem will vanish, if you unset that option after your 'emulate
csh' call.

However, I thought 'setopt no_csh_junkie_quotes' or 'emulate -L' at
the start of the file would be enough. But apparently it isn't...

Regards, Frank

-- 
In protocol design, perfection has been reached not when there is
nothing left to add, but when there is nothing left to take away.
                                                  -- RFC 1925

Re: Bug#497663: Tab completion for vim is broken

[Frank Terbeck]

Clint Adams <schizo@debian.org>:
> On Thu, Sep 04, 2008 at 12:05:05PM +0300, Arto Jantunen wrote:
> > >> Typing vim and pressing tab produces the following output:
> > >> 
> > >> _vim:31: unmatched '
> > >> 
> > >> Commenting out lines 31-40 in
> > >> /usr/share/zsh/functions/Completion/Unix/_vim fixes the problem. Should
> > >> be trivial to fix properly for someone who understands zsh's compeltion
> > >> syntax (I don't).
> > >
> > > I can't reproduce this and I don't see what the problem might be.
> > > Is this consistent for you?
> > 
> > Hmm. Apparently it depends on "emulate csh" being used. I can't
> > reproduce with a .zshrc of only
> > 
> > autoload -U compinit
> > compinit
> > 
> > But can after adding emulate csh above those lines.
> 
> Anyone know which option might be the culprit here?


This does the trick:

diff --git a/Completion/Unix/Command/_vim b/Completion/Unix/Command/_vim
index 684e027..da9295b 100644
--- a/Completion/Unix/Command/_vim
+++ b/Completion/Unix/Command/_vim
@@ -28,15 +31,15 @@ arguments=(
   '-C[make vim compatible with vi]'
   '-N[do not force compatibility with vi]'
   '(--nofork -f)'{--nofork,-f}'[do not detach the GUI version from the shell]'
-  '-V-[verbosity level]::verbosity:((0\:"do not display any messages"
-                                     1\:"display when viminfo file is read or written"
-                                     2\:"display sourced files"
-                                     5\:"display every searched tag-file"
-                                     8\:"display files that trigger autocommands"
-                                     9\:"display every triggered autocommand (default)"
-                                    12\:"display every executed function"
-                                    13\:"report every thrown, caught, finished, or discarded exception"
-                                    14\:"display anything pending in a \:finally clause"
+  '-V-[verbosity level]::verbosity:((0\:"do not display any messages" \
+                                     1\:"display when viminfo file is read or written" \
+                                     2\:"display sourced files" \
+                                     5\:"display every searched tag-file" \
+                                     8\:"display files that trigger autocommands" \
+                                     9\:"display every triggered autocommand (default)" \
+                                    12\:"display every executed function" \
+                                    13\:"report every thrown, caught, finished, or discarded exception" \
+                                    14\:"display anything pending in a \:finally clause" \
                                     15\:"display every executed ex-command"))'
   '-D[debugging mode]'
   '-n[no swap file (memory only)]'


But I don't understand, why this is not enough:

diff --git a/Completion/Unix/Command/_vim b/Completion/Unix/Command/_vim
index 684e027..44a317d 100644
--- a/Completion/Unix/Command/_vim
+++ b/Completion/Unix/Command/_vim
@@ -1,5 +1,7 @@
 #compdef vim exim gvim gex gview rvim rview rgvim rgview evim eview vimdiff gvimdiff
 
+emulate -L zsh
+
 (( $+functions[_vim_files] )) ||
 _vim_files () {
   case $PREFIX in

Regards, Frank

Re: Bug#497663: Tab completion for vim is broken

[Bart Schaefer]

On Sep 4,  2:06pm, Frank Terbeck wrote:
}
} But I don't understand, why this is not enough:
} 
} +emulate -L zsh
} +

The reason is that the eumulate doesn't take effect until the function
is executed, whereas the quoting error is returned at the time the
function is parsed.  "emulate" does not work like a perl "use" pragma.

Even PWS's _comp_setup change won't do any good if _vim somehow gets
autoloaded before _main_complete begins executing.  Unlikely, but ...

Re: Bug#497663: Tab completion for vim is broken

[Jun T.]

At 10:03 AM +0000 08.9.4, Clint Adams wrote:
>Anyone know which option might be the culprit here?

I guess it's CSH_JUNKIE_QUOTES.

Re: Bug#497663: Tab completion for vim is broken

[Peter Stephenson]

Clint Adams wrote:
> On Thu, Sep 04, 2008 at 12:05:05PM +0300, Arto Jantunen wrote:
> > >> Typing vim and pressing tab produces the following output:
> > >> 
> > >> _vim:31: unmatched '
> > >> 
> > >> Commenting out lines 31-40 in
> > >> /usr/share/zsh/functions/Completion/Unix/_vim fixes the problem. Should
> > >> be trivial to fix properly for someone who understands zsh's compeltion
> > >> syntax (I don't).
> > >
> > > I can't reproduce this and I don't see what the problem might be.
> > > Is this consistent for you?
> > 
> > Hmm. Apparently it depends on "emulate csh" being used. I can't
> > reproduce with a .zshrc of only
> > 
> > autoload -U compinit
> > compinit
> > 
> > But can after adding emulate csh above those lines.
> 
> Anyone know which option might be the culprit here?

csh_junkie_quotes

--- ../zsh-debug/zsh/Completion/compinit	2008-06-06 17:43:35.000000000 +0100
+++ Completion/compinit	2008-09-04 13:34:21.000000000 +0100
@@ -139,6 +139,7 @@
     NO_allexport
     NO_aliases
     NO_cshnullglob
+    NO_cshjunkiequotes
     NO_errexit
     NO_globsubst
     NO_histsubstpattern


-- 
Peter Stephenson <pws@csr.com>                  Software Engineer
CSR PLC, Churchill House, Cambridge Business Park, Cowley Road
Cambridge, CB4 0WZ, UK                          Tel: +44 (0)1223 692070

Re: Bug#497663: Tab completion for vim is broken

[Bart Schaefer]

On Sep 4, 10:03am, Clint Adams wrote:
} Subject: Re: Bug#497663: Tab completion for vim is broken
}
} On Thu, Sep 04, 2008 at 12:05:05PM +0300, Arto Jantunen wrote:
} > >> Typing vim and pressing tab produces the following output:
} > >> 
} > >> _vim:31: unmatched '
} > 
} > Hmm. Apparently it depends on "emulate csh" being used.
} 
} Anyone know which option might be the culprit here?

Line 31 of _vim is a single-quoted string that spans multiple lines.

So CSH_JUNKIE_QUOTES is almost certainly at fault.

Re: Bug#497663: Tab completion for vim is broken

[Wesley Schwengle]

On 04.09.08 13:44 Frank Terbeck wrote:

> Clint Adams <schizo@debian.org>:
>> On Thu, Sep 04, 2008 at 12:05:05PM +0300, Arto Jantunen wrote:
>>>>> Typing vim and pressing tab produces the following output:
>>>>> 
>>>>> _vim:31: unmatched '
>>>>> 
>>>>> Commenting out lines 31-40 in
>>>>> /usr/share/zsh/functions/Completion/Unix/_vim fixes the problem. Should
>>>>> be trivial to fix properly for someone who understands zsh's compeltion
>>>>> syntax (I don't).
>>>> 
>>>> I can't reproduce this and I don't see what the problem might be.
>>>> Is this consistent for you?
>>> 
>>> Hmm. Apparently it depends on "emulate csh" being used. I can't
>>> reproduce with a .zshrc of only
>>> 
>>> autoload -U compinit
>>> compinit
>>> 
>>> But can after adding emulate csh above those lines.
>> 
>> Anyone know which option might be the culprit here?
> 
> Yes, 'csh_junkie_quotes'.
> 
> The problem will vanish, if you unset that option after your 'emulate
> csh' call.
> 
> However, I thought 'setopt no_csh_junkie_quotes' or 'emulate -L' at
> the start of the file would be enough. But apparently it isn't...

I submitted a bugreport to Ubuntu about this issue:

https://bugs.launchpad.net/ubuntu/+source/zsh/+bug/264644

The bugreport includes patches for vim, less and diff_options.

I also have setopt CSHJUNKIEQUOTES enabled in my .zshrc..

Cheers,
Wesley

Re: Bug#497663: Tab completion for vim is broken

[Wesley Schwengle]

On 16.09.08 13:49 Wesley Germaine Schwengle wrote:

> I submitted a bugreport to Ubuntu about this issue:
>
> https://bugs.launchpad.net/ubuntu/+source/zsh/+bug/264644
>
> The bugreport includes patches for vim, less and diff_options.
>
> I also have setopt CSHJUNKIEQUOTES enabled in my .zshrc..

On zsh version 4.3.2 the autocompletion is working without the need to patch
the completion files.

The bug is introduced in either 4.3.3 or 4.3.4.

Cheers,
Wesley