From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 23492 invoked from network); 5 Oct 2008 20:09:35 -0000 X-Spam-Checker-Version: SpamAssassin 3.2.5 (2008-06-10) on f.primenet.com.au X-Spam-Level: X-Spam-Status: No, score=-2.6 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.2.5 Received: from news.dotsrc.org (HELO a.mx.sunsite.dk) (130.225.247.88) by ns1.primenet.com.au with SMTP; 5 Oct 2008 20:09:35 -0000 Received-SPF: none (ns1.primenet.com.au: domain at sunsite.dk does not designate permitted sender hosts) Received: (qmail 48547 invoked from network); 5 Oct 2008 20:09:24 -0000 Received: from sunsite.dk (130.225.247.90) by a.mx.sunsite.dk with SMTP; 5 Oct 2008 20:09:24 -0000 Received: (qmail 19688 invoked by alias); 5 Oct 2008 20:09:16 -0000 Mailing-List: contact zsh-workers-help@sunsite.dk; run by ezmlm Precedence: bulk X-No-Archive: yes X-Seq: 25814 Received: (qmail 19670 invoked from network); 5 Oct 2008 20:09:15 -0000 Received: from bifrost.dotsrc.org (130.225.254.106) by sunsite.dk with SMTP; 5 Oct 2008 20:09:15 -0000 Received: from vms172071pub.verizon.net (vms172071pub.verizon.net [206.46.172.71]) by bifrost.dotsrc.org (Postfix) with ESMTP id 8B5FD80308BD for ; Sun, 5 Oct 2008 22:08:58 +0200 (CEST) Received: from torch.brasslantern.com ([96.238.220.215]) by vms172071.mailsrvcs.net (Sun Java System Messaging Server 6.2-6.01 (built Apr 3 2006)) with ESMTPA id <0K8A00LUE55VUWF6@vms172071.mailsrvcs.net> for zsh-workers@sunsite.dk; Sun, 05 Oct 2008 14:08:20 -0500 (CDT) Received: from torch.brasslantern.com (localhost.localdomain [127.0.0.1]) by torch.brasslantern.com (8.13.1/8.13.1) with ESMTP id m95J8I1d015226 for ; Sun, 05 Oct 2008 12:08:18 -0700 Received: (from schaefer@localhost) by torch.brasslantern.com (8.13.1/8.13.1/Submit) id m95J8H1P015225 for zsh-workers@sunsite.dk; Sun, 05 Oct 2008 12:08:17 -0700 Date: Sun, 05 Oct 2008 12:08:17 -0700 From: Bart Schaefer Subject: Re: [rfc + bad patch] Allow to get the current cursor command from zle, for doing a nicer run-help. In-reply-to: <237967ef0810050640n7c536bafl9255e870f83d15f8@mail.gmail.com> To: zsh-workers Message-id: <081005120817.ZM15224@torch.brasslantern.com> MIME-version: 1.0 X-Mailer: OpenZMail Classic (0.9.2 24April2005) Content-type: text/plain; charset=us-ascii References: <237967ef0810050640n7c536bafl9255e870f83d15f8@mail.gmail.com> Comments: In reply to "Mikael Magnusson" "[rfc + bad patch] Allow to get the current cursor command from zle, for doing a nicer run-help." (Oct 5, 3:40pm) X-Virus-Scanned: ClamAV 0.92.1/8376/Sun Oct 5 21:09:44 2008 on bifrost X-Virus-Status: Clean On Oct 5, 3:40pm, Mikael Magnusson wrote: } } Let's say you have the command line } git add -u; git commit - # hmm, was it -m or -M for message? *press alt-h* } Now, also assume you have the run-help-git stuff set up, but it will still } show you the manpage for git-add instead of git-commit. This points out a more generalized bug in Functions/Misc/run-help as it currently is implemented. If you have, for example zsh% run-help-less() { print $* } zsh% print this is not less but the next is; less /etc/termcap If you now hit ESC-h to invoke run-help, you get: but the next is and then the command "less /etc/termcap" is *executed*. The "eval" in Functions/Misc/run-help needs a (q) parameter expansion flag added, at the very least. } Since the run-help widget does a push-line, we can't use $CURSOR to } find out which is the actual command, this is how i solved it. It should be possible to solve this without resorting to hacking the C source. All you need is a user-defined ZLE widget that runs as a wrapper around the run-help widget to save the value of CURSOR. E.g.: run_help_cursor () { typeset -g HELPCURSOR=$CURSOR zle .run-help "$@" } zle -N run-help run_help_cursor Except that you're using CURSOR in your _runhelp function, so it must already be a widget? You didn't show a usage example. It might be nice if the .run-help widget saved the cursor position itself, or behaved more like a completion widget and passed an array containing only the command words "around" the cursor, stripping from separators on either side. *That* would require C hacking. In any case I think your function will still do the wrong thing for something like "git commit git", though that's admittedly not a very likely scenario. --- run-help 13 Mar 2008 15:46:07 -0000 1.4 +++ run-help 5 Oct 2008 18:05:54 -0000 @@ -100,7 +100,7 @@ do shift cmd_args done - eval "run-help-$1:t ${(@)cmd_args[2,-1]}" + eval "run-help-$1:t ${(q@)cmd_args[2,-1]}" else man $@:t fi