From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 4336 invoked from network); 17 Jan 2009 18:08:50 -0000 X-Spam-Checker-Version: SpamAssassin 3.2.5 (2008-06-10) on f.primenet.com.au X-Spam-Level: X-Spam-Status: No, score=-2.5 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.2.5 Received: from news.dotsrc.org (HELO a.mx.sunsite.dk) (130.225.247.88) by ns1.primenet.com.au with SMTP; 17 Jan 2009 18:08:50 -0000 Received-SPF: none (ns1.primenet.com.au: domain at sunsite.dk does not designate permitted sender hosts) Received: (qmail 38435 invoked from network); 17 Jan 2009 18:08:46 -0000 Received: from sunsite.dk (130.225.247.90) by a.mx.sunsite.dk with SMTP; 17 Jan 2009 18:08:46 -0000 Received: (qmail 13956 invoked by alias); 17 Jan 2009 18:08:41 -0000 Mailing-List: contact zsh-workers-help@sunsite.dk; run by ezmlm Precedence: bulk X-No-Archive: yes X-Seq: 26347 Received: (qmail 13946 invoked from network); 17 Jan 2009 18:08:41 -0000 Received: from bifrost.dotsrc.org (130.225.254.106) by sunsite.dk with SMTP; 17 Jan 2009 18:08:41 -0000 Received: from vms173003pub.verizon.net (vms173003pub.verizon.net [206.46.173.3]) by bifrost.dotsrc.org (Postfix) with ESMTP id 1D94D80271F0 for ; Sat, 17 Jan 2009 19:08:26 +0100 (CET) Received: from torch.brasslantern.com ([96.238.220.215]) by vms173003.mailsrvcs.net (Sun Java System Messaging Server 6.2-6.01 (built Apr 3 2006)) with ESMTPA id <0KDM00FUWNPW7I60@vms173003.mailsrvcs.net> for zsh-workers@sunsite.dk; Sat, 17 Jan 2009 12:08:25 -0600 (CST) Received: from torch.brasslantern.com (localhost.localdomain [127.0.0.1]) by torch.brasslantern.com (8.13.1/8.13.1) with ESMTP id n0HI8DSA023496 for ; Sat, 17 Jan 2009 10:08:14 -0800 Received: (from schaefer@localhost) by torch.brasslantern.com (8.13.1/8.13.1/Submit) id n0HI8DEO023495 for zsh-workers@sunsite.dk; Sat, 17 Jan 2009 10:08:13 -0800 Date: Sat, 17 Jan 2009 10:08:12 -0800 From: Bart Schaefer Subject: Re: PATCH: add zle-line-finish special widget In-reply-to: To: zsh-workers@sunsite.dk Message-id: <090117100812.ZM23494@torch.brasslantern.com> MIME-version: 1.0 X-Mailer: OpenZMail Classic (0.9.2 24April2005) Content-type: text/plain; charset=us-ascii References: <18789.30656.261463.382208@gargle.gargle.HOWL> <20090110095231.GA61601@redoubt.spodhuis.org> <20090111025418.GA7272@redoubt.spodhuis.org> <090111110748.ZM12349@torch.brasslantern.com> <090111193317.ZM12655@torch.brasslantern.com> Comments: In reply to Greg Klanderman "PATCH: add zle-line-finish special widget" (Jan 16, 6:54pm) X-Virus-Scanned: ClamAV 0.92.1/8873/Sat Jan 17 04:33:31 2009 on bifrost X-Virus-Status: Clean On Jan 16, 6:54pm, Greg Klanderman wrote: } } Bart also made the following comments on my original patch which I } have not addressed: } } > it's possible that the zle-line-finish widget should not run when } > errflag != 0. } } > I don't know all the ramifications of the values of various globals } > at the end of zlecore(). PWS? } } Peter, could you comment? One thing related to another thread is that zle-line-finish will run when push-line-or-edit is used, between the push-input and get-line stages. zle-line-finish will also run *after* send-break, i.e., it will run even if you interrupt editing with ^C. Both of those would be avoided if zle-line-finish runs only when errflag != 0. Refreshing my memory of the code a bit, I'm coming to the conclusion that the test should be: if (done && !exit_pending && !errflag && (initthingy = rthingy_nocreate("zle-line-finish"))) { At the very least it should check (done && !exit_pending), even if it ignores the state of errflag.