From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 19756 invoked from network); 8 Mar 2009 21:34:21 -0000 X-Spam-Checker-Version: SpamAssassin 3.2.5 (2008-06-10) on f.primenet.com.au X-Spam-Level: X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00 autolearn=ham version=3.2.5 Received: from news.dotsrc.org (HELO a.mx.sunsite.dk) (130.225.247.88) by ns1.primenet.com.au with SMTP; 8 Mar 2009 21:34:21 -0000 Received-SPF: none (ns1.primenet.com.au: domain at sunsite.dk does not designate permitted sender hosts) Received: (qmail 53312 invoked from network); 8 Mar 2009 21:34:19 -0000 Received: from sunsite.dk (130.225.247.90) by a.mx.sunsite.dk with SMTP; 8 Mar 2009 21:34:19 -0000 Received: (qmail 5144 invoked by alias); 8 Mar 2009 21:34:13 -0000 Mailing-List: contact zsh-workers-help@sunsite.dk; run by ezmlm Precedence: bulk X-No-Archive: yes X-Seq: 26698 Received: (qmail 5124 invoked from network); 8 Mar 2009 21:34:12 -0000 Received: from bifrost.dotsrc.org (130.225.254.106) by sunsite.dk with SMTP; 8 Mar 2009 21:34:12 -0000 Received: from vms173009pub.verizon.net (vms173009pub.verizon.net [206.46.173.9]) by bifrost.dotsrc.org (Postfix) with ESMTP id D50E680307F8 for ; Sun, 8 Mar 2009 22:34:07 +0100 (CET) Received: from torch.brasslantern.com ([96.249.201.13]) by vms173009.mailsrvcs.net (Sun Java(tm) System Messaging Server 6.3-7.04 (built Sep 26 2008; 32bit)) with ESMTPA id <0KG70020OIKC6O4H@vms173009.mailsrvcs.net> for zsh-workers@sunsite.dk; Sun, 08 Mar 2009 16:33:53 -0500 (CDT) Received: from torch.brasslantern.com (localhost.localdomain [127.0.0.1]) by torch.brasslantern.com (8.13.1/8.13.1) with ESMTP id n28LXlvr022659 for ; Sun, 08 Mar 2009 14:33:47 -0700 Received: (from schaefer@localhost) by torch.brasslantern.com (8.13.1/8.13.1/Submit) id n28LXkJb022658 for zsh-workers@sunsite.dk; Sun, 08 Mar 2009 14:33:46 -0700 From: Bart Schaefer Message-id: <090308143346.ZM22657@torch.brasslantern.com> Date: Sun, 08 Mar 2009 14:33:46 -0700 In-reply-to: <20090308195518.7d1e7ee8@pws-pc> Comments: In reply to Peter Stephenson "Re: Modules/attr.c compile error on Mac OS X" (Mar 8, 7:55pm) References: <16c5bb260903080021k4da0e6b1g8e40cc7520f84e8@mail.gmail.com> <20090308195518.7d1e7ee8@pws-pc> X-Mailer: OpenZMail Classic (0.9.2 24April2005) To: zsh-workers@sunsite.dk Subject: Re: Modules/attr.c compile error on Mac OS X MIME-version: 1.0 Content-type: text/plain; charset=us-ascii X-Virus-Scanned: ClamAV 0.92.1/9080/Fri Mar 6 20:13:38 2009 on bifrost X-Virus-Status: Clean (Aside: Sourceforge CVS access is really slow right now.) On Mar 8, 7:55pm, Peter Stephenson wrote: } Subject: Re: Modules/attr.c compile error on Mac OS X } } On Sun, 8 Mar 2009 17:21:47 +0900 } Taro M wrote: } > The new Modules/attr.c does not compile on Mac OS X (and probably others): } } I don't know about the others, and you don't say, but a bit of research } suggests Mac OS X takes some extra arguments. I don't have Mac OS X so } can't test that; if it still doesn't compile, please could one of the } numerous Mac users provide a patch. Compiling on MacOS now ... snippet of config.log: configure:13232: checking if getxattr etc. are Linux-like configure:13264: gcc -c -Wall -Wmissing-prototypes -O2 conftest.c >&5 conftest.c: In function 'main': conftest.c:211: error: too few arguments to function 'listxattr' conftest.c:212: error: too few arguments to function 'getxattr' conftest.c:213: error: too few arguments to function 'setxattr' conftest.c:214: error: too few arguments to function 'removexattr' configure:13270: $? = 1 configure: failed program was: (omitted) configure:13285: result: no configure:13289: checking if getxattr etc. are MAC-like configure:13319: gcc -c -Wall -Wmissing-prototypes -O2 conftest.c >&5 configure:13325: $? = 0 configure:13340: result: yes configure:13352: checking if getxattr etc. are usable configure:13364: result: yes However, it didn't build the attr module. Still didn't build it after a "make clean". Missing dependency? Trying again from "make distclean": OK, compiled the attr module that time. } If it compiles but doesn't work, } I will need someone else to research the problem. I tried this: % zmodload zsh/attr % for x in /*; print -R $x $'\t= ' $(zlistattr $x) /Applications = /Desktop DB = com.apple.FinderInfo /Desktop DF = com.apple.FinderInfo /Developer = com.apple.FinderInfo /Library = /Network = com.apple.FinderInfo /System = /User Guides And Information = com.apple.FinderInfo /Users = /Volumes = com.apple.FinderInfo /bin = com.apple.FinderInfo /cores = com.apple.FinderInfo /dev = /etc = /home = /mach.sym = com.apple.FinderInfo /mach_kernel = com.apple.FinderInfo /mach_kernel.ctfsys = com.apple.FinderInfo /net = /opt = /private = com.apple.FinderInfo /sbin = com.apple.FinderInfo /tmp = /usr = com.apple.FinderInfo /var = com.apple.FinderInfo Is there more that should be tested? } ... patches are useful even if incomplete (and preferred to text } statements along the lines of "wouldn't it be better to change ..."). Pardon for my tendency to do that lately. My inclination is to avoid sending a patch unless I actually intend for someone to apply it, so if I'm not certain about a change ...