zsh-workers
 help / color / mirror / code / Atom feed
From: Bart Schaefer <schaefer@brasslantern.com>
To: gak@klanderman.net, Zsh list <zsh-workers@sunsite.dk>
Subject: Re: debug print left in 'run-help'?
Date: Sat, 25 Apr 2009 13:10:49 -0700	[thread overview]
Message-ID: <090425131051.ZM13157@torch.brasslantern.com> (raw)
In-Reply-To: <18925.60567.301071.766082@gargle.gargle.HOWL>

On Apr 21, 11:56am, Greg Klanderman wrote:
} Subject: debug print left in 'run-help'?
}
} There seems to be a spurious debug print statement left in
} the 'run-help' function, at around line 57:
} 
} |    builtin print -r $what
} 
} Should/can this be removed?

I see that PWS committed this, but I think that was wrong.  That print
has always been there since the first revision of run-help, and is not
a spurious debugging statement.

It's intended to make sure that useful output is produced in the event
that the case-statement that follows it branches off into an unexpected
place or outputs nothing.  For example, with that "builtin print"
statement present:

schaefer[524] ls<ESC-h>
schaefer[524] run-help ls
ls is an alias for ls -CF
Press any key for more help or q to quit

At this point if you press anything other than "q", you get the manual
page for "ls".

With that "builtin print" removed:

schaefer[526] ls<ESC-h>
schaefer[526] run-help ls
Press any key for more help or q to quit

Umm, no.

Please back out this change.

-- 


  reply	other threads:[~2009-04-25 20:11 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-04-21 15:56 Greg Klanderman
2009-04-25 20:10 ` Bart Schaefer [this message]
2009-04-27 20:45   ` Greg Klanderman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=090425131051.ZM13157@torch.brasslantern.com \
    --to=schaefer@brasslantern.com \
    --cc=gak@klanderman.net \
    --cc=zsh-workers@sunsite.dk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).