From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 18020 invoked from network); 25 Apr 2009 20:11:23 -0000 X-Spam-Checker-Version: SpamAssassin 3.2.5 (2008-06-10) on f.primenet.com.au X-Spam-Level: X-Spam-Status: No, score=-2.6 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.2.5 Received: from news.dotsrc.org (HELO a.mx.sunsite.dk) (130.225.247.88) by ns1.primenet.com.au with SMTP; 25 Apr 2009 20:11:23 -0000 Received-SPF: none (ns1.primenet.com.au: domain at sunsite.dk does not designate permitted sender hosts) Received: (qmail 50829 invoked from network); 25 Apr 2009 20:11:18 -0000 Received: from sunsite.dk (130.225.247.90) by a.mx.sunsite.dk with SMTP; 25 Apr 2009 20:11:18 -0000 Received: (qmail 21691 invoked by alias); 25 Apr 2009 20:11:12 -0000 Mailing-List: contact zsh-workers-help@sunsite.dk; run by ezmlm Precedence: bulk X-No-Archive: yes X-Seq: 26880 Received: (qmail 21677 invoked from network); 25 Apr 2009 20:11:12 -0000 Received: from bifrost.dotsrc.org (130.225.254.106) by sunsite.dk with SMTP; 25 Apr 2009 20:11:12 -0000 Received: from vms173003pub.verizon.net (vms173003pub.verizon.net [206.46.173.3]) by bifrost.dotsrc.org (Postfix) with ESMTP id 35DF18028C72 for ; Sat, 25 Apr 2009 22:09:31 +0200 (CEST) Received: from torch.brasslantern.com ([96.249.201.13]) by vms173003.mailsrvcs.net (Sun Java(tm) System Messaging Server 6.3-7.04 (built Sep 26 2008; 32bit)) with ESMTPA id <0KIO001VXAQ5KN4S@vms173003.mailsrvcs.net> for zsh-workers@sunsite.dk; Sat, 25 Apr 2009 15:10:54 -0500 (CDT) Received: from torch.brasslantern.com (localhost.localdomain [127.0.0.1]) by torch.brasslantern.com (8.13.1/8.13.1) with ESMTP id n3PKAqvY013159; Sat, 25 Apr 2009 13:10:52 -0700 Received: (from schaefer@localhost) by torch.brasslantern.com (8.13.1/8.13.1/Submit) id n3PKApuN013158; Sat, 25 Apr 2009 13:10:51 -0700 From: Bart Schaefer Message-id: <090425131051.ZM13157@torch.brasslantern.com> Date: Sat, 25 Apr 2009 13:10:49 -0700 In-reply-to: <18925.60567.301071.766082@gargle.gargle.HOWL> Comments: In reply to Greg Klanderman "debug print left in 'run-help'?" (Apr 21, 11:56am) References: <18925.60567.301071.766082@gargle.gargle.HOWL> X-Mailer: OpenZMail Classic (0.9.2 24April2005) To: gak@klanderman.net, Zsh list Subject: Re: debug print left in 'run-help'? MIME-version: 1.0 Content-type: text/plain; charset=us-ascii X-Virus-Scanned: ClamAV 0.92.1/9289/Sat Apr 25 12:11:31 2009 on bifrost X-Virus-Status: Clean On Apr 21, 11:56am, Greg Klanderman wrote: } Subject: debug print left in 'run-help'? } } There seems to be a spurious debug print statement left in } the 'run-help' function, at around line 57: } } | builtin print -r $what } } Should/can this be removed? I see that PWS committed this, but I think that was wrong. That print has always been there since the first revision of run-help, and is not a spurious debugging statement. It's intended to make sure that useful output is produced in the event that the case-statement that follows it branches off into an unexpected place or outputs nothing. For example, with that "builtin print" statement present: schaefer[524] ls schaefer[524] run-help ls ls is an alias for ls -CF Press any key for more help or q to quit At this point if you press anything other than "q", you get the manual page for "ls". With that "builtin print" removed: schaefer[526] ls schaefer[526] run-help ls Press any key for more help or q to quit Umm, no. Please back out this change. --