From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 7376 invoked from network); 29 Sep 2009 14:45:41 -0000 X-Spam-Checker-Version: SpamAssassin 3.2.5 (2008-06-10) on f.primenet.com.au X-Spam-Level: X-Spam-Status: No, score=-2.5 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.2.5 Received: from new-brage.dotsrc.org (HELO a.mx.sunsite.dk) (130.225.254.104) by ns1.primenet.com.au with SMTP; 29 Sep 2009 14:45:41 -0000 Received-SPF: none (ns1.primenet.com.au: domain at sunsite.dk does not designate permitted sender hosts) Received: (qmail 15180 invoked from network); 29 Sep 2009 14:45:37 -0000 Received: from sunsite.dk (130.225.247.90) by a.mx.sunsite.dk with SMTP; 29 Sep 2009 14:45:37 -0000 Received: (qmail 26863 invoked by alias); 29 Sep 2009 14:45:34 -0000 Mailing-List: contact zsh-workers-help@sunsite.dk; run by ezmlm Precedence: bulk X-No-Archive: yes X-Seq: 27294 Received: (qmail 26848 invoked from network); 29 Sep 2009 14:45:34 -0000 Received: from bifrost.dotsrc.org (130.225.254.106) by sunsite.dk with SMTP; 29 Sep 2009 14:45:34 -0000 Received: from vms173011pub.verizon.net (vms173011pub.verizon.net [206.46.173.11]) by bifrost.dotsrc.org (Postfix) with ESMTP id B7BF6808ECB9 for ; Tue, 29 Sep 2009 16:45:27 +0200 (CEST) Received: from torch.brasslantern.com ([96.238.222.107]) by vms173011.mailsrvcs.net (Sun Java(tm) System Messaging Server 6.3-7.04 (built Sep 26 2008; 32bit)) with ESMTPA id <0KQQ00A9EMB0A747@vms173011.mailsrvcs.net> for zsh-workers@sunsite.dk; Tue, 29 Sep 2009 09:45:07 -0500 (CDT) Received: from torch.brasslantern.com (localhost.localdomain [127.0.0.1]) by torch.brasslantern.com (8.13.1/8.13.1) with ESMTP id n8TEj0ds019745 for ; Tue, 29 Sep 2009 07:45:00 -0700 Received: (from schaefer@localhost) by torch.brasslantern.com (8.13.1/8.13.1/Submit) id n8TEixQJ019744 for zsh-workers@sunsite.dk; Tue, 29 Sep 2009 07:44:59 -0700 From: Bart Schaefer Message-id: <090929074459.ZM19743@torch.brasslantern.com> Date: Tue, 29 Sep 2009 07:44:59 -0700 In-reply-to: Comments: In reply to "Jun T." "Re: Rebuilding from CVS on Snow Leopard" (Sep 29, 9:05pm) References: <090927225016.ZM17646@torch.brasslantern.com> X-Mailer: OpenZMail Classic (0.9.2 24April2005) To: zsh-workers@sunsite.dk Subject: Re: Rebuilding from CVS on Snow Leopard MIME-version: 1.0 Content-type: text/plain; charset=us-ascii X-Virus-Scanned: ClamAV 0.94.2/9851/Tue Sep 29 15:16:55 2009 on bifrost X-Virus-Status: Clean On Sep 29, 9:05pm, Jun T. wrote: } Subject: Re: Rebuilding from CVS on Snow Leopard } } I think it would be better to use sizeof(soun.sun_path) in place } of UNIX_PATH_MAX. Or use sizeof(soun.sun_path)-1 so that sun_path } is always null terminated. How about this, then? Index: socket.c =================================================================== RCS file: /extra/cvsroot/zsh/zsh-4.0/Src/Modules/socket.c,v retrieving revision 1.9 diff -c -r1.9 socket.c --- socket.c 26 Nov 2007 17:38:14 -0000 1.9 +++ socket.c 29 Sep 2009 14:42:00 -0000 @@ -34,7 +34,7 @@ #include #ifndef UNIX_PATH_MAX -# define UNIX_PATH_MAX 108 +# define UNIX_PATH_MAX (sizeof(soun.sun_path)-1) #endif /* (Or the equivalent without the dependency on the local variable name "soun".)