From: Bart Schaefer <schaefer@brasslantern.com>
To: gak@klanderman.net, zsh-workers@zsh.org
Subject: Re: bug in 'rm' completion
Date: Mon, 09 Nov 2009 09:29:26 -0800 [thread overview]
Message-ID: <091109092926.ZM26572@torch.brasslantern.com> (raw)
In-Reply-To: <m38wef4qqs.fsf@klanderman.net>
On Nov 9, 11:17am, Greg Klanderman wrote:
}
} The patch below seems to fix the problem, provided you are completing
} the last word on the line.
You forgot the patch.
} Can someone explain where $line is coming from in _rm?
It's declared in both _main_complete and _arguments and appears to be
set by "comparguments -W" at _arguments:377. Unfortunately there's no
good documentation for "comparguments" because it was treated as a
helper builtin that no end user would ever need to call directly.
} BTW, what's the deal with _files vs _path_files?
The main thing is that _files handles grouping the files according
to the files, directories, etc. according to the file-patterns zstyle.
_path_files is a lower-level function that manages the path traversal
to find appropriate files to complete. Most cases probably ought to
be calling _files unless the intent is to impose a different kind of
grouping or to avoid having file-patterns applied, but it's a bit of a
judgment call in each instance.
next prev parent reply other threads:[~2009-11-09 18:30 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-09 5:29 Greg Klanderman
2009-11-09 16:17 ` Greg Klanderman
2009-11-09 17:29 ` Bart Schaefer [this message]
2009-11-09 17:52 ` Greg Klanderman
2009-11-09 21:20 ` Greg Klanderman
2009-11-10 15:52 ` Bart Schaefer
2009-11-12 2:48 ` Greg Klanderman
2009-11-12 4:21 ` Bart Schaefer
2009-11-12 17:22 ` Greg Klanderman
2009-11-09 16:29 ` Bart Schaefer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=091109092926.ZM26572@torch.brasslantern.com \
--to=schaefer@brasslantern.com \
--cc=gak@klanderman.net \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).